From 38c4be4379bb307fab98d448b3ac0959b714817d Mon Sep 17 00:00:00 2001 From: cpfeiffer Date: Wed, 24 Aug 2016 23:14:25 +0200 Subject: [PATCH] Remove isEqual() in favor of Objects.equals() --- .../gadgetbridge/database/DBHelper.java | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/database/DBHelper.java b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/database/DBHelper.java index eb9a8069..19830291 100644 --- a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/database/DBHelper.java +++ b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/database/DBHelper.java @@ -15,6 +15,7 @@ import java.util.Calendar; import java.util.Date; import java.util.List; import java.util.Locale; +import java.util.Objects; import de.greenrobot.dao.query.Query; import nodomain.freeyourgadget.gadgetbridge.GBApplication; @@ -265,25 +266,15 @@ public class DBHelper { } private static boolean isEqual(DeviceAttributes attr, GBDevice gbDevice) { - if (!isEqual(attr.getFirmwareVersion1(), gbDevice.getFirmwareVersion())) { + if (!Objects.equals(attr.getFirmwareVersion1(), gbDevice.getFirmwareVersion())) { return false; } - if (!isEqual(attr.getFirmwareVersion2(), gbDevice.getFirmwareVersion2())) { + if (!Objects.equals(attr.getFirmwareVersion2(), gbDevice.getFirmwareVersion2())) { return false; } return true; } - private static boolean isEqual(String s1, String s2) { - if (s1 == s2) { - return true; - } - if (s1 != null) { - return s1.equals(s2); - } - return false; - } - public static Device findDevice(GBDevice gbDevice, DaoSession session) { DeviceDao deviceDao = session.getDeviceDao(); Query query = deviceDao.queryBuilder().where(DeviceDao.Properties.Identifier.eq(gbDevice.getAddress())).build();