From 9ed8004a697f66ba8f5e4c4f47ae6c6b8185e691 Mon Sep 17 00:00:00 2001 From: cpfeiffer Date: Sat, 22 Apr 2017 23:56:04 +0200 Subject: [PATCH] Fix rare NPE --- .../gadgetbridge/service/DeviceCommunicationService.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/DeviceCommunicationService.java b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/DeviceCommunicationService.java index 2437f50a..1ea9124d 100644 --- a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/DeviceCommunicationService.java +++ b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/DeviceCommunicationService.java @@ -207,14 +207,13 @@ public class DeviceCommunicationService extends Service implements SharedPrefere String action = intent.getAction(); if (action.equals(GBDevice.ACTION_DEVICE_CHANGED)) { GBDevice device = intent.getParcelableExtra(GBDevice.EXTRA_DEVICE); - // FIXME: mGBDevice was null here once - if (mGBDevice.equals(device)) { + if (mGBDevice != null && mGBDevice.equals(device)) { mGBDevice = device; boolean enableReceivers = mDeviceSupport != null && (mDeviceSupport.useAutoConnect() || mGBDevice.isInitialized()); setReceiversEnableState(enableReceivers, mGBDevice.isInitialized(), DeviceHelper.getInstance().getCoordinator(device)); GB.updateNotification(mGBDevice.getName() + " " + mGBDevice.getStateString(), mGBDevice.isInitialized(), context); } else { - LOG.error("Got ACTION_DEVICE_CHANGED from unexpected device: " + mGBDevice); + LOG.error("Got ACTION_DEVICE_CHANGED from unexpected device: " + device); } } }