From d0b9914770877f1869e29858680b385f59012e56 Mon Sep 17 00:00:00 2001
From: cpfeiffer <cpfeiffer@users.noreply.github.com>
Date: Tue, 9 Jun 2015 21:05:44 +0200
Subject: [PATCH] Keep the db open while adding samples

---
 .../gadgetbridge/miband/MiBandSupport.java    | 39 +++++++++++--------
 1 file changed, 22 insertions(+), 17 deletions(-)

diff --git a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/miband/MiBandSupport.java b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/miband/MiBandSupport.java
index 1b305a7b..13b559ba 100644
--- a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/miband/MiBandSupport.java
+++ b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/miband/MiBandSupport.java
@@ -3,6 +3,7 @@ package nodomain.freeyourgadget.gadgetbridge.miband;
 import android.bluetooth.BluetoothGatt;
 import android.bluetooth.BluetoothGattCharacteristic;
 import android.content.SharedPreferences;
+import android.database.sqlite.SQLiteDatabase;
 import android.net.Uri;
 import android.preference.PreferenceManager;
 
@@ -24,6 +25,7 @@ import nodomain.freeyourgadget.gadgetbridge.R;
 import nodomain.freeyourgadget.gadgetbridge.btle.AbstractBTLEDeviceSupport;
 import nodomain.freeyourgadget.gadgetbridge.btle.SetDeviceBusyAction;
 import nodomain.freeyourgadget.gadgetbridge.btle.TransactionBuilder;
+import nodomain.freeyourgadget.gadgetbridge.database.ActivityDatabaseHandler;
 
 import static nodomain.freeyourgadget.gadgetbridge.miband.MiBandConst.DEFAULT_VALUE_FLASH_COLOUR;
 import static nodomain.freeyourgadget.gadgetbridge.miband.MiBandConst.DEFAULT_VALUE_FLASH_COUNT;
@@ -519,25 +521,28 @@ public class MiBandSupport extends AbstractBTLEDeviceSupport {
         GregorianCalendar timestamp = this.activityDataTimestampProgress;
         byte category, intensity, steps;
 
-        for (int i=0; i<this.activityDataHolderProgress; i+=3) { //TODO: check if multiple of 3, if not something is wrong
-            category = this.activityDataHolder[i];
-            intensity = this.activityDataHolder[i+1];
-            steps = this.activityDataHolder[i+2];
+        ActivityDatabaseHandler dbHandler = GBApplication.getActivityDatabaseHandler();
+        try (SQLiteDatabase db = dbHandler.getWritableDatabase()) { // explicitly keep the db open while looping over the samples
+            for (int i=0; i<this.activityDataHolderProgress; i+=3) { //TODO: check if multiple of 3, if not something is wrong
+                category = this.activityDataHolder[i];
+                intensity = this.activityDataHolder[i+1];
+                steps = this.activityDataHolder[i+2];
 
-            GBApplication.getActivityDatabaseHandler().addGBActivitySample(
-                    (int) (timestamp.getTimeInMillis() / 1000),
-                    GBActivitySample.PROVIDER_MIBAND,
-                    intensity,
-                    steps,
-                    category);
+                dbHandler.addGBActivitySample(
+                        (int) (timestamp.getTimeInMillis() / 1000),
+                        GBActivitySample.PROVIDER_MIBAND,
+                        intensity,
+                        steps,
+                        category);
 
-            ACTIVITYLOG.info(
-                    " timestamp:"+DateFormat.getDateTimeInstance().format(timestamp.getTime()).toString() +
-                            " category:"+ category+
-                            " intensity:"+intensity+
-                            " steps:"+steps
-            );
-            timestamp.add(Calendar.MINUTE, 1);
+                ACTIVITYLOG.info(
+                        " timestamp:"+DateFormat.getDateTimeInstance().format(timestamp.getTime()).toString() +
+                                " category:"+ category+
+                                " intensity:"+intensity+
+                                " steps:"+steps
+                );
+                timestamp.add(Calendar.MINUTE, 1);
+            }
         }
 
         this.activityDataHolderProgress = 0;