From d2f7169de4b153afad3692caa15cf1ef57253004 Mon Sep 17 00:00:00 2001
From: Andreas Shimokawa <shimokawa@fsfe.org>
Date: Sat, 13 Jun 2015 01:12:08 +0200
Subject: [PATCH] Really, I see no reason to look up a string for a preference
 key in an xml file

If we have to use a key to lookup the string for the key, we can just use that key as the preference key.
---
 .../nodomain/freeyourgadget/gadgetbridge/GBApplication.java     | 2 +-
 app/src/main/res/values/strings.xml                             | 1 -
 app/src/main/res/xml/preferences.xml                            | 2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/GBApplication.java b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/GBApplication.java
index e4b1594b..0f42713e 100644
--- a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/GBApplication.java
+++ b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/GBApplication.java
@@ -41,7 +41,7 @@ public class GBApplication extends Application {
 
     public static boolean isFileLoggingEnabled() {
         SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(GBApplication.getContext());
-        return prefs.getBoolean(GBApplication.getContext().getString(R.string.pref_log_to_file), false);
+        return prefs.getBoolean("log_to_file", false);
     }
 
     private void setupLogging() {
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 37e33edc..e9f52eae 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -102,7 +102,6 @@
     <string name="pref_header_vibration_count">Vibration Count</string>
 
     <string name="title_activity_sleepmonitor">Sleep Monitor</string>
-    <string name="pref_log_to_file">LogToFile</string>
     <string name="pref_write_logfiles">Write Log Files (needs restart)</string>
     <string name="initializing">initializing</string>
     <string name="busy_task_fetch_activity_data">Fetching Activity Data</string>
diff --git a/app/src/main/res/xml/preferences.xml b/app/src/main/res/xml/preferences.xml
index 1bbd3703..274e8744 100644
--- a/app/src/main/res/xml/preferences.xml
+++ b/app/src/main/res/xml/preferences.xml
@@ -66,7 +66,7 @@
         android:title="@string/pref_header_development">
         <CheckBoxPreference
             android:defaultValue="false"
-            android:key="@string/pref_log_to_file"
+            android:key="log_to_file"
             android:title="@string/pref_write_logfiles" />
     </PreferenceCategory>
 </PreferenceScreen>