From e34c5614d74ec1f0362ab7fa0f8d2951a6281ccf Mon Sep 17 00:00:00 2001 From: cpfeiffer Date: Wed, 9 Sep 2015 20:46:50 +0200 Subject: [PATCH] Bail out hard if we get negative steps from the database #91 We don't add them to the db for sure. --- .../gadgetbridge/impl/GBActivitySample.java | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/impl/GBActivitySample.java b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/impl/GBActivitySample.java index 861dc8a1..1cb7416d 100644 --- a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/impl/GBActivitySample.java +++ b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/impl/GBActivitySample.java @@ -16,6 +16,19 @@ public class GBActivitySample implements ActivitySample { this.intensity = intensity; this.steps = steps; this.type = type; + validate(); + } + + private void validate() { + if (steps < 0) { + throw new IllegalArgumentException("steps must be > 0"); + } + if (intensity < 0) { + throw new IllegalArgumentException("intensity must be > 0"); + } + if (timestamp < 0) { + throw new IllegalArgumentException("timestamp must be > 0"); + } } @Override