From 8b1748e985e8000dc8ede4279149d48be4b2dc68 Mon Sep 17 00:00:00 2001 From: Pierre Neidhardt Date: Thu, 15 Feb 2018 15:55:30 +0100 Subject: [PATCH] Emacs: Update TODOs and comments --- .emacs.d/lisp/init-eshell.el | 14 ++++---------- .emacs.d/lisp/init-evil.el | 1 + .emacs.d/lisp/init-exwm.el | 3 ++- .emacs.d/lisp/init-helm.el | 3 --- .emacs.d/lisp/init-mu4e.el | 4 +--- .emacs.d/lisp/main.el | 4 ++-- 6 files changed, 10 insertions(+), 19 deletions(-) diff --git a/.emacs.d/lisp/init-eshell.el b/.emacs.d/lisp/init-eshell.el index ce8262be..6d87fbb2 100644 --- a/.emacs.d/lisp/init-eshell.el +++ b/.emacs.d/lisp/init-eshell.el @@ -17,7 +17,8 @@ ;;; Fixed in #27407. (require 'patch-eshell) -;;; TODO: Sometimes transmission-daemon does not start from Eshell. +;;; REVIEW: Sometimes transmission-daemon does not start from Eshell. +;;; See #30465. ;;; REVIEW: Redirecting big output to file (e.g. /dev/null) is extremely slow. ;; > cat /usr/share/dict/british-english | wc -l @@ -164,11 +165,6 @@ ;;; `eshell/alias' is too slow as it reads and write the file on each definition. ;;; Let's write manually instead. (with-eval-after-load 'em-alias - ;;; TODO: This conflicts with `evil-define-key' during the initialization of - ;;; the first eshell session: the map in insert-mode will not take the changes - ;;; into account. Going to normal mode and back to insert mode works. - ;;; Note: Evil has fixed some issues in the meantime. Also test with `evil-define-key*'. - ;;; ;;; If we read the alias list here, it means we make commandline-defined aliases persistent. ;; (eshell-read-aliases-list) (dolist @@ -177,10 +173,8 @@ ("la" "ls -lAh $*") ("ll" "ls -lh $*") ;; TODO: Aliasing eshell/{cp,mv,ln} does not work. - ;; TODO: "sudo" does not work on aliases. - ;; See bug #27168. ;; REVIEW: Eshell/TRAMP's sudo does not work with aliases. - ;; See #28320. + ;; See #28320, #27168. ;; ("ls" "ls -F $*") ; not supported ;; ("emacs" "find-file $1") ;; ("cp" "eshell/cp -iv $*") @@ -189,7 +183,7 @@ ("mvv" "mv -iv $*") ("rmv" "rm -v $*") ("md" "eshell/mkdir -p $*") - ("mkcd" "eshell/mkdir -p $* ; cd $1"))) ; TODO: Does not work because mkdir exits with nil? + ("mkcd" "eshell/mkdir -p $* ; cd $1"))) ; TODO: '&&' does not work because mkdir exits with nil? (add-to-list 'eshell-command-aliases-list alias)) (eshell-write-aliases-list)) diff --git a/.emacs.d/lisp/init-evil.el b/.emacs.d/lisp/init-evil.el index b3ded531..0ff46b81 100644 --- a/.emacs.d/lisp/init-evil.el +++ b/.emacs.d/lisp/init-evil.el @@ -88,6 +88,7 @@ ;;; Add defun text-object. TODO: Does not work for "around". ;;; https://github.com/emacs-evil/evil/issues/874 +;;; See Evil-cleverparens? (evil-define-text-object evil-a-defun (count &optional beg end type) "Select a defun." (evil-select-an-object 'evil-defun beg end type count)) diff --git a/.emacs.d/lisp/init-exwm.el b/.emacs.d/lisp/init-exwm.el index 0eae77d5..889a8bcb 100644 --- a/.emacs.d/lisp/init-exwm.el +++ b/.emacs.d/lisp/init-exwm.el @@ -12,8 +12,9 @@ ;;; See https://github.com/ch11ng/exwm/issues/285 ;;; and https://gitlab.com/interception/linux/plugins/caps2esc/issues/2. -;;; TODO: Pressing "s-a" ('emms-smart-browse) loses the cursor. +;;; REVIEW: Pressing "s-a" ('emms-smart-browse) loses the cursor. ;;; Sometimes waiting helps. Calling emms-smart-browse manually does not trigger the issue. +;;; https://github.com/ch11ng/exwm/issues/366 ;;; REVIEW: helm-mini with follow-mode hangs when using EXWM. ;;; https://github.com/emacs-helm/helm/issues/1889 diff --git a/.emacs.d/lisp/init-helm.el b/.emacs.d/lisp/init-helm.el index 53b20de7..8d6fdb46 100644 --- a/.emacs.d/lisp/init-helm.el +++ b/.emacs.d/lisp/init-helm.el @@ -16,9 +16,6 @@ ;;; TODO: Implement alternating-color multiline lists. ;;; See https://github.com/emacs-helm/helm/issues/1790. -;;; TODO: Impement helm-portage (currently helm-gentoo). -;;; TODO: Implement helm-pacman. - (when (require 'linum-relative nil t) (helm-linum-relative-mode 1)) diff --git a/.emacs.d/lisp/init-mu4e.el b/.emacs.d/lisp/init-mu4e.el index 6d66948a..cb415a7c 100644 --- a/.emacs.d/lisp/init-mu4e.el +++ b/.emacs.d/lisp/init-mu4e.el @@ -3,15 +3,13 @@ ;;; REVIEW: Reply to all by default. ;;; https://github.com/djcb/mu/issues/1135 ;;; TODO: Is it possible to mbsync without attachments? -;;; REVIEW: Use abbrevs in compose mode. -;;; Fixed upstream. See https://github.com/djcb/mu/issues/1119. ;;; REVIEW: Do not cite when replying: https://github.com/djcb/mu/issues/1110. ;;; TODO: Face of `message-cited-text' does not work. ;;; REVIEW: Handle attachments in attached e-mails. ;;; See https://github.com/djcb/mu/issues/454#issuecomment-320616279. ;;; TODO: should go to next link in text e-mails too. -;; Emacs pinentry for GPG. +;; We need 'main' to setup pinentry-emacs for GPG. (require 'main) (when (require 'mu4e-maildirs-extension nil t) diff --git a/.emacs.d/lisp/main.el b/.emacs.d/lisp/main.el index 8b1d65f1..328ee562 100644 --- a/.emacs.d/lisp/main.el +++ b/.emacs.d/lisp/main.el @@ -163,9 +163,9 @@ (require 'browse-url) (setq browse-url-browser-function (if (executable-find "xdg-open") 'browse-url-xdg-open 'browse-url-generic)) -;;; If xdg-open is not found, set Emacs URL browser to the environment browser, +;;; REVIEW: If xdg-open is not found, set Emacs URL browser to the environment browser, ;;; or w3m if BROWSER is not set. -;; REVIEW: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=18986 +;;; See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=18986. (setq browse-url-generic-program (or (executable-find (or (getenv "BROWSER") "")) (when (executable-find "xdg-mime")