Commit Graph

334 Commits (21380d9a394774c19075c00ef04a466456d57ed2)

Author SHA1 Message Date
Michael Stapelberg 09e74c4fd1 debian: update packaging to use dpkg-buildflags, i3lock.manpages 2011-11-06 14:21:08 +00:00
Michael Stapelberg 47db98efd2 Makefile: add 'dist' target 2011-11-06 14:20:40 +00:00
Michael Stapelberg 8e3c506c90 Properly implement -h (fixes error message about unknown option) 2011-11-06 14:11:20 +00:00
Michael Stapelberg 409025c7cc Get rid of superfluous \n in --version 2011-11-06 14:08:33 +00:00
Michael Stapelberg 00f1350bd5 update debian/changelog 2011-11-06 14:02:42 +00:00
Michael Stapelberg 28fe00c765 Bugfix: Properly detect the release of ISO_Level3_Shift (Thanks bacardi55) 2011-10-30 13:22:50 +00:00
Michael Stapelberg 9f6ef91337 Introduce --debug and some debugging options related to the Mode_switch / ISO_Level3_Shift thing 2011-10-29 23:28:11 +01:00
Michael Stapelberg 8e153411b5 Correctly handle Mode_switch/ISO_Level3_Shift (Thanks bacardi55)
I tested this with the following experiment:
$ setxkbmap 'us(intl)'
$ xmodmap ~/configfiles/midna/Xmodmap
$ xmodmap -e 'keycode 38 = a A adiaeresis Adiaeresis o O'
$ xmodmap -e 'keycode 49 = ISO_Level3_Shift ISO_Level3_Shift ISO_Level3_Shift ISO_Level3_Shift'
Then, Mode_switch + a yields ä, but ` + a yields o.

In i3lock, these were swapped (Mode_switch + a yielded o, while ä was not
reachable at all). The comment in the code explains it

(See http://code.stapelberg.de/git/configfiles for the Xmodmap)
2011-10-29 23:23:41 +01:00
Michael Stapelberg a803ba931e Bugfix: Don’t re-grab pointer/keyboard on MappingNotify (Thanks wilmer)
This fixes bug http://bugs.i3wm.org/545, where characters (of your password)
would rarely slip through when entering your password (especially) after
resuming your notebook from suspend to RAM.

The reason is that when resuming, X triggers one or more MappingNotify events.
At the same time, CPU load is high. This leads to a race-condition between the
ungrab and re-grab in which i3lock temporarily does not grab the keyboard.

One way to fix this is using xcb_grab_server() before and xcb_ungrab_server()
after the ungrab/re-grab. However, I think we actually don’t need to
ungrab/re-grab at all. I seem to have put that code in here by mistake – in i3,
we re-grab after MappingNotify, but there we only grab specific keys. In
i3lock, we grab the whole pointer/keyboard, so there should be no need.

If I’m incorrect and this breaks some subtle use-cases for people with strange
layout setup, at least we can properly document on why we need it, after we put
it back in ;).
2011-10-24 21:23:33 +01:00
Michael Stapelberg 493b02aa04 manpage: mention arguments in OPTIONS section, too (Thanks TrickSTer) 2011-09-25 13:34:26 +01:00
Michael Stapelberg 5932ee24a7 Throw an error when specifying an invalid pointer argument (-p) (Thanks TrickSTer) 2011-09-25 13:26:51 +01:00
Thorsten Töpper c81f8e8284 Fixed handle_screen_resize to build with NOLIBCAIRO enabled 2011-08-24 01:26:45 +02:00
Stefan Breunig c8eecefe83 handle screen resolution images and redraw the lock window 2011-08-17 15:46:52 +02:00
Michael Stapelberg 1e7349e739 update debian packaging, update copyright 2011-07-13 17:06:46 +02:00
Michael Stapelberg 4b9a1c94ab makefile: respect and use CPPFLAGS / LIBS (Thanks Kacper) 2011-07-13 16:56:27 +02:00
Michael Stapelberg e03e93fd1b optimization: render to pixmap which is used as background for the window
Before this commit, the background color (white by default) was visible for
about 100ms until the image was drawn. This flickering is now eliminated.

Also, we don’t need to handle Expose-events anymore, as X11 will use the
window’s background pixmap automatically.
2011-04-02 19:49:38 +02:00
Michael Stapelberg e7201e2df5 Mark handle_visibility_notify and handle_mapping_notify as static 2011-04-02 19:32:59 +02:00
Michael Stapelberg ea9088ae96 update debian packaging 2011-03-13 20:38:32 +01:00
Michael Stapelberg 6b0ce0d5aa cleanup indention left-overs 2011-03-13 20:24:25 +01:00
Michael Stapelberg 7128f80020 bump copyright 2011-03-13 20:23:39 +01:00
Michael Stapelberg c14cb4a250 Handle MappingNotify-events (Thanks Pascal) 2011-03-13 19:31:08 +01:00
Michael Stapelberg a93f110584 use 'auth include login' instead of '@include login', the latter is debian-specific (Thanks mseed) 2011-01-23 00:11:51 +01:00
Michael Stapelberg fc6b72eaec add i3lock.pam (installed as /etc/pam.d/i3lock) which includes 'login' (Thanks Семён) 2011-01-20 10:36:03 +01:00
Michael Stapelberg 53987df490 Bugfix: correctly check for errors when connecting to X11 2011-01-15 14:47:06 +01:00
Michael Stapelberg 7ba6f07322 add XK_KP_Enter as synonym for XK_Return 2010-11-09 19:35:16 +01:00
Michael Stapelberg f891929d34 Bugfix: Handle numpad keys correctly (Thanks Pascal) 2010-11-08 14:43:07 +01:00
Michael Stapelberg 3a22727bff Bugfix: When entering 512 characters, you could use neither return nor backspace (Thanks carl) 2010-11-06 18:02:44 +01:00
Michael Stapelberg c3affb1c61 Add a hint to the error message 'unknown option' when compiled with NOLIBCAIRO 2010-10-06 23:39:18 +02:00
Thorsten Töpper c643bb8e2f Make it possible to build i3lock without cairo. 2010-10-06 23:37:31 +02:00
Michael Stapelberg bdf6c6b45d comment out debug output (Thanks Ciprian) 2010-09-09 15:39:27 +02:00
Michael Stapelberg bf31c90a5f debian: change priority to optional 2010-09-05 18:19:25 +02:00
Michael Stapelberg a850b52953 update debian packaging for i3lock 2.0 release 2010-09-05 14:00:27 +02:00
Michael Stapelberg efde6a170d print version number when invoked with -v 2010-07-23 23:13:41 +02:00
Michael Stapelberg 5d43c20538 manpage: add missing "specify" (Thanks xeen) 2010-07-21 01:46:59 +02:00
Michael Stapelberg ab7f591db6 s/passwords/password (Thanks xeen) 2010-07-21 01:45:11 +02:00
Michael Stapelberg 3f168a54ce Re-implement tiling of image (-t) 2010-07-20 23:44:58 +02:00
Michael Stapelberg c1a34e7aa5 Fix compilation warning by including cairo-xcb 2010-07-20 23:09:09 +02:00
Michael Stapelberg f6af085784 Move static byte arrays to xcb.c (fixes compilation warnings) 2010-07-20 23:06:54 +02:00
Axel Wagner 0c4b4df75e Port the pointer-code to xcb 2010-07-20 22:56:47 +02:00
Michael Stapelberg 89434b4a88 disable debug output which reveals the password
(full debug output will be disabled for the next release)
2010-07-20 21:18:53 +02:00
Michael Stapelberg 7f42665245 grabbing: make the retry loop much slower (waits up to half a second)
This should fix a race condition where the Mod-key was not released
in time when starting i3lock using a key combination.
2010-07-20 21:07:39 +02:00
Michael Stapelberg c24922f0f2 Bugfix: Correctly error out when unable to grab pointer/keyboard 2010-07-20 20:52:58 +02:00
Michael Stapelberg 4e5c203cd9 Raise the i3lock window upon visibility notifies 2010-07-20 20:30:44 +02:00
Michael Stapelberg 9d19a8bb53 make event loop simpler (Thanks to Jamey Sharp)
As explained in Jamey’s post on the XCB mailing list, the event
loop can/should be written in a more simple way than it was before
in xcb-event. See:
<AANLkTinhIM320wUjSeHkBTVk4ysBuiSZkvfs8pMLVykO@mail.gmail.com>
or
http://lists.freedesktop.org/archives/xcb/2010-July/006292.html
2010-07-20 20:13:40 +02:00
Michael Stapelberg 6a52ba8bea err, xcb_image is not actually used 2010-07-17 01:08:30 +02:00
Michael Stapelberg 0777390a65 s/arry/array 2010-07-16 20:59:09 +02:00
Michael Stapelberg 60776a8219 manpage: PNG instead of XPM 2010-07-16 20:55:20 +02:00
Michael Stapelberg a1400462c2 manpage: s/tile/tiling 2010-07-16 20:36:11 +02:00
Michael Stapelberg f1b78b46ec debian: add missing libxcb-image0-dev 2010-07-16 18:27:04 +02:00
Michael Stapelberg ac29391048 debian: update packaging 2010-07-16 18:22:33 +02:00