Commit Graph

11 Commits (3216c40504b7c65f5877ef798b5ea41db28f2ab6)

Author SHA1 Message Date
Michael Stapelberg 467e46c077 avoid pixmap allocations in the redraw path
Before this change, i3lock could become unusable on systems where pixmap
allocations take long.

I don’t know precisely why, but slow pixmap allocations is a symptom that my
computer sometimes exhibits, apparently when low on GPU memory.

In that situation, duplicate key press events would be processed (apparently
received from X11!), making correct password entry impossible.
2020-07-05 09:23:39 +02:00
Michael Stapelberg 6b53758e14
display error when backspace is pressed without any input (#172)
This adds some feedback to a keypress which previously had no visible effect.

While the text “no input” isn’t the most descriptive, it was the only one I
could think of which fit into the unlock indicator circle. If you have a better
suggestion, let me know.

fixes #164
2018-01-14 22:17:43 +01:00
Jasper Lievisse Adriaanse 68fc2e8b5f Use bsd_auth(3) instead of PAM on OpenBSD
Also apply two security measures for OpenBSD:
- use explicit_bzero(3)
- mlock(2) works for non-root users too
2017-04-17 15:06:59 +02:00
Jasper Lievisse Adriaanse c1de117825 Rename all PAM-independant variables/comments.
there is nothing PAM-specific about pam_state or pam_state_t. therefore
rename them to be authenticator independant.
2017-04-15 09:44:09 +02:00
eplanet d2130092cf Display error message when locking failed (#99)
To give a feedback for when the pointer couldn't be grabbed,
displaying an error message before exiting.
2016-10-11 13:40:51 -07:00
eplanet 1c97a84847 Displaying locking message when grabbing the pointer/keyboard. (#88)
Display "locking…" message when grabbing the pointer/keyboard,
after at least 250 ms of unfruitful attempts. If grabbing
eventually fails, application will not fork and return 1.
2016-09-27 18:39:52 -07:00
Michael Stapelberg 68b78a7f57 clang-format -i **/*.[ch]
From here on, we’ll use clang-format to automatically format the source.

This has worked well in i3, so we are introducing it for i3lock.
2015-03-16 18:47:16 +01:00
Vytautas Šaltenis 2509c987d1 Extract start/stop timer code to reusable funcs 2014-03-11 09:11:20 +01:00
Michael Stapelberg dc2b6e5f39 Use (void) instead of () for functions without args (Thanks fernandotcl)
See also:
http://article.gmane.org/gmane.linux.kernel/1268792

The C compiler will handle (void) as "no arguments" and () as "variadic
function" (equivalent to (...)) which might lead to subtle errors, such
as the one which was fixed with commit 0ea64ae4.
2012-04-01 12:28:28 +02:00
Michael Stapelberg 0e7e009f45 Properly free timeouts, move one of the timeouts to unlock_indicator.c 2012-01-03 22:18:33 +00:00
Michael Stapelberg 57585bef70 Refactor the unlock indicator into its own source code file 2012-01-03 20:56:05 +00:00