From e44eb03698675e3379ce3a6cdb34b28ce194f3b8 Mon Sep 17 00:00:00 2001 From: cpfeiffer Date: Mon, 4 Sep 2017 23:23:51 +0200 Subject: [PATCH] Amazfit Bip: avoid sending weather info when not initialized --- .../devices/amazfitbip/AmazfitBipSupport.java | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/amazfitbip/AmazfitBipSupport.java b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/amazfitbip/AmazfitBipSupport.java index 95d4288d..57fb1941 100644 --- a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/amazfitbip/AmazfitBipSupport.java +++ b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/amazfitbip/AmazfitBipSupport.java @@ -140,15 +140,18 @@ public class AmazfitBipSupport extends MiBand2Support { @Override public void onSendWeather(WeatherSpec weatherSpec) { + if (gbDevice.getFirmwareVersion() == null) { + LOG.warn("Device not initialized yet, so not sending weather info"); + return; + } + try { TransactionBuilder builder = performInitialized("Sending weather forecast"); boolean supportsConditionString = false; - if (gbDevice.getFirmwareVersion() != null) { - Version version = new Version(gbDevice.getFirmwareVersion()); - if (version.compareTo(new Version("0.0.8.74")) >= 0) { - supportsConditionString = true; - } + Version version = new Version(gbDevice.getFirmwareVersion()); + if (version.compareTo(new Version("0.0.8.74")) >= 0) { + supportsConditionString = true; } final byte NR_DAYS = 2;