From f4cb7989772f8425306ad168f278943251121fdd Mon Sep 17 00:00:00 2001 From: cpfeiffer Date: Thu, 6 Aug 2015 22:24:44 +0200 Subject: [PATCH] Extract a method for easier reuse if necessary --- .../externalevents/NotificationListener.java | 22 ++++++++++--------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/externalevents/NotificationListener.java b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/externalevents/NotificationListener.java index 6c8e72da..4865f027 100644 --- a/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/externalevents/NotificationListener.java +++ b/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/externalevents/NotificationListener.java @@ -57,17 +57,9 @@ public class NotificationListener extends NotificationListenerService { * else the service would get started every time we get a notification. * unfortunately we cannot enable/disable NotificationListener at runtime like we do with * broadcast receivers because it seems to invalidate the permissions that are - * neccessery for NotificationListenerService + * necessary for NotificationListenerService */ - boolean isServiceRunning = false; - ActivityManager manager = (ActivityManager) getSystemService(ACTIVITY_SERVICE); - for (ActivityManager.RunningServiceInfo service : manager.getRunningServices(Integer.MAX_VALUE)) { - if (DeviceCommunicationService.class.getName().equals(service.service.getClassName())) { - isServiceRunning = true; - } - } - - if (!isServiceRunning) { + if (!isServiceRunning()) { return; } @@ -128,6 +120,16 @@ public class NotificationListener extends NotificationListenerService { } + private boolean isServiceRunning() { + ActivityManager manager = (ActivityManager) getSystemService(ACTIVITY_SERVICE); + for (ActivityManager.RunningServiceInfo service : manager.getRunningServices(Integer.MAX_VALUE)) { + if (DeviceCommunicationService.class.getName().equals(service.service.getClassName())) { + return true; + } + } + return false; + } + @Override public void onNotificationRemoved(StatusBarNotification sbn) {