nixo
/
gri3-wm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
gri3-wm/testcases/t/156-fullscreen-focus.t

419 lines
13 KiB
Perl
Raw Normal View History

When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
#!perl
# vim:ts=4:sw=4:expandtab
#
add boilerplate to all testcases with documentation references
2012-09-10 14:09:01 +02:00
# Please read the following documents before working on tests:
tests: replace http:// with https:// where appropriate This was done automatically using: % sed -i 's,http://build.i3wm.org,https://build.i3wm.org,g' testcases/t/*.t
2017-09-24 10:19:50 +02:00
# • https://build.i3wm.org/docs/testsuite.html
add boilerplate to all testcases with documentation references
2012-09-10 14:09:01 +02:00
# (or docs/testsuite)
#
tests: replace http:// with https:// where appropriate This was done automatically using: % sed -i 's,http://build.i3wm.org,https://build.i3wm.org,g' testcases/t/*.t
2017-09-24 10:19:50 +02:00
# • https://build.i3wm.org/docs/lib-i3test.html
add boilerplate to all testcases with documentation references
2012-09-10 14:09:01 +02:00
# (alternatively: perldoc ./testcases/lib/i3test.pm)
#
tests: replace http:// with https:// where appropriate This was done automatically using: % sed -i 's,http://build.i3wm.org,https://build.i3wm.org,g' testcases/t/*.t
2017-09-24 10:19:50 +02:00
# • https://build.i3wm.org/docs/ipc.html
add boilerplate to all testcases with documentation references
2012-09-10 14:09:01 +02:00
# (or docs/ipc)
#
# • http://onyxneon.com/books/modern_perl/modern_perl_a4.pdf
# (unless you are already familiar with Perl)
#
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
# Test if new containers get focused when there is a fullscreen container at
Allow focus w/ target when in fs in some cases. If the target is in a different workspace, there's no reason why we wouldn't allow the user to focus it. We already allow this when focusing a workspace, for example.
2012-04-21 21:34:25 +02:00
# the time of launching the new one. Also make sure that focusing containers
# in other workspaces work even when there is a fullscreen container.
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
#
tests: use i3_config arg instead of precisely one launch_with_config This way, tests are shorter, and i3test’s invocation of launch_with_config parallelizes work better, using dont_block => 1.
2017-09-14 12:30:42 +02:00
use i3test i3_config => <<EOT;
Fix fullscreen focus bug and corresponding test flaw As the workspace might be reached via recursion (e.g. moving from the edge of a fullscreen split container), it's necessary to check for a fullscreen container whenever a workspace is reached.
2012-10-06 22:41:04 +02:00
# i3 config file (v4)
font -misc-fixed-medium-r-normal--13-120-75-75-C-70-iso10646-1
fake-outputs 1024x768+0+0,1024x768+1024+0
EOT
tests: use i3_config arg instead of precisely one launch_with_config This way, tests are shorter, and i3test’s invocation of launch_with_config parallelizes work better, using dont_block => 1.
2017-09-14 12:30:42 +02:00
# Screen setup looks like this:
# +----+----+
# | S1 | S2 |
# +----+----+
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
tests: clean up/beautify all tests (code style / test style)
2011-03-09 20:25:17 +01:00
my $tmp = fresh_workspace;
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
################################################################################
# Open the left window.
################################################################################
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
testcases: drop open_window()s $x parameter, use global one instead
2011-11-22 00:47:32 +01:00
my $left = open_window({ background_color => '#ff0000' });
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
is($x->input_focus, $left->id, 'left window focused');
diag("left = " . $left->id);
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
################################################################################
# Open the right window.
################################################################################
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
testcases: drop open_window()s $x parameter, use global one instead
2011-11-22 00:47:32 +01:00
my $right = open_window({ background_color => '#00ff00' });
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
diag("right = " . $right->id);
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
################################################################################
# Set the right window to fullscreen.
################################################################################
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
cmd 'nop setting fullscreen';
cmd 'fullscreen';
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
################################################################################
# Open a third window. Since we're fullscreen, the window won't be # mapped, so
# don't wait for it to be mapped. Instead, just send the map request and sync
# with i3 to make sure i3 recognizes it.
################################################################################
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
testcases: drop open_window()s $x parameter, use global one instead
2011-11-22 00:47:32 +01:00
my $third = open_window({
tests: lib/i3test: Remove open_standard_window, introduce open_window open_window has a better API than open_standard_window. It uses named parameters and supplies default values for everything you don’t specify. This way, you can use every feature which X11::XCB::Window supports.
2011-09-24 16:11:37 +02:00
background_color => '#0000ff',
name => 'Third window',
dont_map => 1,
});
tests: use wait_for_{map,unmap} to eliminate more sleep()s
2011-09-24 14:08:02 +02:00
$third->map;
testcases: drop sync_with_i3()s $x parameter, use global
2011-11-22 01:13:37 +01:00
sync_with_i3;
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
diag("third = " . $third->id);
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
################################################################################
# Move the window to a different workspace, and verify that the third window now
# gets focused in the current workspace.
################################################################################
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
my $tmp2 = get_unused_workspace;
cmd "move workspace $tmp2";
is($x->input_focus, $third->id, 'third window focused');
Bugfix: Don’t lose focus on fullscreen windows when another window gets moved to that workspace (+test) (Thanks rami) Fixes: #606
2012-01-07 19:18:36 +01:00
################################################################################
# Ensure that moving a window to a workspace which has a fullscreen window does
# not focus it (otherwise the user cannot get out of fullscreen mode anymore).
################################################################################
$tmp = fresh_workspace;
my $fullscreen_window = open_window;
cmd 'fullscreen';
my $nodes = get_ws_content($tmp);
is(scalar @$nodes, 1, 'precisely one window');
is($nodes->[0]->{focused}, 1, 'fullscreen window focused');
my $old_id = $nodes->[0]->{id};
$tmp2 = fresh_workspace;
my $move_window = open_window;
cmd "move workspace $tmp";
cmd "workspace $tmp";
$nodes = get_ws_content($tmp);
is(scalar @$nodes, 2, 'precisely two windows');
is($nodes->[0]->{id}, $old_id, 'id unchanged');
is($nodes->[0]->{focused}, 1, 'fullscreen window focused');
Allow focus w/ target when in fs in some cases. If the target is in a different workspace, there's no reason why we wouldn't allow the user to focus it. We already allow this when focusing a workspace, for example.
2012-04-21 21:34:25 +02:00
################################################################################
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
# Ensure it's possible to change focus if it doesn't escape the fullscreen
# container with fullscreen global. We can't even focus a container in a
# different workspace.
Allow focus w/ target when in fs in some cases. If the target is in a different workspace, there's no reason why we wouldn't allow the user to focus it. We already allow this when focusing a workspace, for example.
2012-04-21 21:34:25 +02:00
################################################################################
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
cmd 'fullscreen';
Allow focus w/ target when in fs in some cases. If the target is in a different workspace, there's no reason why we wouldn't allow the user to focus it. We already allow this when focusing a workspace, for example.
2012-04-21 21:34:25 +02:00
Allow 'focus $dir' to move out of non-global fullscreen containers
2012-10-08 18:28:08 +02:00
# Focus screen 1
tests: sync_with_i3 before warping pointer To be honest, I’m not entirely sure where the race condition originates from, but when making sure that there are no pending events (which is what sync_with_i3 accomplishes) before warping the pointer, we have less flaky testsuite runs. closes #1189
2014-02-25 20:44:17 +01:00
sync_with_i3;
Allow 'focus $dir' to move out of non-global fullscreen containers
2012-10-08 18:28:08 +02:00
$x->root->warp_pointer(1025, 0);
sync_with_i3;
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
$tmp = fresh_workspace;
Allow focus w/ target when in fs in some cases. If the target is in a different workspace, there's no reason why we wouldn't allow the user to focus it. We already allow this when focusing a workspace, for example.
2012-04-21 21:34:25 +02:00
cmd "workspace $tmp";
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
my $diff_ws = open_window;
Allow focus w/ target when in fs in some cases. If the target is in a different workspace, there's no reason why we wouldn't allow the user to focus it. We already allow this when focusing a workspace, for example.
2012-04-21 21:34:25 +02:00
Allow 'focus $dir' to move out of non-global fullscreen containers
2012-10-08 18:28:08 +02:00
# Focus screen 0
tests: sync_with_i3 before warping pointer To be honest, I’m not entirely sure where the race condition originates from, but when making sure that there are no pending events (which is what sync_with_i3 accomplishes) before warping the pointer, we have less flaky testsuite runs. closes #1189
2014-02-25 20:44:17 +01:00
sync_with_i3;
Allow 'focus $dir' to move out of non-global fullscreen containers
2012-10-08 18:28:08 +02:00
$x->root->warp_pointer(0, 0);
sync_with_i3;
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
$tmp2 = fresh_workspace;
cmd "workspace $tmp2";
cmd 'split h';
Allow focus w/ target when in fs in some cases. If the target is in a different workspace, there's no reason why we wouldn't allow the user to focus it. We already allow this when focusing a workspace, for example.
2012-04-21 21:34:25 +02:00
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
$left = open_window;
my $right1 = open_window;
cmd 'split v';
my $right2 = open_window;
cmd 'focus parent';
cmd 'fullscreen global';
cmd '[id="' . $right1->id . '"] focus';
is($x->input_focus, $right1->id, 'upper right window focused');
cmd '[id="' . $right2->id . '"] focus';
is($x->input_focus, $right2->id, 'bottom right window focused');
Allow focus child/parent when in fullscreen. This is now restricted according to the already defined fullscreen focus constraints. Test case 157 was removed, as we don't prevent level up/down in fullscreen anymore. Those commands are properly tested in fullscreen by test case 156. Fixes: #612
2012-05-26 23:36:25 +02:00
cmd 'focus parent';
isnt($x->input_focus, $right2->id, 'bottom right window no longer focused');
cmd 'focus child';
is($x->input_focus, $right2->id, 'bottom right window focused again');
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
cmd 'focus up';
is($x->input_focus, $right1->id, 'allowed focus up');
cmd 'focus down';
is($x->input_focus, $right2->id, 'allowed focus down');
cmd 'focus left';
is($x->input_focus, $right2->id, 'prevented focus left');
cmd 'focus right';
is($x->input_focus, $right2->id, 'prevented focus right');
cmd 'focus down';
is($x->input_focus, $right1->id, 'allowed focus wrap (down)');
cmd 'focus up';
is($x->input_focus, $right2->id, 'allowed focus wrap (up)');
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
################################################################################
Allow focus child/parent when in fullscreen. This is now restricted according to the already defined fullscreen focus constraints. Test case 157 was removed, as we don't prevent level up/down in fullscreen anymore. Those commands are properly tested in fullscreen by test case 156. Fixes: #612
2012-05-26 23:36:25 +02:00
# Same tests when we're in non-global fullscreen mode. It should now be possible
# to focus a container in a different workspace.
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
################################################################################
cmd 'focus parent';
Allow focus child/parent when in fullscreen. This is now restricted according to the already defined fullscreen focus constraints. Test case 157 was removed, as we don't prevent level up/down in fullscreen anymore. Those commands are properly tested in fullscreen by test case 156. Fixes: #612
2012-05-26 23:36:25 +02:00
cmd 'fullscreen global';
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
cmd 'fullscreen';
cmd '[id="' . $right1->id . '"] focus';
Allow focus child/parent when in fullscreen. This is now restricted according to the already defined fullscreen focus constraints. Test case 157 was removed, as we don't prevent level up/down in fullscreen anymore. Those commands are properly tested in fullscreen by test case 156. Fixes: #612
2012-05-26 23:36:25 +02:00
is($x->input_focus, $right1->id, 'upper right window focused');
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
cmd '[id="' . $right2->id . '"] focus';
is($x->input_focus, $right2->id, 'bottom right window focused');
Allow focus child/parent when in fullscreen. This is now restricted according to the already defined fullscreen focus constraints. Test case 157 was removed, as we don't prevent level up/down in fullscreen anymore. Those commands are properly tested in fullscreen by test case 156. Fixes: #612
2012-05-26 23:36:25 +02:00
cmd 'focus parent';
isnt($x->input_focus, $right2->id, 'bottom right window no longer focused');
cmd 'focus child';
is($x->input_focus, $right2->id, 'bottom right window focused again');
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
cmd 'focus up';
is($x->input_focus, $right1->id, 'allowed focus up');
cmd 'focus down';
is($x->input_focus, $right2->id, 'allowed focus down');
cmd 'focus down';
is($x->input_focus, $right1->id, 'allowed focus wrap (down)');
cmd 'focus up';
is($x->input_focus, $right2->id, 'allowed focus wrap (up)');
Allow 'focus $dir' to move out of non-global fullscreen containers
2012-10-08 18:28:08 +02:00
cmd 'focus left';
is($x->input_focus, $right2->id, 'focus left wrapped (no-op)');
cmd 'focus right';
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
is($x->input_focus, $diff_ws->id, 'allowed focus change to different ws');
Allow focus w/ target when in fs in some cases. If the target is in a different workspace, there's no reason why we wouldn't allow the user to focus it. We already allow this when focusing a workspace, for example.
2012-04-21 21:34:25 +02:00
Allow 'focus $dir' to move out of non-global fullscreen containers
2012-10-08 18:28:08 +02:00
cmd 'focus left';
is($x->input_focus, $right2->id, 'focused back into fullscreen container');
cmd '[id="' . $diff_ws->id . '"] focus';
is($x->input_focus, $diff_ws->id, 'allowed focus change to different ws by id');
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
################################################################################
# More testing of the interaction between wrapping and the fullscreen focus
# restrictions.
################################################################################
cmd '[id="' . $right1->id . '"] focus';
is($x->input_focus, $right1->id, 'upper right window focused');
cmd 'focus parent';
cmd 'fullscreen';
cmd 'focus child';
cmd 'split v';
my $right12 = open_window;
cmd 'focus down';
is($x->input_focus, $right2->id, 'bottom right window focused');
cmd 'split v';
my $right22 = open_window;
cmd 'focus parent';
cmd 'fullscreen';
cmd 'focus child';
cmd 'focus down';
is($x->input_focus, $right2->id, 'focus did not leave parent container (1)');
cmd 'focus down';
is($x->input_focus, $right22->id, 'focus did not leave parent container (2)');
cmd 'focus up';
is($x->input_focus, $right2->id, 'focus did not leave parent container (3)');
cmd 'focus up';
is($x->input_focus, $right22->id, 'focus did not leave parent container (4)');
Prevent moving out of fullscreen containers.
2012-05-27 02:45:15 +02:00
################################################################################
# Ensure that moving in a direction doesn't violate the focus restrictions.
################################################################################
Restrict "move to workspace" commands in fullscreen.
2012-05-27 03:13:16 +02:00
sub verify_move {
my $num = shift;
Prevent moving out of fullscreen containers.
2012-05-27 02:45:15 +02:00
my $msg = shift;
my $nodes = get_ws_content($tmp2);
my $split = $nodes->[1];
my $fs = $split->{nodes}->[1];
Restrict "move to workspace" commands in fullscreen.
2012-05-27 03:13:16 +02:00
is(scalar @{$fs->{nodes}}, $num, $msg);
Prevent moving out of fullscreen containers.
2012-05-27 02:45:15 +02:00
}
cmd 'move left';
Restrict "move to workspace" commands in fullscreen.
2012-05-27 03:13:16 +02:00
verify_move(2, 'prevented move left');
Prevent moving out of fullscreen containers.
2012-05-27 02:45:15 +02:00
cmd 'move right';
Restrict "move to workspace" commands in fullscreen.
2012-05-27 03:13:16 +02:00
verify_move(2, 'prevented move right');
Prevent moving out of fullscreen containers.
2012-05-27 02:45:15 +02:00
cmd 'move down';
Restrict "move to workspace" commands in fullscreen.
2012-05-27 03:13:16 +02:00
verify_move(2, 'prevented move down');
Prevent moving out of fullscreen containers.
2012-05-27 02:45:15 +02:00
cmd 'move up';
cmd 'move up';
Restrict "move to workspace" commands in fullscreen.
2012-05-27 03:13:16 +02:00
verify_move(2, 'prevented move up');
################################################################################
# Moving to a different workspace is allowed with per-output fullscreen
# containers.
################################################################################
cmd "move to workspace $tmp";
verify_move(1, 'did not prevent move to workspace by name');
cmd "workspace $tmp";
cmd "move to workspace $tmp2";
cmd "workspace $tmp2";
cmd "move to workspace prev";
verify_move(1, 'did not prevent move to workspace by position');
################################################################################
# Ensure that is not allowed with global fullscreen containers.
################################################################################
cmd "workspace $tmp";
cmd "move to workspace $tmp2";
cmd "workspace $tmp2";
cmd 'focus parent';
cmd 'fullscreen';
cmd 'fullscreen global';
cmd 'focus child';
cmd "move to workspace $tmp";
verify_move(2, 'prevented move to workspace by name');
cmd "move to workspace prev";
verify_move(2, 'prevented move to workspace by position');
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
################################################################################
# Ensure it's possible to focus a window using the focus command despite
# fullscreen window blocking it. Fullscreen window should lose its fullscreen
# mode.
################################################################################
# first & second tiling, focus using id
kill_all_windows;
$tmp = fresh_workspace;
my $first = open_window;
my $second = open_window;
cmd 'fullscreen';
is($x->input_focus, $second->id, 'fullscreen window focused');
is_num_fullscreen($tmp, 1, '1 fullscreen window');
cmd '[id="'. $first->id .'"] focus';
sync_with_i3;
is($x->input_focus, $first->id, 'correctly focused using id');
is_num_fullscreen($tmp, 0, 'no fullscreen windows');
# first floating, second tiling, focus using 'focus floating'
kill_all_windows;
$tmp = fresh_workspace;
my $first = open_floating_window;
my $second = open_window;
cmd 'fullscreen';
is($x->input_focus, $second->id, 'fullscreen window focused');
is_num_fullscreen($tmp, 1, '1 fullscreen window');
cmd 'focus floating';
sync_with_i3;
is($x->input_focus, $first->id, 'correctly focused using focus floating');
is_num_fullscreen($tmp, 0, 'no fullscreen windows');
# first tiling, second floating, focus using 'focus tiling'
kill_all_windows;
$tmp = fresh_workspace;
my $first = open_window;
my $second = open_floating_window;
cmd 'fullscreen';
is($x->input_focus, $second->id, 'fullscreen window focused');
is_num_fullscreen($tmp, 1, '1 fullscreen window');
cmd 'focus tiling';
sync_with_i3;
Prevent moving out of fullscreen containers.
2012-05-27 02:45:15 +02:00
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
is($x->input_focus, $first->id, 'correctly focused using focus tiling');
is_num_fullscreen($tmp, 0, 'no fullscreen windows');
################################################################################
# When the fullscreen window is in an other workspace it should maintain its
# fullscreen mode since it's not blocking the window to be focused.
################################################################################
kill_all_windows;
$tmp = fresh_workspace;
my $first = open_window;
$tmp2 = fresh_workspace;
my $second = open_window;
cmd 'fullscreen';
is($x->input_focus, $second->id, 'fullscreen window focused');
is_num_fullscreen($tmp2, 1, '1 fullscreen window');
cmd '[id="'. $first->id .'"] focus';
sync_with_i3;
is($x->input_focus, $first->id, 'correctly focused using focus id');
is_num_fullscreen($tmp, 0, 'no fullscreen windows on first workspace');
is_num_fullscreen($tmp2, 1, 'still one fullscreen window on second workspace');
################################################################################
# But a global window in another workspace is blocking the window to be focused.
# Ensure that it loses its fullscreen mode.
################################################################################
kill_all_windows;
$tmp = fresh_workspace;
$first = open_window;
$tmp2 = fresh_workspace;
$second = open_window;
cmd 'fullscreen global';
is($x->input_focus, $second->id, 'global window focused');
is_num_fullscreen($tmp2, 1, '1 fullscreen window');
cmd '[id="'. $first->id .'"] focus';
sync_with_i3;
is($x->input_focus, $first->id, 'correctly focused using focus id');
is_num_fullscreen($tmp2, 0, 'no fullscreen windows');
# TODO: Tests for "move to output" and "move workspace to output".
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
done_testing;