nixo
/
gri3-wm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
gri3-wm/testcases/t/156-fullscreen-focus.t

395 lines
12 KiB
Perl
Raw Normal View History

When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
#!perl
# vim:ts=4:sw=4:expandtab
#
add boilerplate to all testcases with documentation references
2012-09-10 14:09:01 +02:00
# Please read the following documents before working on tests:
tests: replace http:// with https:// where appropriate This was done automatically using: % sed -i 's,http://build.i3wm.org,https://build.i3wm.org,g' testcases/t/*.t
2017-09-24 10:19:50 +02:00
# • https://build.i3wm.org/docs/testsuite.html
add boilerplate to all testcases with documentation references
2012-09-10 14:09:01 +02:00
# (or docs/testsuite)
#
tests: replace http:// with https:// where appropriate This was done automatically using: % sed -i 's,http://build.i3wm.org,https://build.i3wm.org,g' testcases/t/*.t
2017-09-24 10:19:50 +02:00
# • https://build.i3wm.org/docs/lib-i3test.html
add boilerplate to all testcases with documentation references
2012-09-10 14:09:01 +02:00
# (alternatively: perldoc ./testcases/lib/i3test.pm)
#
tests: replace http:// with https:// where appropriate This was done automatically using: % sed -i 's,http://build.i3wm.org,https://build.i3wm.org,g' testcases/t/*.t
2017-09-24 10:19:50 +02:00
# • https://build.i3wm.org/docs/ipc.html
add boilerplate to all testcases with documentation references
2012-09-10 14:09:01 +02:00
# (or docs/ipc)
#
# • http://onyxneon.com/books/modern_perl/modern_perl_a4.pdf
# (unless you are already familiar with Perl)
#
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
# Test if new containers get focused when there is a fullscreen container at
Allow focus w/ target when in fs in some cases. If the target is in a different workspace, there's no reason why we wouldn't allow the user to focus it. We already allow this when focusing a workspace, for example.
2012-04-21 21:34:25 +02:00
# the time of launching the new one. Also make sure that focusing containers
# in other workspaces work even when there is a fullscreen container.
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
#
tests: use i3_config arg instead of precisely one launch_with_config This way, tests are shorter, and i3test’s invocation of launch_with_config parallelizes work better, using dont_block => 1.
2017-09-14 12:30:42 +02:00
use i3test i3_config => <<EOT;
Fix fullscreen focus bug and corresponding test flaw As the workspace might be reached via recursion (e.g. moving from the edge of a fullscreen split container), it's necessary to check for a fullscreen container whenever a workspace is reached.
2012-10-06 22:41:04 +02:00
# i3 config file (v4)
font -misc-fixed-medium-r-normal--13-120-75-75-C-70-iso10646-1
fake-outputs 1024x768+0+0,1024x768+1024+0
EOT
tests: use i3_config arg instead of precisely one launch_with_config This way, tests are shorter, and i3test’s invocation of launch_with_config parallelizes work better, using dont_block => 1.
2017-09-14 12:30:42 +02:00
# Screen setup looks like this:
# +----+----+
# | S1 | S2 |
# +----+----+
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
sub verify_focus {
# Report original line
local $Test::Builder::Level = $Test::Builder::Level + 1;
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
my ($expected, $msg) = @_;
$expected = $expected->id;
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
# Ensure the expected focus if the test fails.
cmd "[id=$expected] focus" unless is($x->input_focus, $expected, $msg);
}
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
################################################################################
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
# Verify that window opened behind fullscreen window will get focus after the
# fullscreen window gets moved to a different workspace.
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
################################################################################
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
fresh_workspace;
my $left = open_window;
verify_focus($left, 'left window focused');
diag("left = " . $left->id);
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
my $right = open_window;
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
cmd 'fullscreen';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
diag("right = " . $right->id);
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
# Open a third window. Since we're fullscreen, the window won't be mapped, so
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
# don't wait for it to be mapped. Instead, just send the map request and sync
# with i3 to make sure i3 recognizes it.
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
my $third = open_window({dont_map => 1});
tests: use wait_for_{map,unmap} to eliminate more sleep()s
2011-09-24 14:08:02 +02:00
$third->map;
testcases: drop sync_with_i3()s $x parameter, use global
2011-11-22 01:13:37 +01:00
sync_with_i3;
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
diag("third = " . $third->id);
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
# Move the window to a different workspace, and verify that the third window now
# gets focused in the current workspace.
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
my $tmp2 = get_unused_workspace;
cmd "move workspace $tmp2";
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($third, 'third window focused');
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
kill_all_windows;
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
Bugfix: Don’t lose focus on fullscreen windows when another window gets moved to that workspace (+test) (Thanks rami) Fixes: #606
2012-01-07 19:18:36 +01:00
################################################################################
# Ensure that moving a window to a workspace which has a fullscreen window does
# not focus it (otherwise the user cannot get out of fullscreen mode anymore).
################################################################################
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
my $tmp = fresh_workspace;
Bugfix: Don’t lose focus on fullscreen windows when another window gets moved to that workspace (+test) (Thanks rami) Fixes: #606
2012-01-07 19:18:36 +01:00
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
open_window;
Bugfix: Don’t lose focus on fullscreen windows when another window gets moved to that workspace (+test) (Thanks rami) Fixes: #606
2012-01-07 19:18:36 +01:00
cmd 'fullscreen';
my $nodes = get_ws_content($tmp);
is(scalar @$nodes, 1, 'precisely one window');
is($nodes->[0]->{focused}, 1, 'fullscreen window focused');
my $old_id = $nodes->[0]->{id};
$tmp2 = fresh_workspace;
my $move_window = open_window;
cmd "move workspace $tmp";
cmd "workspace $tmp";
$nodes = get_ws_content($tmp);
is(scalar @$nodes, 2, 'precisely two windows');
is($nodes->[0]->{id}, $old_id, 'id unchanged');
is($nodes->[0]->{focused}, 1, 'fullscreen window focused');
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
kill_all_windows;
Allow focus w/ target when in fs in some cases. If the target is in a different workspace, there's no reason why we wouldn't allow the user to focus it. We already allow this when focusing a workspace, for example.
2012-04-21 21:34:25 +02:00
################################################################################
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
# Ensure it's possible to change focus if it doesn't escape the fullscreen
# container with fullscreen global. We can't even focus a container in a
# different workspace.
Allow focus w/ target when in fs in some cases. If the target is in a different workspace, there's no reason why we wouldn't allow the user to focus it. We already allow this when focusing a workspace, for example.
2012-04-21 21:34:25 +02:00
################################################################################
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
$tmp = fresh_workspace(output => 1);
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
my $diff_ws = open_window;
Allow focus w/ target when in fs in some cases. If the target is in a different workspace, there's no reason why we wouldn't allow the user to focus it. We already allow this when focusing a workspace, for example.
2012-04-21 21:34:25 +02:00
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
$tmp2 = fresh_workspace(output => 0);
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
$left = open_window;
my $right1 = open_window;
cmd 'split v';
my $right2 = open_window;
cmd 'focus parent';
cmd 'fullscreen global';
cmd '[id="' . $right1->id . '"] focus';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right1, 'upper right window focused');
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
cmd '[id="' . $right2->id . '"] focus';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right2, 'bottom right window focused');
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
Allow focus child/parent when in fullscreen. This is now restricted according to the already defined fullscreen focus constraints. Test case 157 was removed, as we don't prevent level up/down in fullscreen anymore. Those commands are properly tested in fullscreen by test case 156. Fixes: #612
2012-05-26 23:36:25 +02:00
cmd 'focus parent';
isnt($x->input_focus, $right2->id, 'bottom right window no longer focused');
cmd 'focus child';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right2, 'bottom right window focused again');
Allow focus child/parent when in fullscreen. This is now restricted according to the already defined fullscreen focus constraints. Test case 157 was removed, as we don't prevent level up/down in fullscreen anymore. Those commands are properly tested in fullscreen by test case 156. Fixes: #612
2012-05-26 23:36:25 +02:00
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
cmd 'focus up';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right1, 'allowed focus up');
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
cmd 'focus down';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right2, 'allowed focus down');
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
cmd 'focus left';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right2, 'prevented focus left');
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
cmd 'focus right';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right2, 'prevented focus right');
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
cmd 'focus down';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right1, 'allowed focus wrap (down)');
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
cmd 'focus up';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right2, 'allowed focus wrap (up)');
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
################################################################################
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
# (depends on previous layout)
Allow focus child/parent when in fullscreen. This is now restricted according to the already defined fullscreen focus constraints. Test case 157 was removed, as we don't prevent level up/down in fullscreen anymore. Those commands are properly tested in fullscreen by test case 156. Fixes: #612
2012-05-26 23:36:25 +02:00
# Same tests when we're in non-global fullscreen mode. It should now be possible
# to focus a container in a different workspace.
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
################################################################################
cmd 'focus parent';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
cmd 'fullscreen disable';
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
cmd 'fullscreen';
cmd '[id="' . $right1->id . '"] focus';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right1, 'upper right window focused');
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
cmd '[id="' . $right2->id . '"] focus';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right2, 'bottom right window focused');
Refined the fullscreen focus constraints. Basically, a focus change can't escape a fullscreen container. The only exception is per-output fullscreen containers, as you should be able to focus a container in a different workspace in this case. This is an improvement on 4eab046e, now considering the difference between global and per-output fullscreen and taking the tree structure into account to determine what escaping the fullscreen container means. It only affects targeted focus commands in the form "for_window [...] focus", but it lays the foundation for forthcoming fixes to all other focus commands.
2012-05-26 22:37:45 +02:00
Allow focus child/parent when in fullscreen. This is now restricted according to the already defined fullscreen focus constraints. Test case 157 was removed, as we don't prevent level up/down in fullscreen anymore. Those commands are properly tested in fullscreen by test case 156. Fixes: #612
2012-05-26 23:36:25 +02:00
cmd 'focus parent';
isnt($x->input_focus, $right2->id, 'bottom right window no longer focused');
cmd 'focus child';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right2, 'bottom right window focused again');
Allow focus child/parent when in fullscreen. This is now restricted according to the already defined fullscreen focus constraints. Test case 157 was removed, as we don't prevent level up/down in fullscreen anymore. Those commands are properly tested in fullscreen by test case 156. Fixes: #612
2012-05-26 23:36:25 +02:00
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
cmd 'focus up';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right1, 'allowed focus up');
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
cmd 'focus down';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right2, 'allowed focus down');
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
cmd 'focus down';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right1, 'allowed focus wrap (down)');
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
cmd 'focus up';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right2, 'allowed focus wrap (up)');
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
Allow 'focus $dir' to move out of non-global fullscreen containers
2012-10-08 18:28:08 +02:00
cmd 'focus left';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right2, 'focus left wrapped (no-op)');
Allow 'focus $dir' to move out of non-global fullscreen containers
2012-10-08 18:28:08 +02:00
cmd 'focus right';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($diff_ws, 'allowed focus change to different ws');
Allow focus w/ target when in fs in some cases. If the target is in a different workspace, there's no reason why we wouldn't allow the user to focus it. We already allow this when focusing a workspace, for example.
2012-04-21 21:34:25 +02:00
Allow 'focus $dir' to move out of non-global fullscreen containers
2012-10-08 18:28:08 +02:00
cmd 'focus left';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right2, 'focused back into fullscreen container');
Allow 'focus $dir' to move out of non-global fullscreen containers
2012-10-08 18:28:08 +02:00
cmd '[id="' . $diff_ws->id . '"] focus';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($diff_ws, 'allowed focus change to different ws by id');
Allow 'focus $dir' to move out of non-global fullscreen containers
2012-10-08 18:28:08 +02:00
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
################################################################################
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
# (depends on previous layout)
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
# More testing of the interaction between wrapping and the fullscreen focus
# restrictions.
################################################################################
cmd '[id="' . $right1->id . '"] focus';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right1, 'upper right window focused');
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
cmd 'focus parent';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
cmd 'fullscreen disable';
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
cmd 'focus child';
cmd 'split v';
my $right12 = open_window;
cmd 'focus down';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right2, 'bottom right window focused');
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
cmd 'split v';
my $right22 = open_window;
cmd 'focus parent';
cmd 'fullscreen';
cmd 'focus child';
cmd 'focus down';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right2, 'focus did not leave parent container (1)');
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
cmd 'focus down';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right22, 'focus did not leave parent container (2)');
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
cmd 'focus up';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right2, 'focus did not leave parent container (3)');
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
cmd 'focus up';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($right22, 'focus did not leave parent container (4)');
Restrict directional focus in fullscreen. This reuses the same fullscreen focus logic to ensure that focus doesn't escape a fullscreen container.
2012-05-27 00:53:02 +02:00
Prevent moving out of fullscreen containers.
2012-05-27 02:45:15 +02:00
################################################################################
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
# (depends on previous layout)
Prevent moving out of fullscreen containers.
2012-05-27 02:45:15 +02:00
# Ensure that moving in a direction doesn't violate the focus restrictions.
################################################################################
Restrict "move to workspace" commands in fullscreen.
2012-05-27 03:13:16 +02:00
sub verify_move {
my $num = shift;
Prevent moving out of fullscreen containers.
2012-05-27 02:45:15 +02:00
my $msg = shift;
my $nodes = get_ws_content($tmp2);
my $split = $nodes->[1];
my $fs = $split->{nodes}->[1];
Restrict "move to workspace" commands in fullscreen.
2012-05-27 03:13:16 +02:00
is(scalar @{$fs->{nodes}}, $num, $msg);
Prevent moving out of fullscreen containers.
2012-05-27 02:45:15 +02:00
}
cmd 'move left';
Restrict "move to workspace" commands in fullscreen.
2012-05-27 03:13:16 +02:00
verify_move(2, 'prevented move left');
Prevent moving out of fullscreen containers.
2012-05-27 02:45:15 +02:00
cmd 'move right';
Restrict "move to workspace" commands in fullscreen.
2012-05-27 03:13:16 +02:00
verify_move(2, 'prevented move right');
Prevent moving out of fullscreen containers.
2012-05-27 02:45:15 +02:00
cmd 'move down';
Restrict "move to workspace" commands in fullscreen.
2012-05-27 03:13:16 +02:00
verify_move(2, 'prevented move down');
Prevent moving out of fullscreen containers.
2012-05-27 02:45:15 +02:00
cmd 'move up';
cmd 'move up';
Restrict "move to workspace" commands in fullscreen.
2012-05-27 03:13:16 +02:00
verify_move(2, 'prevented move up');
################################################################################
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
# (depends on previous layout)
Restrict "move to workspace" commands in fullscreen.
2012-05-27 03:13:16 +02:00
# Moving to a different workspace is allowed with per-output fullscreen
# containers.
################################################################################
cmd "move to workspace $tmp";
verify_move(1, 'did not prevent move to workspace by name');
cmd "workspace $tmp";
cmd "move to workspace $tmp2";
cmd "workspace $tmp2";
cmd "move to workspace prev";
verify_move(1, 'did not prevent move to workspace by position');
################################################################################
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
# (depends on previous layout)
Restrict "move to workspace" commands in fullscreen.
2012-05-27 03:13:16 +02:00
# Ensure that is not allowed with global fullscreen containers.
################################################################################
cmd "workspace $tmp";
cmd "move to workspace $tmp2";
cmd "workspace $tmp2";
cmd 'focus parent';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
cmd 'fullscreen disable';
Restrict "move to workspace" commands in fullscreen.
2012-05-27 03:13:16 +02:00
cmd 'fullscreen global';
cmd 'focus child';
cmd "move to workspace $tmp";
verify_move(2, 'prevented move to workspace by name');
cmd "move to workspace prev";
verify_move(2, 'prevented move to workspace by position');
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
kill_all_windows;
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
################################################################################
# Ensure it's possible to focus a window using the focus command despite
# fullscreen window blocking it. Fullscreen window should lose its fullscreen
# mode.
################################################################################
# first & second tiling, focus using id
$tmp = fresh_workspace;
my $first = open_window;
my $second = open_window;
cmd 'fullscreen';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($second, 'fullscreen window focused');
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
is_num_fullscreen($tmp, 1, '1 fullscreen window');
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
cmd '[id="' . $first->id . '"] focus';
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
sync_with_i3;
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($first, 'correctly focused using id');
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
is_num_fullscreen($tmp, 0, 'no fullscreen windows');
kill_all_windows;
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
# first floating, second tiling, focus using 'focus floating'
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
$tmp = fresh_workspace;
fixing redeclaration warnings in testcases
2017-12-26 13:16:15 +01:00
$first = open_floating_window;
$second = open_window;
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
cmd 'fullscreen';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($second, 'fullscreen window focused');
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
is_num_fullscreen($tmp, 1, '1 fullscreen window');
cmd 'focus floating';
sync_with_i3;
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($first, 'correctly focused using focus floating');
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
is_num_fullscreen($tmp, 0, 'no fullscreen windows');
kill_all_windows;
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
# first tiling, second floating, focus using 'focus tiling'
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
$tmp = fresh_workspace;
fixing redeclaration warnings in testcases
2017-12-26 13:16:15 +01:00
$first = open_window;
$second = open_floating_window;
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
cmd 'fullscreen';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($second, 'fullscreen window focused');
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
is_num_fullscreen($tmp, 1, '1 fullscreen window');
cmd 'focus tiling';
sync_with_i3;
Prevent moving out of fullscreen containers.
2012-05-27 02:45:15 +02:00
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($first, 'correctly focused using focus tiling');
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
is_num_fullscreen($tmp, 0, 'no fullscreen windows');
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
kill_all_windows;
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
################################################################################
# When the fullscreen window is in an other workspace it should maintain its
# fullscreen mode since it's not blocking the window to be focused.
################################################################################
$tmp = fresh_workspace;
fixing redeclaration warnings in testcases
2017-12-26 13:16:15 +01:00
$first = open_window;
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
$tmp2 = fresh_workspace;
fixing redeclaration warnings in testcases
2017-12-26 13:16:15 +01:00
$second = open_window;
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
cmd 'fullscreen';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($second, 'fullscreen window focused');
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
is_num_fullscreen($tmp2, 1, '1 fullscreen window');
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
cmd '[id="' . $first->id . '"] focus';
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
sync_with_i3;
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($first, 'correctly focused using focus id');
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
is_num_fullscreen($tmp, 0, 'no fullscreen windows on first workspace');
is_num_fullscreen($tmp2, 1, 'still one fullscreen window on second workspace');
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
kill_all_windows;
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
################################################################################
# But a global window in another workspace is blocking the window to be focused.
# Ensure that it loses its fullscreen mode.
################################################################################
$tmp = fresh_workspace;
$first = open_window;
$tmp2 = fresh_workspace;
$second = open_window;
cmd 'fullscreen global';
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($second, 'global window focused');
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
is_num_fullscreen($tmp2, 1, '1 fullscreen window');
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
cmd '[id="' . $first->id . '"] focus';
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
sync_with_i3;
Make t/156-fullscreen-focus.t easier to work with - Add routine that will refocus the expected window on test failure. Thus, failure on one test will not make others fail. - Remove some redundant commands, prefer fresh_workspace for screen changing. - Kill previous windows between sections if the next section does not depend on the previous layout.
2018-09-13 13:09:35 +02:00
verify_focus($first, 'correctly focused using focus id');
Make 'focus' disable blocking fullscreen windows The problem here is that con_fullscreen_permits_focusing() does not check if there is a blocking fullscreen container in the workspace that the container to be focused belongs. This makes it possible to focus a container behind a fullscreen window if it's in an unfocused workspace. This commit introduces a change in the 'focus' command behaviour. When focusing a container blocked by a fullscreen container, either CF_OUTPUT or CF_GLOBAL, the blocking container loses its fullscreen mode and the target container is focused like normal. This should not affect directional focus commands: left, right, up, down, parent, child. Fixes issue #1819.
2017-09-17 01:20:48 +02:00
is_num_fullscreen($tmp2, 0, 'no fullscreen windows');
# TODO: Tests for "move to output" and "move workspace to output".
When leaving fullscreen, set focus to con which was opened during fullscreen (+testcase) (Thanks dothebart)
2011-03-07 00:06:27 +01:00
done_testing;