nixo
/
gri3-wm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
gri3-wm/testcases/t/260-invalid-criteria.t

28 lines
730 B
Perl
Raw Normal View History

Reject invalid match criteria with an error. Previously, using a command like [con_id=foo] kill would kill the currently focused window because while an error for not being able to parse the con_id was logged, no further action was taken, which caused the criterion to be ignored. In this case, the fallback behavior of using the focused window took over. For con_id, id and window_type we now reject incorrect values with an error and abort the command. fixes #2091
2015-12-09 13:39:08 +01:00
#!perl
# vim:ts=4:sw=4:expandtab
#
# Please read the following documents before working on tests:
tests: replace http:// with https:// where appropriate This was done automatically using: % sed -i 's,http://build.i3wm.org,https://build.i3wm.org,g' testcases/t/*.t
2017-09-24 10:19:50 +02:00
# • https://build.i3wm.org/docs/testsuite.html
Reject invalid match criteria with an error. Previously, using a command like [con_id=foo] kill would kill the currently focused window because while an error for not being able to parse the con_id was logged, no further action was taken, which caused the criterion to be ignored. In this case, the fallback behavior of using the focused window took over. For con_id, id and window_type we now reject incorrect values with an error and abort the command. fixes #2091
2015-12-09 13:39:08 +01:00
# (or docs/testsuite)
#
tests: replace http:// with https:// where appropriate This was done automatically using: % sed -i 's,http://build.i3wm.org,https://build.i3wm.org,g' testcases/t/*.t
2017-09-24 10:19:50 +02:00
# • https://build.i3wm.org/docs/lib-i3test.html
Reject invalid match criteria with an error. Previously, using a command like [con_id=foo] kill would kill the currently focused window because while an error for not being able to parse the con_id was logged, no further action was taken, which caused the criterion to be ignored. In this case, the fallback behavior of using the focused window took over. For con_id, id and window_type we now reject incorrect values with an error and abort the command. fixes #2091
2015-12-09 13:39:08 +01:00
# (alternatively: perldoc ./testcases/lib/i3test.pm)
#
tests: replace http:// with https:// where appropriate This was done automatically using: % sed -i 's,http://build.i3wm.org,https://build.i3wm.org,g' testcases/t/*.t
2017-09-24 10:19:50 +02:00
# • https://build.i3wm.org/docs/ipc.html
Reject invalid match criteria with an error. Previously, using a command like [con_id=foo] kill would kill the currently focused window because while an error for not being able to parse the con_id was logged, no further action was taken, which caused the criterion to be ignored. In this case, the fallback behavior of using the focused window took over. For con_id, id and window_type we now reject incorrect values with an error and abort the command. fixes #2091
2015-12-09 13:39:08 +01:00
# (or docs/ipc)
#
# • http://onyxneon.com/books/modern_perl/modern_perl_a4.pdf
# (unless you are already familiar with Perl)
#
# Ticket: #2091
use i3test;
my $ws = fresh_workspace;
open_window;
my $result = cmd '[con_id=foobar] kill';
is($result->[0]->{success}, 0, 'command was unsuccessful');
is($result->[0]->{error}, 'Invalid match: invalid con_id', 'correct error is returned');
done_testing;