nixo
/
gri3-wm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Bugfix: Allocate 32 bytes for xcb_send_event, it always copies 32 bytes 

Fixes an 'uninitialized memory' error in valgrind
This commit is contained in:
Michael Stapelberg 2011-07-31 17:46:01 +02:00
parent 4875868689
commit 1e0033bce4
1 changed files with 17 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/xcb.c
View File

@ -167,23 +167,29 @@ void xcb_draw_rect(xcb_connection_t *conn, xcb_drawable_t drawable, xcb_gcontext
* *
*/ */
void fake_configure_notify(xcb_connection_t *conn, Rect r, xcb_window_t window) { void fake_configure_notify(xcb_connection_t *conn, Rect r, xcb_window_t window) {
xcb_configure_notify_event_t generated_event; /* Every X11 event is 32 bytes long. Therefore, XCB will copy 32 bytes.
* In order to properly initialize these bytes, we allocate 32 bytes even
* though we only need less for an xcb_configure_notify_event_t */
void *event = scalloc(32);
xcb_configure_notify_event_t *generated_event = event;
generated_event.event = window; generated_event->event = window;
generated_event.window = window; generated_event->window = window;
generated_event.response_type = XCB_CONFIGURE_NOTIFY; generated_event->response_type = XCB_CONFIGURE_NOTIFY;
generated_event.x = r.x; generated_event->x = r.x;
generated_event.y = r.y; generated_event->y = r.y;
generated_event.width = r.width; generated_event->width = r.width;
generated_event.height = r.height; generated_event->height = r.height;
generated_event.border_width = 0; generated_event->border_width = 0;
generated_event.above_sibling = XCB_NONE; generated_event->above_sibling = XCB_NONE;
generated_event.override_redirect = false; generated_event->override_redirect = false;
xcb_send_event(conn, false, window, XCB_EVENT_MASK_STRUCTURE_NOTIFY, (char*)&generated_event); xcb_send_event(conn, false, window, XCB_EVENT_MASK_STRUCTURE_NOTIFY, (char*)&generated_event);
xcb_flush(conn); xcb_flush(conn);
free(event);
} }
/* /*