nixo
/
gri3-wm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

i3bar: Group child processes for signalling 

Set the process group id of the child process by calling `setpgid` after
forking and before calling `exec`.

The process group ID will be set to the process ID of the forked
process. Processes spawned by this child process will also have this
group ID.

Send signals to the process group with `killpg`. This will send the
signal to all of the process group.

fixes #1128
This commit is contained in:
Tony Crisci 2013-12-01 01:37:43 -05:00 committed by Michael Stapelberg
parent 454f11755e
commit 39f15da82f
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
i3bar/src/child.c
View File

@ -424,6 +424,7 @@ void start_child(char *command) {
dup2(pipe_in[1], STDOUT_FILENO); dup2(pipe_in[1], STDOUT_FILENO);
dup2(pipe_out[0], STDIN_FILENO); dup2(pipe_out[0], STDIN_FILENO);
setpgid(child.pid, 0);
execl(_PATH_BSHELL, _PATH_BSHELL, "-c", command, (char*) NULL); execl(_PATH_BSHELL, _PATH_BSHELL, "-c", command, (char*) NULL);
return; return;
default: default:
@ -507,8 +508,8 @@ void send_block_clicked(int button, const char *name, const char *instance, int
void kill_child_at_exit(void) { void kill_child_at_exit(void) {
if (child.pid > 0) { if (child.pid > 0) {
if (child.cont_signal > 0 && child.stopped) if (child.cont_signal > 0 && child.stopped)
kill(child.pid, child.cont_signal); killpg(child.pid, child.cont_signal);
kill(child.pid, SIGTERM); killpg(child.pid, SIGTERM);
} }
} }
@ -520,8 +521,8 @@ void kill_child_at_exit(void) {
void kill_child(void) { void kill_child(void) {
if (child.pid > 0) { if (child.pid > 0) {
if (child.cont_signal > 0 && child.stopped) if (child.cont_signal > 0 && child.stopped)
kill(child.pid, child.cont_signal); killpg(child.pid, child.cont_signal);
kill(child.pid, SIGTERM); killpg(child.pid, SIGTERM);
int status; int status;
waitpid(child.pid, &status, 0); waitpid(child.pid, &status, 0);
cleanup(); cleanup();
@ -535,7 +536,7 @@ void kill_child(void) {
void stop_child(void) { void stop_child(void) {
if (child.stop_signal > 0 && !child.stopped) { if (child.stop_signal > 0 && !child.stopped) {
child.stopped = true; child.stopped = true;
kill(child.pid, child.stop_signal); killpg(child.pid, child.stop_signal);
} }
} }
@ -546,6 +547,6 @@ void stop_child(void) {
void cont_child(void) { void cont_child(void) {
if (child.cont_signal > 0 && child.stopped) { if (child.cont_signal > 0 && child.stopped) {
child.stopped = false; child.stopped = false;
kill(child.pid, child.cont_signal); killpg(child.pid, child.cont_signal);
} }
} }