nixo
/
gri3-wm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Bugfix: Obey workspace_layout when re-inserting floating containers (+test) (Thanks aksr) 

The code wasn’t using con_attach and therefore didn’t obey workspace_layout.

Fixes: #631
next
Michael Stapelberg 2012-01-30 16:03:51 +00:00
parent 714c8fcbe7
commit 4f98bbf5ff
2 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/floating.c
View File

@ -238,11 +238,10 @@ void floating_disable(Con *con, bool automatic) {
/* con_fix_percent will adjust the percent value */
con->percent = 0.0;
TAILQ_INSERT_TAIL(&(con->parent->nodes_head), con, nodes);
TAILQ_INSERT_TAIL(&(con->parent->focus_head), con, focused);
con->floating = FLOATING_USER_OFF;
con_attach(con, con->parent, false);
con_fix_percent(con->parent);
// TODO: don’t influence focus handling when Con was not focused before.
con_focus(con);

18
testcases/t/167-workspace_layout.t
View File

@ -122,6 +122,24 @@ is($content[1]->{layout}, 'stacked', 'layout stacked');
is(@content, 1, 'one con on target workspace');
is($content[0]->{layout}, 'stacked', 'layout stacked');
#####################################################################
# 7: toggle floating mode and check that we have a stacked con when
# re-inserting a floating container.
#####################################################################
$tmp = fresh_workspace;
$first = open_window;
cmd 'floating toggle';
cmd 'floating toggle';
$second = open_window;
is($x->input_focus, $second->id, 'second window focused');
@content = @{get_ws_content($tmp)};
ok(@content == 1, 'one con at workspace level');
is($content[0]->{layout}, 'stacked', 'layout stacked');
exit_gracefully($pid);
done_testing;