nixo
/
gri3-wm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Prevent freeing of uninitialized pointer 

> variable 'buf' is used uninitialized whenever 'if' condition is true

Note: freeing a NULL pointer is fine.
This commit is contained in:
Orestis Floros 2017-09-16 23:53:31 +03:00 committed by Michael Stapelberg
parent f1e9da71f0
commit 5dad79ff34
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/tree.c
View File

@ -66,13 +66,13 @@ static Con *_create___i3(void) {
bool tree_restore(const char *path, xcb_get_geometry_reply_t *geometry) { bool tree_restore(const char *path, xcb_get_geometry_reply_t *geometry) {
bool result = false; bool result = false;
char *globbed = resolve_tilde(path); char *globbed = resolve_tilde(path);
char *buf = NULL;
if (!path_exists(globbed)) { if (!path_exists(globbed)) {
LOG("%s does not exist, not restoring tree\n", globbed); LOG("%s does not exist, not restoring tree\n", globbed);
goto out; goto out;
} }
char *buf = NULL;
ssize_t len; ssize_t len;
if ((len = slurp(globbed, &buf)) < 0) { if ((len = slurp(globbed, &buf)) < 0) {
/* slurp already logged an error. */ /* slurp already logged an error. */