nixo
/
gri3-wm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cmd_rename_workspace: correct order of events 

1. Rename happens
2. Workspace is moved because of assignments
3. Workspace closes because it is empty (#3248)

Fixes #3248.
This commit is contained in:
Orestis Floros 2018-09-06 03:11:47 +03:00
parent 7c3c50c5cc
commit 6846ac98c0
No known key found for this signature in database
GPG Key ID: E9AD9F32E401E38F
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/commands.c
View File

@ -2002,6 +2002,7 @@ void cmd_rename_workspace(I3_CMD, const char *old_name, const char *new_name) {
Con *parent = workspace->parent; Con *parent = workspace->parent;
con_detach(workspace); con_detach(workspace);
con_attach(workspace, parent, false); con_attach(workspace, parent, false);
ipc_send_workspace_event("rename", workspace, NULL);
/* Move the workspace to the correct output if it has an assignment */ /* Move the workspace to the correct output if it has an assignment */
struct Workspace_Assignment *assignment = NULL; struct Workspace_Assignment *assignment = NULL;
@ -2046,7 +2047,6 @@ void cmd_rename_workspace(I3_CMD, const char *old_name, const char *new_name) {
cmd_output->needs_tree_render = true; cmd_output->needs_tree_render = true;
ysuccess(true); ysuccess(true);
ipc_send_workspace_event("rename", workspace, NULL);
ewmh_update_desktop_names(); ewmh_update_desktop_names();
ewmh_update_desktop_viewport(); ewmh_update_desktop_viewport();
ewmh_update_current_desktop(); ewmh_update_current_desktop();

15
testcases/t/522-rename-assigned-workspace.t
View File

@ -93,6 +93,21 @@ cmd 'rename workspace 5 to 2';
is(get_output_for_workspace('2'), 'fake-1', is(get_output_for_workspace('2'), 'fake-1',
'Renaming an unfocused workspace, triggering an assignment to the output which holds the currently focused empty workspace should result in the original workspace replacing the empty one'); 'Renaming an unfocused workspace, triggering an assignment to the output which holds the currently focused empty workspace should result in the original workspace replacing the empty one');
##########################################################################
# Renaming an unfocused empty workspace, triggering an assignment to the
# output which holds the currently focused non-empty workspace should
# close the empty workspace and not crash i3.
# See issue #3248.
##########################################################################
cmd 'workspace 1';
cmd 'workspace 2';
open_window;
cmd 'rename workspace 1 to baz';
is(get_output_for_workspace('baz'), '',
'Renaming an unfocused empty workspace, triggering an assignment to the output which holds the currently focused non-empty workspace should close the empty workspace and not crash i3');
kill_all_windows;
########################################################################## ##########################################################################
# Renaming a workspace with multiple assignments, where the first output # Renaming a workspace with multiple assignments, where the first output
# doesn't exist. # doesn't exist.