nixo
/
gri3-wm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix a memory leak in handle_get_bar_config

This commit is contained in:
Michael Stapelberg 2015-10-19 19:11:53 +02:00
parent 5648221d06
commit 724cfebe5e
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/ipc.c
View File

@ -894,8 +894,8 @@ IPC_HANDLER(get_bar_config) {
/* To get a properly terminated buffer, we copy /* To get a properly terminated buffer, we copy
* message_size bytes out of the buffer */ * message_size bytes out of the buffer */
char *bar_id = scalloc(message_size + 1, 1); char *bar_id = NULL;
strncpy(bar_id, (const char *)message, message_size); sasprintf(&bar_id, "%.*s", message_size, message);
LOG("IPC: looking for config for bar ID \"%s\"\n", bar_id); LOG("IPC: looking for config for bar ID \"%s\"\n", bar_id);
Barconfig *current, *config = NULL; Barconfig *current, *config = NULL;
TAILQ_FOREACH(current, &barconfigs, configs) { TAILQ_FOREACH(current, &barconfigs, configs) {
@ -905,6 +905,7 @@ IPC_HANDLER(get_bar_config) {
config = current; config = current;
break; break;
} }
free(bar_id);
if (!config) { if (!config) {
/* If we did not find a config for the given ID, the reply will contain /* If we did not find a config for the given ID, the reply will contain