nixo
/
gri3-wm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #1465 from Airblader/bugfix-1430 

Make click events on status blocks work if 'workspace_buttons no' is set...
This commit is contained in:
Michael Stapelberg 2015-02-11 20:45:12 +01:00
parent 20dc3271a7 594b29f83d
commit 797855d98e
2 changed files with 42 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
i3bar/src/child.c
View File

@ -520,33 +520,35 @@ void child_click_events_key(const char *key) {
* *
*/ */
void send_block_clicked(int button, const char *name, const char *instance, int x, int y) { void send_block_clicked(int button, const char *name, const char *instance, int x, int y) {
if (child.click_events) { if (!child.click_events) {
child_click_events_initialize(); return;
yajl_gen_map_open(gen);
if (name) {
child_click_events_key("name");
yajl_gen_string(gen, (const unsigned char *)name, strlen(name));
}
if (instance) {
child_click_events_key("instance");
yajl_gen_string(gen, (const unsigned char *)instance, strlen(instance));
}
child_click_events_key("button");
yajl_gen_integer(gen, button);
child_click_events_key("x");
yajl_gen_integer(gen, x);
child_click_events_key("y");
yajl_gen_integer(gen, y);
yajl_gen_map_close(gen);
child_write_output();
} }
child_click_events_initialize();
yajl_gen_map_open(gen);
if (name) {
child_click_events_key("name");
yajl_gen_string(gen, (const unsigned char *)name, strlen(name));
}
if (instance) {
child_click_events_key("instance");
yajl_gen_string(gen, (const unsigned char *)instance, strlen(instance));
}
child_click_events_key("button");
yajl_gen_integer(gen, button);
child_click_events_key("x");
yajl_gen_integer(gen, x);
child_click_events_key("y");
yajl_gen_integer(gen, y);
yajl_gen_map_close(gen);
child_write_output();
} }
/* /*

30
i3bar/src/xcb.c
View File

@ -314,18 +314,6 @@ void handle_button(xcb_button_press_event_t *event) {
return; return;
} }
/* TODO: Move this to extern get_ws_for_output() */
TAILQ_FOREACH (cur_ws, walk->workspaces, tailq) {
if (cur_ws->visible) {
break;
}
}
if (cur_ws == NULL) {
DLOG("No Workspace active?\n");
return;
}
int32_t x = event->event_x >= 0 ? event->event_x : 0; int32_t x = event->event_x >= 0 ? event->event_x : 0;
int32_t original_x = x; int32_t original_x = x;
@ -364,6 +352,18 @@ void handle_button(xcb_button_press_event_t *event) {
x = original_x; x = original_x;
} }
/* TODO: Move this to extern get_ws_for_output() */
TAILQ_FOREACH (cur_ws, walk->workspaces, tailq) {
if (cur_ws->visible) {
break;
}
}
if (cur_ws == NULL) {
DLOG("No Workspace active?\n");
return;
}
switch (event->detail) { switch (event->detail) {
case 4: case 4:
/* Mouse wheel up. We select the previous ws, if any. /* Mouse wheel up. We select the previous ws, if any.
@ -1460,10 +1460,8 @@ void reconfig_windows(bool redraw_bars) {
* BUTTON_PRESS, to handle clicks on the workspace buttons * BUTTON_PRESS, to handle clicks on the workspace buttons
* */ * */
values[2] = XCB_EVENT_MASK_EXPOSURE | values[2] = XCB_EVENT_MASK_EXPOSURE |
XCB_EVENT_MASK_SUBSTRUCTURE_REDIRECT; XCB_EVENT_MASK_SUBSTRUCTURE_REDIRECT |
if (!config.disable_ws) { XCB_EVENT_MASK_BUTTON_PRESS;
values[2] |= XCB_EVENT_MASK_BUTTON_PRESS;
}
xcb_void_cookie_t win_cookie = xcb_create_window_checked(xcb_connection, xcb_void_cookie_t win_cookie = xcb_create_window_checked(xcb_connection,
root_screen->root_depth, root_screen->root_depth,
walk->bar, walk->bar,