nixo
/
gri3-wm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove TODO for cycling through the floating z-index. 

I think this is not a good feature to have. It shouldn’t be necessary
for a tiling window manager that explicitly discourages the use of
floating windows.

fixes #1324
next
Michael Stapelberg 2014-07-20 23:49:08 +02:00
parent 0d656dd05d
commit 8e8afb2609
1 changed files with 22 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
src/tree.c
View File

@ -599,33 +599,30 @@ static bool _tree_next(Con *con, char way, orientation_t orientation, bool wrap)
Con *parent = con->parent;
if (con->type == CT_FLOATING_CON) {
/* left/right focuses the previous/next floating container */
if (orientation == HORIZ) {
Con *next;
if (way == 'n')
next = TAILQ_NEXT(con, floating_windows);
else
next = TAILQ_PREV(con, floating_head, floating_windows);
/* If there is no next/previous container, wrap */
if (!next) {
if (way == 'n')
next = TAILQ_FIRST(&(parent->floating_head));
else
next = TAILQ_LAST(&(parent->floating_head), floating_head);
}
/* Still no next/previous container? bail out */
if (!next)
return false;
con_focus(con_descend_focused(next));
return true;
} else {
/* up/down cycles through the Z-index */
/* TODO: implement cycling through the z-index */
if (orientation != HORIZ)
return false;
/* left/right focuses the previous/next floating container */
Con *next;
if (way == 'n')
next = TAILQ_NEXT(con, floating_windows);
else
next = TAILQ_PREV(con, floating_head, floating_windows);
/* If there is no next/previous container, wrap */
if (!next) {
if (way == 'n')
next = TAILQ_FIRST(&(parent->floating_head));
else
next = TAILQ_LAST(&(parent->floating_head), floating_head);
}
/* Still no next/previous container? bail out */
if (!next)
return false;
con_focus(con_descend_focused(next));
return true;
}
/* If the orientation does not match or there is no other con to focus, we