From 95e8b1a46783426b4bd3101eff5774da4f496e32 Mon Sep 17 00:00:00 2001
From: Michael Stapelberg <michael@stapelberg.de>
Date: Mon, 21 Feb 2011 00:23:25 +0100
Subject: [PATCH] tests: extend t/10-dock.t to make use of the tree

---
 testcases/t/10-dock.t     | 50 +++++++++++++++++++++++++++++++++++++--
 testcases/t/lib/i3test.pm |  2 +-
 2 files changed, 49 insertions(+), 3 deletions(-)

diff --git a/testcases/t/10-dock.t b/testcases/t/10-dock.t
index 66a05b26..dabb7bd8 100644
--- a/testcases/t/10-dock.t
+++ b/testcases/t/10-dock.t
@@ -1,7 +1,7 @@
 #!perl
 # vim:ts=4:sw=4:expandtab
 
-use i3test tests => 2;
+use i3test;
 use X11::XCB qw(:all);
 use Time::HiRes qw(sleep);
 use List::Util qw(first);
@@ -11,6 +11,23 @@ BEGIN {
 }
 
 my $x = X11::XCB::Connection->new;
+my $i3 = i3("/tmp/nestedcons");
+
+#####################################################################
+# verify that there is no dock window yet
+#####################################################################
+
+my $tree = $i3->get_tree->recv;
+my @outputs = @{$tree->{nodes}};
+# Children of all dockareas
+my @docked;
+for my $output (@outputs) {
+    @docked = (@docked, map { @{$_->{nodes}} }
+                        grep { $_->{type} == 5 }
+                        @{$output->{nodes}});
+}
+
+is(@docked, 0, 'no dock clients yet');
 
 #####################################################################
 # Create a dock window and see if it gets managed
@@ -36,6 +53,34 @@ sleep 0.25;
 
 my $rect = $window->rect;
 is($rect->width, $primary->rect->width, 'dock client is as wide as the screen');
+is($rect->height, 30, 'height is unchanged');
+
+#####################################################################
+# check that we can find it in the layout tree at the expected position
+#####################################################################
+
+$tree = $i3->get_tree->recv;
+@outputs = @{$tree->{nodes}};
+@docked;
+for my $output (@outputs) {
+    @docked = (@docked, map { @{$_->{nodes}} }
+                        grep { $_->{type} == 5 }
+                        @{$output->{nodes}});
+}
+
+is(@docked, 1, 'one dock client found');
+
+# verify the position/size
+my $docknode = $docked[0];
+
+is($docknode->{rect}->{x}, 0, 'dock node placed at x=0');
+is($docknode->{rect}->{y}, 0, 'dock node placed at y=0');
+is($docknode->{rect}->{width}, $primary->rect->width, 'dock node as wide as the screen');
+is($docknode->{rect}->{height}, 30, 'dock node has unchanged height');
+
+#####################################################################
+# regression test: transient dock client
+#####################################################################
 
 my $fwindow = $x->root->create_child(
     class => WINDOW_CLASS_INPUT_OUTPUT,
@@ -49,5 +94,6 @@ $fwindow->map;
 
 sleep 0.25;
 
+does_i3_live;
 
-diag( "Testing i3, Perl $], $^X" );
+done_testing;
diff --git a/testcases/t/lib/i3test.pm b/testcases/t/lib/i3test.pm
index c1bb7ed3..7f6c0614 100644
--- a/testcases/t/lib/i3test.pm
+++ b/testcases/t/lib/i3test.pm
@@ -26,7 +26,7 @@ sub import {
     my $class = shift;
     my $pkg = caller;
     eval "package $pkg;
-use Test::More qw(@_);
+use Test::More" . (@_ > 0 ? " qw(@_)" : "") . ";
 use Test::Exception;
 use Data::Dumper;
 use AnyEvent::I3;