nixo
/
gri3-wm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Bugfix: ipc_receive_message reply leak 

The function ipc_recv_message in libi3 allocates memory to the location
of the `message` reply in src/ipc_receive_message.c with malloc and must
be freed.

This memory leak was found using valgrind.
next
Tony Crisci 2014-03-07 23:56:25 -05:00 committed by Michael Stapelberg
parent bc0bf2285c
commit a16dfdb15e
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/ipc.c
View File

@ -833,14 +833,16 @@ handler_t handlers[8] = {
static void ipc_receive_message(EV_P_ struct ev_io *w, int revents) {
uint32_t message_type;
uint32_t message_length;
uint8_t *message;
uint8_t *message = NULL;
int ret = ipc_recv_message(w->fd, &message_type, &message_length, &message);
/* EOF or other error */
if (ret < 0) {
/* Was this a spurious read? See ev(3) */
if (ret == -1 && errno == EAGAIN)
if (ret == -1 && errno == EAGAIN) {
FREE(message);
return;
}
/* If not, there was some kind of error. We don’t bother
* and close the connection */
@ -863,6 +865,7 @@ static void ipc_receive_message(EV_P_ struct ev_io *w, int revents) {
ev_io_stop(EV_A_ w);
free(w);
FREE(message);
DLOG("IPC: client disconnected\n");
return;
@ -874,6 +877,8 @@ static void ipc_receive_message(EV_P_ struct ev_io *w, int revents) {
handler_t h = handlers[message_type];
h(w->fd, message, 0, message_length, message_type);
}
FREE(message);
}
/*