resize set: accept 'width' and 'height' keywords

Fixes #3275
This commit is contained in:
Orestis Floros 2018-05-02 18:59:17 +03:00
parent b901fc9464
commit c50bf50f09
No known key found for this signature in database
GPG Key ID: E9AD9F32E401E38F
5 changed files with 49 additions and 2 deletions

View File

@ -2320,7 +2320,9 @@ If you want to resize containers/windows using your keyboard, you can use the
*Syntax*: *Syntax*:
------------------------------------------------------- -------------------------------------------------------
resize grow|shrink <direction> [<px> px [or <ppt> ppt]] resize grow|shrink <direction> [<px> px [or <ppt> ppt]]
resize set <width> [px | ppt] <height> [px | ppt] resize set [width] <width> [px | ppt]
resize set height <height> [px | ppt]
resize set [width] <width> [px | ppt] [height] <height> [px | ppt]
------------------------------------------------------- -------------------------------------------------------
Direction can either be one of +up+, +down+, +left+ or +right+. Or you can be Direction can either be one of +up+, +down+, +left+ or +right+. Or you can be

View File

@ -254,12 +254,24 @@ state RESIZE_TILING_FINAL:
-> call cmd_resize($way, $direction, &resize_px, &resize_ppt) -> call cmd_resize($way, $direction, &resize_px, &resize_ppt)
state RESIZE_SET: state RESIZE_SET:
'height'
-> RESIZE_HEIGHT_GET_NUMBER
'width'
->
width = number width = number
-> RESIZE_WIDTH -> RESIZE_WIDTH
state RESIZE_WIDTH: state RESIZE_WIDTH:
mode_width = 'px', 'ppt' mode_width = 'px', 'ppt'
-> ->
end
-> call cmd_resize_set(&width, $mode_width, 0, 0)
'height'
-> RESIZE_HEIGHT_GET_NUMBER
height = number
-> RESIZE_HEIGHT
state RESIZE_HEIGHT_GET_NUMBER:
height = number height = number
-> RESIZE_HEIGHT -> RESIZE_HEIGHT

View File

@ -686,7 +686,7 @@ void cmd_resize_set(I3_CMD, long cwidth, const char *mode_width, long cheight, c
} }
} }
if (cheight > 0 && mode_width && strcmp(mode_width, "ppt") == 0) { if (cheight > 0 && mode_height && strcmp(mode_height, "ppt") == 0) {
/* get the appropriate current container (skip stacked/tabbed cons) */ /* get the appropriate current container (skip stacked/tabbed cons) */
Con *target = current->con; Con *target = current->con;
Con *dummy; Con *dummy;

View File

@ -96,4 +96,22 @@ do_test(0, 0);
cmd 'resize set 100 ppt 0 px'; cmd 'resize set 100 ppt 0 px';
do_test(1333, 0); do_test(1333, 0);
################################################################################
# Use 'width' and 'height' keywords.
# See issue: #3275.
################################################################################
cmd 'resize set width 200 px';
do_test(200, 0);
cmd 'resize set height 200 px';
do_test(0, 200);
cmd 'resize set width 300 px height 300 px';
do_test(300, 300);
# ppt + keyword used only for height
cmd 'resize set 100 ppt height 100 px';
do_test(1333, 100);
done_testing; done_testing;

View File

@ -39,6 +39,14 @@ my ($nodes, $focus) = get_ws_content($tmp);
cmp_float($nodes->[0]->{percent}, 0.25, 'left window got only 25%'); cmp_float($nodes->[0]->{percent}, 0.25, 'left window got only 25%');
cmp_float($nodes->[1]->{percent}, 0.75, 'right window got 75%'); cmp_float($nodes->[1]->{percent}, 0.75, 'right window got 75%');
# Same but use the 'width' keyword.
cmd 'resize set width 80 ppt';
($nodes, $focus) = get_ws_content($tmp);
cmp_float($nodes->[0]->{percent}, 0.20, 'left window got 20%');
cmp_float($nodes->[1]->{percent}, 0.80, 'right window got 80%');
############################################################ ############################################################
# resize vertically # resize vertically
############################################################ ############################################################
@ -61,6 +69,13 @@ my ($nodes, $focus) = get_ws_content($tmp);
cmp_float($nodes->[0]->{percent}, 0.25, 'top window got only 25%'); cmp_float($nodes->[0]->{percent}, 0.25, 'top window got only 25%');
cmp_float($nodes->[1]->{percent}, 0.75, 'bottom window got 75%'); cmp_float($nodes->[1]->{percent}, 0.75, 'bottom window got 75%');
# Same but use the 'height' keyword.
cmd 'resize set height 80 ppt';
($nodes, $focus) = get_ws_content($tmp);
cmp_float($nodes->[0]->{percent}, 0.20, 'top window got 20%');
cmp_float($nodes->[1]->{percent}, 0.80, 'bottom window got 80%');
############################################################ ############################################################
# resize horizontally and vertically # resize horizontally and vertically