From cc9b227978d06777034f95643aa643c0dee079e4 Mon Sep 17 00:00:00 2001 From: Orestis Floros Date: Sat, 30 Mar 2019 13:43:36 +0200 Subject: [PATCH] Make small DLOG improvements - manage_window: log the window in the start of the function so that the reader knows what the rest of the messages refer to, even if the function exits prematurely. - con_is_floating: Message is spammy --- src/con.c | 1 - src/manage.c | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/con.c b/src/con.c index a88909e1..4b640eb8 100644 --- a/src/con.c +++ b/src/con.c @@ -539,7 +539,6 @@ bool con_is_internal(Con *con) { */ bool con_is_floating(Con *con) { assert(con != NULL); - DLOG("checking if con %p is floating\n", con); return (con->floating >= FLOATING_AUTO_ON); } diff --git a/src/manage.c b/src/manage.c index c1468123..80faa167 100644 --- a/src/manage.c +++ b/src/manage.c @@ -80,6 +80,8 @@ void restore_geometry(void) { */ void manage_window(xcb_window_t window, xcb_get_window_attributes_cookie_t cookie, bool needs_to_be_mapped) { + DLOG("window 0x%08x\n", window); + xcb_drawable_t d = {window}; xcb_get_geometry_cookie_t geomc; xcb_get_geometry_reply_t *geom; @@ -163,8 +165,6 @@ void manage_window(xcb_window_t window, xcb_get_window_attributes_cookie_t cooki wm_user_time_cookie = GET_PROPERTY(A__NET_WM_USER_TIME, UINT32_MAX); wm_desktop_cookie = GET_PROPERTY(A__NET_WM_DESKTOP, UINT32_MAX); - DLOG("Managing window 0x%08x\n", window); - i3Window *cwindow = scalloc(1, sizeof(i3Window)); cwindow->id = window; cwindow->depth = get_visual_depth(attr->visual);