Avoid use of uninitialized in init_dpi_end
If conn == NULL or display == NULL, init_dpi() jumps to init_dpi_end before (declaring and) initializing resource. In init_dpi_end, there is a free(resource) call conditionally on resource != NULL, so this may lead to a bogus free. Found by clang -Wsometimes-uninitialized.
This commit is contained in:
parent
c40aaec7ca
commit
d29d908003
|
@ -24,6 +24,7 @@ static long init_dpi_fallback(void) {
|
|||
*/
|
||||
void init_dpi(void) {
|
||||
xcb_xrm_database_t *database = NULL;
|
||||
char *resource = NULL;
|
||||
|
||||
if (conn == NULL) {
|
||||
goto init_dpi_end;
|
||||
|
@ -35,7 +36,6 @@ void init_dpi(void) {
|
|||
goto init_dpi_end;
|
||||
}
|
||||
|
||||
char *resource;
|
||||
xcb_xrm_resource_get_string(database, "Xft.dpi", NULL, &resource);
|
||||
if (resource == NULL) {
|
||||
DLOG("Resource Xft.dpi not specified, skipping.\n");
|
||||
|
|
Loading…
Reference in New Issue