nixo
/
gri3-wm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Bugfix: use rectangles instead of a polygon to avoid strange rendering errors 

With the polygon, when using pidgin, having the buddy list in the middle of the
screen, 200 px width, full screen high, then opening the manage accounts
window, the decorations of the buddy list were visible on the accounts window.
This commit is contained in:
Michael Stapelberg 2010-11-14 21:17:27 +01:00
parent 33eb00d6ae
commit d401703135
1 changed files with 9 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/x.c
View File

@ -256,23 +256,17 @@ void x_draw_decoration(Con *con) {
DLOG("window_rect spans (%d, %d) with %d x %d\n", con->window_rect.x, con->window_rect.y, con->window_rect.width, con->window_rect.height); DLOG("window_rect spans (%d, %d) with %d x %d\n", con->window_rect.x, con->window_rect.y, con->window_rect.width, con->window_rect.height);
#endif #endif
/* This polygon represents the border around the child window (left, /* These rectangles represents the border around the child window
* bottom and right part). We don’t just fill the whole rectangle * (left, bottom and right part). We don’t just fill the whole
* because some childs are not freely resizable and we want their * rectangle because some childs are not freely resizable and we want
* background color to "shine through". */ * their background color to "shine through". */
xcb_change_gc_single(conn, con->gc, XCB_GC_FOREGROUND, color->background); xcb_change_gc_single(conn, con->gc, XCB_GC_FOREGROUND, color->background);
xcb_point_t points[] = { xcb_rectangle_t borders[] = {
{ 0, 0 }, { 0, 0, br.x, r->height },
{ 0, r->height }, { 0, r->height + br.height + br.y, r->width, r->height },
{ r->width, r->height }, { r->width + br.width + br.x, 0, r->width, r->height }
{ r->width, 0 },
{ r->width + br.width + br.x, 0 },
{ r->width + br.width + br.x, r->height + br.height + br.y },
{ br.x, r->height + br.height },
{ br.x, 0 }
}; };
xcb_fill_poly(conn, con->frame, con->gc, XCB_POLY_SHAPE_COMPLEX, XCB_COORD_MODE_ORIGIN, 8, points); xcb_poly_fill_rectangle(conn, con->frame, con->gc, 3, borders);
/* 1pixel border needs an additional line at the top */ /* 1pixel border needs an additional line at the top */
if (border_style == BS_1PIXEL) { if (border_style == BS_1PIXEL) {
xcb_rectangle_t topline = { br.x, 0, con->rect.width + br.width + br.x, br.y }; xcb_rectangle_t topline = { br.x, 0, con->rect.width + br.width + br.x, br.y };