diff --git a/src/bindings.c b/src/bindings.c index 38002396..228f7a9d 100644 --- a/src/bindings.c +++ b/src/bindings.c @@ -649,6 +649,14 @@ void switch_mode(const char *new_mode) { translate_keysyms(); grab_all_keys(conn); + /* Reset all B_UPON_KEYRELEASE_IGNORE_MODS bindings to avoid possibly + * activating one of them. */ + Binding *bind; + TAILQ_FOREACH(bind, bindings, bindings) { + if (bind->release == B_UPON_KEYRELEASE_IGNORE_MODS) + bind->release = B_UPON_KEYRELEASE; + } + char *event_msg; sasprintf(&event_msg, "{\"change\":\"%s\", \"pango_markup\":%s}", mode->name, (mode->pango_markup ? "true" : "false")); diff --git a/testcases/t/258-keypress-release.t b/testcases/t/258-keypress-release.t index 766a8a1b..614164ab 100644 --- a/testcases/t/258-keypress-release.t +++ b/testcases/t/258-keypress-release.t @@ -36,6 +36,13 @@ bindsym --release Shift+x nop Shift+x # 133 == Mod4 bindcode 133 nop 133 bindcode --release 133 nop 133 release + +mode "a_mode" { + # 27 == r + bindcode 27 --release mode "default" +} +bindsym Mod1+r mode "a_mode" +bindcode 27 nop do not receive EOT use i3test::XTEST; use ExtUtils::PkgConfig; @@ -134,6 +141,30 @@ is(listen_for_binding( '133 release', 'triggered the 133 keycode release binding'); +for my $i (1 .. 2) { + is(listen_for_binding( + sub { + xtest_key_press(64); # Alt_l + xtest_key_press(27); # r + xtest_key_release(27); # r + xtest_key_release(64); # Alt_l + xtest_sync_with_i3; + }, + ), + 'mode "a_mode"', + "switched to mode \"a_mode\" $i/2"); + + is(listen_for_binding( + sub { + xtest_key_press(27); # r + xtest_key_release(27); # r + xtest_sync_with_i3; + }, + ), + 'mode "default"', + "switched back to default $i/2"); +} + } done_testing;