nixo
/
gri3-wm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Update EWMH properties on workspace move 

Closes #3965
Fixes #4001
This commit is contained in:
Orestis Floros 2020-04-10 04:37:41 +02:00
parent c611b9e0e0
commit ed67eaca2c
No known key found for this signature in database
GPG Key ID: A09DBD7D3222C1C3
2 changed files with 34 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/workspace.c
View File

@ -1049,6 +1049,8 @@ void workspace_move_to_output(Con *ws, Output *output) {
workspace_show(ws); workspace_show(ws);
} }
ewmh_update_desktop_properties();
if (!previously_visible_ws) { if (!previously_visible_ws) {
return; return;
} }

33
testcases/t/521-ewmh-desktop-viewport.t
View File

@ -50,7 +50,10 @@ sub get_desktop_viewport {
return unpack ("L$len", $reply->{value}); return unpack ("L$len", $reply->{value});
} }
# initialize the workspaces ################################################################################
# Initialize the workspaces
################################################################################
cmd 'workspace 1'; cmd 'workspace 1';
cmd 'workspace 0'; cmd 'workspace 0';
@ -60,6 +63,10 @@ my @desktop_viewport = get_desktop_viewport;
is_deeply(\@desktop_viewport, \@expected_viewport, is_deeply(\@desktop_viewport, \@expected_viewport,
'_NET_DESKTOP_VIEWPORT should be an array of x/y coordinate pairs for the upper left corner of the respective outputs of the workspaces'); '_NET_DESKTOP_VIEWPORT should be an array of x/y coordinate pairs for the upper left corner of the respective outputs of the workspaces');
################################################################################
# Create workspace
################################################################################
cmd 'workspace 0'; cmd 'workspace 0';
open_window; open_window;
cmd 'workspace 3'; cmd 'workspace 3';
@ -70,6 +77,10 @@ cmd 'workspace 3';
is_deeply(\@desktop_viewport, \@expected_viewport, is_deeply(\@desktop_viewport, \@expected_viewport,
'it should be updated when a new workspace appears'); 'it should be updated when a new workspace appears');
################################################################################
# Rename workspace
################################################################################
cmd 'rename workspace 3 to 2'; cmd 'rename workspace 3 to 2';
@expected_viewport = (0, 0, 0, 0, 1024, 0); @expected_viewport = (0, 0, 0, 0, 1024, 0);
@ -78,6 +89,10 @@ cmd 'rename workspace 3 to 2';
is_deeply(\@desktop_viewport, \@expected_viewport, is_deeply(\@desktop_viewport, \@expected_viewport,
'it should stay up to date when a workspace is renamed'); 'it should stay up to date when a workspace is renamed');
################################################################################
# Empty workspace
################################################################################
cmd 'workspace 0'; cmd 'workspace 0';
@expected_viewport = (0, 0, 1024, 0); @expected_viewport = (0, 0, 1024, 0);
@ -86,4 +101,20 @@ cmd 'workspace 0';
is_deeply(\@desktop_viewport, \@expected_viewport, is_deeply(\@desktop_viewport, \@expected_viewport,
'it should be updated when a workspace is emptied'); 'it should be updated when a workspace is emptied');
################################################################################
# Move workspace
# See #4001
################################################################################
# Keep workspace 1 open to have 3 workspaces in total
cmd 'workspace 1';
open_window;
cmd 'workspace 0, move workspace to output right';
@expected_viewport = (0, 0, 1024, 0, 1024, 0);
@desktop_viewport = get_desktop_viewport;
is_deeply(\@desktop_viewport, \@expected_viewport,
'it should be updated when a workspace is moved');
################################################################################
done_testing; done_testing;