17d0cd7034
Remove various unused parameters
2019-10-20 16:14:20 +03:00
428cb94e29
Merge pull request #3839 from orestisfl/remanage_window-crash
...
remanage_window: avoid crash when nc->window == NULL
2019-10-18 16:51:42 +03:00
812507c4a1
remanage_window: avoid crash when nc->window == NULL
...
Temporary solution until we find the root cause. Not that it is a bad
idea to check for NULL either way.
Related to #3731
2019-10-18 11:58:08 +03:00
6011e245e9
Merge pull request #3835 from orestisfl/tree_flatten_crash
...
Fix crash with moving container that is to be flattened
2019-10-18 09:24:32 +02:00
cb535a4267
Merge pull request #3837 from orestisfl/scratchpad-fullscreen
...
scratchpad_move: un-fullscreen correct container
2019-10-18 09:22:39 +02:00
95d4ce3ed6
scratchpad_move: un-fullscreen correct container
...
Fixes https://github.com/i3/i3/issues/2857#issuecomment-496264445
2019-10-17 18:14:21 +03:00
879fd6c08b
Merge pull request #3836 from orestisfl/userguide
...
userguide: Remove mention of config directives with 'command equivalents'
2019-10-17 12:06:46 +02:00
72765bbb94
userguide: Remove mention of config directives with 'command equivalents'
...
See #3657
2019-10-17 12:56:29 +03:00
9138bb37f1
Merge pull request #3834 from Airblader/bug-3819
...
Reparent windows to their current position on unmanage
2019-10-16 10:42:35 +03:00
9118ee6029
Merge pull request #3833 from orestisfl/move-to-position+scratchpad
...
Do not show scratchpad windows after 'move to position'
2019-10-16 09:06:05 +02:00
359d75cd3c
Fix crash with moving container that is to be flattened
...
Same can happen with move_to_output_directed but it is not so easy to
write a test about it.
Fixes #3831
2019-10-16 01:32:05 +03:00
1b3d8650a7
Reparent windows to their current position on unmanage
...
When unmanaging a window we need to reparent it back to the root
window. With this patch we do so at the current position of the
container such that we don't throw away the geometry position.
This fixes cases where clients withdraw a window and reparent it
later on, expecting to keep the same geometry (in particular dock
clients) but then end up on a wrong output.
fixes #3819
2019-10-15 22:32:48 +02:00
b48ff2c5ec
Do not show scratchpad windows after 'move to position'
...
Fixes #3832
2019-10-15 18:40:59 +03:00
cb9620c60a
Merge pull request #3407 from orestisfl/tree_next
...
tree_next refactor & enhancements
2019-10-15 13:47:24 +02:00
ebb8d89021
Merge pull request #3830 from orestisfl/i3bar-leak
...
Fix i3bar leak on handle_destroy_notify
2019-10-15 12:50:28 +02:00
33634fbacd
Fix i3bar leak on handle_destroy_notify
2019-10-14 17:34:38 +03:00
a638e0408e
Merge pull request #3829 from orestisfl/move_to_mark_focus
...
_con_move_to_con: focus_next only if in different workspaces
2019-10-14 15:27:13 +02:00
2821270949
_con_move_to_con: focus_next only if in different workspaces
2019-10-14 15:38:44 +03:00
24a58d2952
Implement focus_wrapping workspace
...
I had a dilemma about the behaviour here:
1. Prohibit focus leaving the workspace in any case unless if
get_tree_next's initial argument is a workspace. This is what this
commit does (also i3-cycle).
2. Leave the workspace if no warp is possible (eg workspace with single
container or `focus right` with `V[a b c*]`).
Fixes #2180
2019-10-14 13:02:33 +03:00
9c408396d9
Merge pull request #3828 from orestisfl/i3-nagbar
...
Minor i3-nagbar changes
2019-10-14 11:45:40 +02:00
ffde51e50f
i3-nagbar: Fix small leak
2019-10-14 12:26:10 +03:00
a3f94783e5
i3-nagbar: get_window_position: Improve logging
2019-10-14 12:26:04 +03:00
b1723f0549
i3-nagbar: Don't use DLOG
...
debuglog() is empty and no option to enable it exists
2019-10-14 12:24:30 +03:00
3127a94c0d
Merge pull request #3827 from orestisfl/i3bar-leak
...
Fix small leak in i3bar's main
2019-10-14 09:54:32 +02:00
ee30c34b5c
Fix small leak in i3bar's main
...
If -s is used, the socket_path returned by getenv is never freed.
Also some small rearrangements.
2019-10-14 03:54:48 +03:00
bbc4c99c72
Refactor tree_next
...
- Makes `tree_next` not recursive.
- Adds `focus next|prev [sibling]` command. See (1.) and (2.) in
https://github.com/i3/i3/issues/2587#issuecomment-378505551 (Issue also
requests move command, not implemented here).
- Directional focus command now supports command criteria.
Wrapping is not implemented inside a floating container. This was also
true before the refactor so I am not changing it here.
2019-10-14 03:31:24 +03:00
f402f45702
Introduce CMD_FOCUS_WARN_CHILDREN
2019-10-14 02:38:53 +03:00
1e8e4d3e7f
Introduce direction / orientation / position conversion functions
2019-10-14 02:38:53 +03:00
e5c430e419
tree_move: Use direction_t
2019-10-14 02:31:11 +03:00
0cd7250f41
Add testcases/t/308-focus_wrapping.t
...
These tests pass with and without the following refactoring.
2019-10-14 02:30:06 +03:00
b0d6f44779
Use AC_REPLACE_FUNCS
...
strndup is removed from AC_CHECK_FUNCS since it will be provided if not
found.
Fixes #2610
2019-10-13 13:17:40 +03:00
70c850ac13
Remove memmem implementation
...
Not used after 3bd5e6e5c8
2019-10-13 13:10:06 +03:00
5f54971425
Merge pull request #3821 from orestisfl/deterministic_tray_icon_order
...
reorder_trayclients_cmp: Correct comment
2019-10-11 18:43:38 +02:00
98d96c3a2c
reorder_trayclients_cmp: Correct comment
2019-10-11 19:32:58 +03:00
8088c357e4
Merge pull request #3820 from orestisfl/deterministic_tray_icon_order
...
Deterministic tray icon order
2019-10-11 17:37:42 +02:00
eda814755a
Make tray icon order deterministic
...
Fixes #3573
2019-10-11 18:25:22 +03:00
d5a3b8af02
Introduce trayclient_and_output_from_window
...
Saves some code repetition
2019-10-11 16:12:48 +03:00
0b4d4e799b
Merge pull request #3817 from orestisfl/rect
...
Remove outdated comment from Rect
2019-10-09 16:12:40 +03:00
961f98eb15
Remove outdated comment from Rect
...
This has changed after #3787 .
The packed attribute was added in
75aac5bc02eec80838ab
2019-10-09 16:08:18 +03:00
736ac40b10
Merge pull request #3814 from orestisfl/net_active_fullscreen
...
handlers.c: new focus should not end up behind fullscreen
2019-10-09 13:25:38 +02:00
5e1094e994
Merge pull request #3815 from xzfc/3694-baf-rename
...
When renaming a workspace, update the previous_workspace_name too
2019-10-09 12:38:48 +03:00
ea216f88d8
Merge pull request #3559 from xzfc/3555-drag-threshold
...
Drag threshold
2019-10-09 12:38:30 +03:00
7e4eb51d23
When renaming a workspace, update the previous_workspace_name too
...
Fixes #3694
2019-10-09 08:09:24 +00:00
6f82d21c39
handlers.c: new focus should not end up behind fullscreen
...
This was raised here:
https://www.reddit.com/r/i3wm/comments/df18aa/popup_during_fullscreen_not_behaving_the_way_i/
With this commit, _NET_ACTIVE_WINDOW requests are more similar to
focusing with cmd_focus.
2019-10-09 02:38:40 +03:00
34c217acc8
Introduce con_activate_unblock
2019-10-09 02:31:52 +03:00
465447a96b
Merge pull request #3812 from xzfc/move-to-parent
...
Fix "move con to parent" trick
2019-10-08 11:54:40 +03:00
beb96ad18c
Move container to marked workspace: refine corner case
...
This commit should fix "move con to parent" trick (see below) in the
case when con->parent->parent is a workspace.
The trick:
mark _a, focus parent, focus parent, mark _b,
[con_mark=_a] move window to mark _b, [con_mark=_a] focus
The trick got broken in commit 626af81232#2003 ). Reverting said commit fixes the
trick. The crash is caused by the fact that empty workspace isn't
considered a split (checked in src/con.c:1324), so the moved window ends
up as a sibling of the target workspace, not as its child.
2019-10-07 18:15:03 +00:00
ba0868e593
Merge pull request #3728 from cdlscpmv/next
...
Add setting for minimal width of workspace buttons
2019-10-06 00:22:44 +02:00
371dc23101
Tiling resize drag: use threshold
2019-10-03 06:09:57 +00:00
c6b56b09ab
Floating move drag: use threshold
2019-10-03 06:09:57 +00:00
Orestis Floros