Commit Graph

2397 Commits

Author SHA1 Message Date
Michael Stapelberg 3721c598bd Bugfix: Set the cursor via the Xlib connection if XCursor is supported
This fixes a race where we created cursors on the Xlib connection, flushed,
then used the cursor on the XCB connection. Even though we flushed, the X
server did not process the requests yet and therefore returned a BadCursor
error.

This bugfix uses the Xlib connection for setting the root window cursor which
will ensure that the requests are properly serialized.

An easy test for this (on my machine) is the following ~/.xsession:
    xsetroot -cursor_name cross
    exec i3
If you see a cross cursor instead of the pointer, the race happens. You’ll see
a error_code=6 error in your ~/.xsession-errors.
2011-07-29 13:13:51 +02:00
Michael Stapelberg bc7dec6a4c X11 errors: also log the error_code (see X Protocol, Appendix B, Errors) 2011-07-29 13:11:02 +02:00
Fernando Tarlá Cardoso Lemos ae9c90ba19 Don't leak the cursor_id.
Fixes a server-side leak. The cursor_id is not needed when we're
using themed cursors (we never freed it either).
2011-07-29 12:38:44 +02:00
Fernando Tarlá Cardoso Lemos 7a18dcc89e Set the root window cursor. Fixes #442. 2011-07-29 12:38:24 +02:00
Michael Stapelberg 20c68b1869 docs/userguide: explain the split command 2011-07-29 01:12:19 +02:00
Michael Stapelberg 7e6aa72664 docs/userguide: explain default_orientation config directive 2011-07-29 01:12:06 +02:00
Michael Stapelberg 85b01df11b userguide: add popup_during_fullscreen configuration directive 2011-07-29 00:26:30 +02:00
Michael Stapelberg 8ef51a7cfa update docs/userguide (various little fixes/updates) 2011-07-28 22:51:48 +02:00
Michael Stapelberg ed30043950 Bugfix: Also abort drag_pointer after XCB_KEY_PRESS / XCB_KEY_RELEASE (Thanks eeemsi) 2011-07-28 21:01:34 +02:00
Michael Stapelberg 700f5bd443 docs/hacking-howto: a few little updates 2011-07-27 17:05:28 +02:00
Michael Stapelberg d1fae4c0f7 docs/hacking-howto: update for RandR instead of Xinerama 2011-07-27 16:37:19 +02:00
Michael Stapelberg e8335bbb89 docs/hacking-howto: update the file description 2011-07-27 16:32:24 +02:00
Michael Stapelberg 118a37510d docs/debugging: make the difference between logging and verbose logging more clear, little style fixes 2011-07-27 16:13:15 +02:00
Michael Stapelberg eea804cd94 migrate-config: convert old 'with container' commands to 'focus parent; $command' (+test) (Thanks Marcus) 2011-07-27 14:36:22 +02:00
Michael Stapelberg 2b940296a8 tests: t/17-workspace.t: keep workspace 1 open
When not running i3 in a terminal from workspace 1, this would fail otherwise
2011-07-27 14:35:40 +02:00
Michael Stapelberg 26c1a463db tests: keep an X11 connection open to every display, fixes races
Otherwise, i3 is the only client and thus the X server shuts down after i3
disconnects. Xdummy restarts an X server, but that takes some time and
therefore sometimes the next testcase was unable to connect.
2011-07-27 14:34:35 +02:00
Michael Stapelberg 86de02ca8c default config: start i3bar -d by default
like i3-migrate-config-to-v4.pl does it
2011-07-27 13:32:27 +02:00
Michael Stapelberg 0d77ca9a3d i3-nagbar: correctly check for errors when connecting to X11 2011-07-27 13:30:12 +02:00
Michael Stapelberg ec88f6501d i3-config-wizard: use a managed, floating (dialog) window. fixes focus problems
Probably only when another window is already opened, but people can do that
(start i3 from within a terminal in their X session)
2011-07-27 13:28:32 +02:00
Michael Stapelberg 2a43a49595 i3-config-wizard: correctly check for errors when connecting to X11 2011-07-27 13:05:40 +02:00
Michael Stapelberg f84264ae41 remove _NET_WM_WORKAREA from _NET_SUPPORTED for now
See ticket #301, this is a problem with Qt apps on your second monitor.

We should implement better EWMH support, but not before the release :).
2011-07-27 12:51:38 +02:00
Michael Stapelberg 44be907197 add Xdummy script to start a headless X11 server 2011-07-25 15:37:46 +02:00
Michael Stapelberg 4dde5bb863 testsuite: allow parallel runs. decreases the test time by 60% when using 4 displays 2011-07-25 15:37:13 +02:00
Michael Stapelberg 49ea805905 tests: get the socket path from the X11 atom I3_SOCKET_PATH
The hard-coded socket paths are not useful when running the test suite in
parallel.
2011-07-25 13:35:56 +02:00
Michael Stapelberg 18513e1638 x.c: fix warning by removing unused variable 2011-07-25 00:32:14 +02:00
Michael Stapelberg 7a7764a0d9 handlers.c: fix warnings 2011-07-25 00:32:03 +02:00
Michael Stapelberg e124241e72 i3-nagbar: fix warnings 2011-07-25 00:31:51 +02:00
Michael Stapelberg 6a07e08320 makefiles: build subdirs (Thanks Kacper) 2011-07-25 00:31:35 +02:00
Michael Stapelberg 1a3f4c2f7d extend .gitignore 2011-07-25 00:25:42 +02:00
Michael Stapelberg 50f97b8bd7 debian: add missing τεχ build dependencies for the refcard 2011-07-24 22:57:55 +02:00
Michael Stapelberg 8c18121a11 docs/makefile: correctly make 'clean' 2011-07-24 22:43:50 +02:00
Michael Stapelberg a03c63dc39 use the window class Firefox instead of the debian-specific Iceweasel 2011-07-24 22:17:31 +02:00
Michael Stapelberg 4fe870c927 define prototype for xcb_get_numlock_mask (fixes warning) 2011-07-24 22:16:40 +02:00
Michael Stapelberg 4099b4302b i3-config-wizard: fix keypresses with numlock on, also accept keypad enter (Thanks mxf) 2011-07-24 22:14:12 +02:00
Michael Stapelberg 8994c45495 release-notes: few fixes by fernando, thanks 2011-07-24 22:06:53 +02:00
Michael Stapelberg 3bed119d9e add release notes for 4.0 (no, we’re still not releasing yet) 2011-07-24 21:33:54 +02:00
Michael Stapelberg 797ba5f7c8 remove unnecessary close, because fclose already closes the file descriptor 2011-07-24 18:42:46 +02:00
Michael Stapelberg 8c20fea3c2 docs/ipc: document the tree request / reply 2011-07-24 15:02:39 +02:00
Michael Stapelberg 34eb9b2664 ipc: make 'focused' a bool 2011-07-24 15:00:09 +02:00
Michael Stapelberg b09bb0fc2a ipc: make 'urgent' a bool 2011-07-24 14:54:30 +02:00
Michael Stapelberg 36fde6dbe1 ipc: send 'percent': null when percent is not relevant for the container 2011-07-24 14:47:28 +02:00
Michael Stapelberg f0aa52f674 docs/ipc: update socket path section 2011-07-24 14:39:15 +02:00
Michael Stapelberg c2f8a0efee bump version number (no, we’re not releasing yet) 2011-07-24 00:14:26 +02:00
Michael Stapelberg 3821b9e841 update PACKAGE-MAINTAINER, mention i3-migrate-config-to-v4.pl and i3-config-wizard 2011-07-24 00:08:46 +02:00
Michael Stapelberg 6cb7ef6deb update DEPENDS file 2011-07-23 23:53:31 +02:00
Michael Stapelberg a05a9f8dae Set some more atoms for _NET_SUPPORTED (Thanks lexszero) 2011-07-23 22:40:47 +02:00
Michael Stapelberg 3f7c7c2e38 remove left-over wordexp.h include 2011-07-23 22:37:41 +02:00
Michael Stapelberg a21155e24c update debian/ to include all documentation/bump standars version
Conflicts:

	debian/control
2011-07-23 22:32:16 +02:00
Michael Stapelberg ffe297f5e5 Bugfix: use the global root variable, don’t get the first one (Thanks quaec) 2011-07-23 22:29:01 +02:00
Michael Stapelberg 44f46a5ee6 Makefile: don’t set PREFIX/SYSCONFDIR (necessary for OpenBSD ports framework) (Thanks madroach) 2011-07-23 22:24:23 +02:00