07dfb8450b
Fix typo: childs -> children
2018-10-13 21:10:11 +03:00
204eefc679
floating_reposition: avoid extra tree_render
2018-10-13 21:10:11 +03:00
8c17e4e38d
manage_window: cleaner variable declarations
2018-10-13 21:10:10 +03:00
966915cfb2
borders_to_hide doesn't need to be initialized
2018-10-13 21:10:10 +03:00
4219eb213b
root is externally declared
2018-10-13 21:10:10 +03:00
e4d2b38552
Make comment style more consistent
2018-10-13 21:10:10 +03:00
a65914f338
Fix missing prototypes
...
i3 will now compile with no warnings when -Wmissing-prototypes is used.
2018-10-13 21:10:10 +03:00
2a9522dda4
Enforce strict prototypes
...
i3 will now compile with no warnings when -Wstrict-prototypes is used.
2018-10-13 21:10:09 +03:00
a15fff2370
Use path_exists
2018-10-13 21:10:09 +03:00
50880db2c5
Reduce some code around frees
2018-10-13 21:10:09 +03:00
18dbfe699a
userguide: Mention know issues for assign ( #3434 )
...
Fixes #3222
Fixes #3293
Related to #2060
2018-10-07 20:24:09 +02:00
0ede8b9365
Correctly calculate max_aspect
2018-09-28 17:34:18 -07:00
ebf40889a1
Merge pull request #3424 from orestisf1993/con_num_windows
...
con_num_windows: Count floating windows
2018-09-28 09:27:58 +02:00
5e1d327e43
con_num_windows: Count floating windows
...
Fixes #3423 .
2018-09-26 20:04:17 +03:00
6877205ac1
Reject requests for WM_STATE_ICONIC
...
For compatiblity reasons, Wine will request iconic state and cannot
ensure that the WM has agreed on it; immediately revert to normal to
avoid being stuck in a paused state.
2018-09-25 15:04:55 +03:00
7c21b5995d
Merge pull request #3400 from Synray/next
...
Respect max size from WM_NORMAL_HINTS
2018-09-20 11:36:22 +03:00
690e6d1f0e
Respect max size in WM_NORMAL_HINTS
2018-09-20 11:31:19 +03:00
515dd45f59
match_matches_window: Check if focused->window exists
...
Fixes #3406 .
2018-09-16 14:55:27 +03:00
d407393d0d
_con_move_to_con: Move upwards only on CT_FLOATING_CON
...
If target is inside a floating container but not its direct child, the
move can be completed as is.
Fixes #3402 .
2018-09-14 16:13:41 +03:00
ede954128a
Merge pull request #3342 from orestisf1993/tree_close_internal
...
Simplify tree_close_internal
2018-09-14 12:24:54 +02:00
e67be1ccd3
commands.c: Improve error replies
...
- Improve / add various error messages.
- Replace all `LOG(…); ysuccess(false);` with `yerror(…);`.
- switch_mode: Remove redundant "ERROR:" ELOG string.
- cmd_move_con_to_workspace*: Make sure that we don't try to move an
empty workspace to another workspace. This can be problematic when we
match a workspace using command criteria (eg marks) and the target is a
non-existing workspace. We create the new workspace but since nothing is
moved there, we are left with an empty workspace. See added testcase.
2018-09-11 08:35:58 +03:00
6a1f653508
libi3: validate UTF8 strings
...
Will validate container / window titles.
Fixes #3156 .
2018-09-10 02:00:32 +03:00
a3dcee35f3
tree_restore: Check croot
...
Related to #2414 , #3156 .
2018-09-09 16:11:48 +03:00
be6faa3161
tree_append_json: Allow strings that are not valid UTF8
...
Fixes #3156 .
I couldn't reproduce the problem in a "natural" way so I cheated:
1. Start i3 with gdb
2. Set breakpoing on tree_restore
3. Run, open window, i3-msg restart
5. Open the file in *path with a hex editor
6. Edit the "name" field of the window and insert bytes that are not
valid UTF8
7. Continue
After parsing fails, all nodes including croot are incomplete, meaning
they have to be deleted. We can't recover in any reasonable way so we
have to allow non-UTF8 characters to avoid this situation altogether.
2018-09-06 14:58:31 +03:00
e8d2b9b7b5
tree_append_json: don't focus freed container
2018-09-06 14:48:21 +03:00
cb6da7169a
Merge pull request #3389 from orestisf1993/resize-ensure-1px
...
Ensure containers have a size of at least 1px after resize
2018-09-06 08:41:00 +02:00
9edb7c7a3b
Merge pull request #3390 from orestisf1993/resize-tile
...
resize set for tiling: default to px when not specified
2018-09-06 08:38:53 +02:00
64142eeef2
resize set for tiling: default to px when not specified
2018-09-06 05:58:51 +03:00
23c1c13d34
Ensure containers have a size of at least 1px after resize
...
Fixes #2226 .
Fixes #2776 .
Fixes #3241 .
Related to #3194 .
2018-09-06 04:56:31 +03:00
6846ac98c0
cmd_rename_workspace: correct order of events
...
1. Rename happens
2. Workspace is moved because of assignments
3. Workspace closes because it is empty (#3248 )
Fixes #3248 .
2018-09-06 03:42:07 +03:00
9595263142
Merge pull request #3376 from orestisf1993/floating-disable-scratchpad
...
Don't disable floating in internal workspaces
2018-08-28 13:30:57 +02:00
9718e38a7a
Don't disable floating in internal workspaces
2018-08-28 11:26:20 +03:00
37b879f4ad
ipc_client_timeout: Fix build when not on linux
...
Also moved the 'end' label because it is unused otherwise.
Reported here: https://github.com/Airblader/i3/issues/233
2018-08-27 22:21:59 +03:00
4cba9fcbda
Merge pull request #3368 from orestisf1993/render_root
...
(floating) global fullscreen bugs & others
2018-08-24 09:49:41 +02:00
096cff0aad
Make resize set ppt more accurate
...
See the testcase for the usecase.
2018-08-24 04:13:25 +03:00
51d230ad4c
Make resize set px work with tiling containers
2018-08-24 04:13:25 +03:00
423e20b960
cmd_resize* statics: remove useless 'way' argument
2018-08-24 04:13:25 +03:00
26bbaf6237
Make cmd_resize_tiling_width_height work with pixels
2018-08-24 04:13:25 +03:00
2ead7745d6
Make cmd_resize_tiling_direction work with pixels
...
Introduces resize_neighboring_cons in resize.c which is also used by
resize_graphical_handler.
Co-authored-by: Andrew Laucius <andrewla@gmail.com>
Authored original code and tests in #3240 . I rewrote most of the
resizing code and fixed the failing tests.
2018-08-24 04:13:03 +03:00
ea43507bed
precalculate_sizes: don't malloc needlessly
2018-08-24 04:12:24 +03:00
7b9318a541
precalculate_sizes: round sizes instead of flooring them
...
This will lead to more accurate and consistent container sizes.
Needed to fix the failing test of #3240 .
2018-08-24 04:12:14 +03:00
db294f4505
Improve resize_graphical_handler code style
...
- int return type is not useful
- Consistent comment style
2018-08-23 22:04:22 +03:00
9522b46f1b
Introduce parse_direction
...
Also fixes the following bug: in the fix for #1011 in
cmd_resize_floating direction "width" is not considered.
Influenced by #3240 .
2018-08-23 15:45:24 +03:00
6e1b79e057
Introduce orientation_from_direction
2018-08-23 15:36:23 +03:00
e6202d43f5
Apply compatible changes from clang-format 6.0.1
...
These are the changes that clang-format 6.0.1 makes to the codebase that
clang-format-3.8 doesn't change back.
Useful for those that use a more recent version of clang-format in their
local machines.
2018-08-22 14:51:17 +03:00
e1a83d057f
handle_configure_request: check for scratchpad once
2018-08-22 14:23:01 +03:00
9190a9ab70
handle_configure_request: use 'goto out'
2018-08-22 14:11:26 +03:00
9ae84593ba
handle_configure_request: reuse 'workspace' variable
2018-08-22 14:10:42 +03:00
0ac75bea5a
con_border_style: check con->fullscreen_mode directly
2018-08-22 14:09:05 +03:00
efc78de4ee
Introduce con_get_fullscreen_covering_ws
...
This commit will also fix the following bugs:
1. click.c: Users could drag global fullscreen floating containers.
2. render.c: Floating containers would get rendered with a global fullscreen container in another
workspace.
2018-08-22 14:05:50 +03:00
Orestis Floros