nixo
/
gri3-wm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
6,338 Commits 1 Branch 0 Tags 14 MiB
Commit Graph

6338 Commits

Author SHA1 Message Date
Michael Stapelberg b850cfba4d Fix memleaks by avoiding _checked variants when discarding the result 
Thanks psychon for pointing this out in
https://github.com/i3/i3/pull/2450#discussion_r78560433!
 2016-09-14 09:22:45 +02:00
Michael Stapelberg 5594139676 Eliminate once-used check_error utility function 2016-09-14 09:19:25 +02:00
Ingo Bürk d48c9b1e33 Fix colormap handling for containers. (#2450) 
This commit correctly handles colormaps by

* Using the static default colormap we determine on startup if the
  con has the corresponding depth. This avoids creating pointless
  colormaps.
* Not freeing the default colormap to not have stray colormaps on
  containers. This fixes an issue with certain programs such as xwd.
* Creating a custom colormap when necessary and freeing it when the
  container is killed.

fixes #2435
 2016-09-14 09:13:17 +02:00
Michael Stapelberg 555f458d7a Bugfix: don’t apply shift+numlock fallback for keypad keys 
fixes #2418
 2016-09-12 22:24:23 +02:00
Michael Stapelberg 4765a8fb84 Merge branch 'nmschulte-fix_numlock_shift' into next 2016-09-12 22:23:10 +02:00
Nathan Schulte 41ce596a94 fix bindsyms with Shift, given NumLock tweaks 2016-09-12 22:22:59 +02:00
Nathan Schulte 02f206d816 fix typo in logging message 2016-09-12 22:22:59 +02:00
Michael Stapelberg 2244c843a8 Bugfix: don’t trigger unrelated key bindings for --release bindings 
fixes #2442
 2016-09-12 12:57:13 +02:00
Michael Stapelberg b00d36fca5 t/264-keypress-numlock: add a test covering shift 
related to #2418
 2016-09-12 12:10:59 +02:00
Michael Stapelberg 0469716fd6 Bugfix: compare all resolved modifier masks 
Before this commit, i3 only compared the user-specified modifiers and
incorrectly ignored the resolved modifiers (such as the numlock
fallback).

While at it, also fix the testcase which treated numlock as a momentary
modifier, whereas it really is a latched modifier.

fixes #2418
 2016-09-12 12:05:38 +02:00
Michael Stapelberg 5ca7d4b222 expose binding pointer in debug messages 
This makes it a bit easier to match up the different messages to the
configured binding.
 2016-09-12 12:03:30 +02:00
Michael Stapelberg 59c070bffc travis: pass through CC to run-tests 
fixes #2437
 2016-09-05 09:01:41 +02:00
Michael Stapelberg 086276b329 travis: only enable asan workaround for clang (breaks gcc) 
fixes #2437
 2016-09-05 08:55:40 +02:00
Michael Stapelberg 6584f70d28 travis: work around asan broken-ness with libc ≥ 2.24 
fixes #2437
 2016-09-05 08:42:34 +02:00
Michael Stapelberg f62eb9f533 Bugfix: re-add single quotes around I3_VERSION 
Without single quotes, the version is not passed correctly to the
compiler, and building Debian packages fails.

related to #2437
 2016-09-05 08:19:02 +02:00
Michael Stapelberg fac57699b4 Bugfix: avoid setting urgency hint on content container and above 
fixes #2098 (I _think_)
 2016-09-04 21:08:21 +02:00
Michael Stapelberg 18183b8407 Merge pull request #2393 from bebehei/fix-workspace-next_prev 
fix #2383 for numbered workspaces
 2016-08-28 18:28:25 +02:00
Benedikt Heine 7a94dfd11d add additional reversed testcase 2016-08-24 11:11:50 +02:00
Benedikt Heine e35aff5cb9 fix transition from named to numbered workspace 2016-08-24 11:11:50 +02:00
Benedikt Heine 930733f352 enhance test 528 
Enhancing test 528 to test workspace_next and workspace_prev
- Adding tests for worksace_prev
- Mixing workspace distribution over outputs
 2016-08-24 11:11:50 +02:00
Benedikt Heine 5d6d974c66 remove goto statement 
remove goto statement to similarize workspace_next and workspace_prev
 2016-08-24 11:11:50 +02:00
Benedikt Heine d979748853 traverse numbered workspaces in correct order 2016-08-24 11:11:50 +02:00
eplanet b668d62cfc Deleting VERSION and extracting it from I3_VERSION instead (#2419) 2016-08-13 13:46:27 -07:00
Michael Stapelberg 012de8cd6f Merge pull request #2301 from EvilPudding/next 
Minor optimization
 2016-08-03 18:43:35 +02:00
EvilPudding 96704b2fc0 Leaving the last byte in Colorpixel.hex NULL 
Added explicit assignment of last byte to the null character, for
appearence's sake.
 2016-08-03 13:09:58 +00:00
EvilPudding 08c2380545 Hex in struct Colorpixel.hex to contiguous memory 
No reason for hex not to be of a constant size, and
no reason to introduce a cache miss by allocating it
separated from the rest of the structure.
 2016-08-03 13:09:58 +00:00
Michael Stapelberg d77d40173a Only add NumLock fallback where necessary. 
Previously, we always discarded the NumLock bit when looking up key
bindings for key press events, and we always grabbed every keycode with
and without the NumLock modifier.

With this commit, the NumLock bit is no longer discarded: since the
previous commit 3bd5e6e5c8 we can
correctly look up key bindings with/without the NumLock bit, as both
variants are stored in |keycodes_head|.

Further, before adding the NumLock fallback (resulting in grabbing the
keycode with the NumLock modifier), we now check whether the key has the
same meaning when NumLock is enabled. This correctly distinguishes the
KP_End vs. KP_1 case, i.e. one can now use the following key bindings:

    # No longer accidentally triggered when pressing KP_1.
    bindsym KP_End nop KP_End

    # Properly distinguished now:
    bindsym KP_End nop KP_End
    bindsym Mod2+KP_1 nop KP_1

fixes #2346
 2016-08-02 20:34:20 +02:00
Michael Stapelberg 3bd5e6e5c8 refactoring: store modifiers alongside translated keycodes 
This is a no-op refactoring in terms of functionality.

related to #2346
 2016-08-02 20:10:49 +02:00
Michael Stapelberg 0239c4b6da move xkb_current_group check into own function 
This is a no-op refactoring.
 2016-08-02 19:33:26 +02:00
Michael Stapelberg afb90a0f97 remove superfluous check for input_type 
This condition is already enforced in grab_all_keys().
 2016-08-02 19:31:23 +02:00
Denton Liu 85bb32409f Update manpages (#2404) 2016-07-30 19:30:25 +02:00
Denton Liu bccd702e85 Add uxterm to terminal list (#2397) 2016-07-19 19:28:42 +01:00
yshui 3ffa88e54a Don't change border style if BS_NORMAL is requested in motif hints (#2386) 
Fixes #2385
 2016-06-25 21:35:36 +02:00
yshui 45012189bc Handle _MOTIF_WM_HINTS changes (#2384) 2016-06-22 08:39:25 +02:00
Ingo Bürk b1d70f25b3 Introduced a new GET_BINDING_MODES message type and reply. (#2376) 
This type dumps all currently configured binding modes.

fixes #2375
 2016-06-15 22:25:22 +02:00
Michael Stapelberg 63d0823016 Merge pull request #2350 from madroach/OpenBSD 
Fix building and testing on OpenBSD
 2016-06-15 20:19:16 +02:00
Christopher Zimmermann 1322af1e4f Don't use pthread on OpenBSD 
since OpenBSD pthread does not support pthread_condattr_setpshared().
This patch could also stay in the OpenBSD ports tree or depend on a
configure test macro rather than defined __OpenBSD__.
 2016-06-11 14:47:26 +02:00
Christopher Zimmermann 87e90229bc Always use socket activation 
it neither depends on systemd nor on any linuxism.
 2016-06-11 14:47:23 +02:00
Christopher Zimmermann fa12f67870 Fix testsuite on OpenBSD 
OpenBSD perl forks for glob().
Therefore attach SIGCHLD handler as late as possible.
 2016-06-11 14:47:17 +02:00
Christopher Zimmermann 7e2483edf7 Use 64 bit time_t 2016-06-11 12:58:16 +02:00
Ingo Bürk 18d6a1bc76 Explicitly terminate fallback in set_from_resource. (#2366) 2016-05-31 22:58:23 +02:00
Zamarin Arthur 82dd59cb31 Added qterminal to i3-sensible-terminal (#2367) 2016-05-31 22:57:58 +02:00
Trevor Merrifield 54cacd58ff Fix outdated documentation (#2362) 2016-05-28 16:44:20 +02:00
Michael Stapelberg 460e33a847 travis: ubuntu: install libxcb-xrm from our repository 
see #2363
 2016-05-26 14:53:30 +02:00
Michael Stapelberg ef0a5b0534 travis: remove libxcb-xrm-dev from build-deps before dpkg-buildpackage 2016-05-25 08:23:45 +02:00
Michael Stapelberg 8e125e9845 travis: ubuntu: install libtool 2016-05-25 07:49:14 +02:00
Michael Stapelberg 57dc46b4ec travis: ubuntu: also install autotools-dev and automake 2016-05-24 22:39:18 +02:00
Michael Stapelberg d08b0c428b travis: ubuntu: install autoconf (for autoreconf) 2016-05-24 22:04:26 +02:00
Michael Stapelberg a24a048cc9 travis: ubuntu: install ca-certificates to make git clone work 2016-05-24 20:21:08 +02:00
Michael Stapelberg 8dbdcde9a6 travis: ubuntu: remove libxcb-xrm-dev from Build-Deps 
It’s installed separately.

This should fix the failing travis build.
 2016-05-24 20:07:01 +02:00