Commit Graph

38 Commits

Author SHA1 Message Date
shdown f8d8acd93c i3-msg: strdup getenv() result before freeing
Fixes #1852.
2015-09-08 09:13:26 +02:00
Michael Stapelberg 9200094203 format **/*.c with clang-format-3.5
This has multiple effects:

1) The i3 codebase is now consistently formatted. clang-format uncovered
   plenty of places where inconsistent code made it into our code base.

2) When writing code, you don’t need to think or worry about our coding
   style. Write it in yours, then run clang-format-3.5

3) When submitting patches, we don’t need to argue about coding style.

The basic idea is that we don’t want to care about _how_ we write the
code, but _what_ it does :). The coding style that we use is defined in
the .clang-format config file and is based on the google style, but
adapted in such a way that the number of modifications to the i3 code
base is minimal.
2014-06-15 19:07:02 +02:00
Tony Crisci 13db562551 Remove yajl major version conditionals
Yajl version ≥ 2 is required.

fixes #1156
2014-05-04 22:52:37 +02:00
Alexander Kedrik de3901bb29 use designated initializers for yajl_callbacks struct 2014-01-06 22:12:14 +01:00
Michael Stapelberg 2fea5ef82b Revert "use designated initializers for yajl_callbacks struct"
This reverts commit 705b43294a.

This commit broke i3bar for some users.
2014-01-05 13:05:31 +01:00
Alexander Kedrik 705b43294a use designated initializers for yajl_callbacks struct 2014-01-04 20:46:46 +01:00
Peter Boström 9c15b9504e Fix clang -Wextra except -Wunused-parameter.
Cleared all warnings that occur when passing
CFLAGS="-Wall -Wextra -Wno-unused-parameter" to make using clang 3.3 on
Linux x86-64.
2014-01-02 22:15:33 +01:00
Michael Stapelberg d3beff2339 make i3bar use libi3’s root_atom_contents()
This removes code duplication, which will be useful for a subsequent
commit.

Furthermore, we now don’t open X11 connections unnecessarily in some
corner cases.
2013-11-22 15:48:45 +01:00
Michael Stapelberg c300d216ec i3-msg: parse command replies and display errors nicely if there were errors
fixes #737
2013-01-26 17:56:43 +01:00
Michael Stapelberg dcb8ac84f8 ipc_recv_message: store message_type, don’t compare. add distinct EOF retval
Also use ELOG, which requires i3-msg to provide logging functions.
2013-01-23 18:51:39 +01:00
Michael Stapelberg e8fa3eeebd i3-msg: include socket path in error message 2013-01-23 08:11:27 +01:00
Oliver Kiddle f7d825062a remove superfluous ev.h include statements 2012-09-20 11:15:17 +02:00
Michael Stapelberg 78f5f2204d ipc: implement GET_VERSION to find out the i3 version
This is useful for third-party scripts which require certain features
and want to error out cleanly when they are run with an old i3 version.

Additionally, i3 --version might be different from what’s actually
running (an old version of the binary), so i3-msg -t get_version will be
the best way to figure out the i3 version you are actually running from
this commit on.
2012-08-05 14:30:05 +02:00
Michael Stapelberg dee7c07ad2 shmlog: store meta information in the buffer itself, store path as X11 atom
This makes i3-dump-log completely independent of a running i3 instance.
2012-01-06 23:40:07 +00:00
Michael Stapelberg d25a05f06b add TYPE_GET_LOG_MARKERS to i3-msg 2011-12-10 11:16:12 +00:00
Michael Stapelberg 726f2a1e5a normalize file headers across **/*.{h,c} 2011-10-25 21:19:38 +01:00
Michael Stapelberg 24ede1c834 add an IPC request to get the bar configuration (by ID) 2011-10-18 19:05:49 +01:00
Michael Stapelberg 046cf99585 Move ipc_send_message and ipc_recv_message to libi3
Make i3-msg and src/ipc.c use it
2011-10-02 18:33:36 +01:00
Michael Stapelberg ff86852453 i3-msg: use smalloc, sstrdup from libi3 2011-10-02 18:11:01 +01:00
Michael Stapelberg 6af8b0941c i3-msg: use socket_path_from_x11 from libi3 2011-10-02 16:11:55 +01:00
Michael Stapelberg 32ad9f7e3a i3-msg: include newline at the end of the reply 2011-09-05 22:55:31 +02:00
Helgi Kristvin Sigurbjarnarson 96ed68de16 Add support for get_marks in i3-msg 2011-08-09 08:19:11 +02:00
Michael Stapelberg fdd098b010 secure strscpy by replacing with strncpy 2011-07-23 22:22:36 +02:00
Michael Stapelberg 5c276be3d5 i3-msg: concatenate all arguments. now you can use i3-msg mark foo 2011-07-13 18:01:24 +02:00
Michael Stapelberg ba7e82fc94 i3-msg: re-indent main.c 2011-07-13 17:53:07 +02:00
Michael Stapelberg 307a036d5c i3-msg, i3-input: get the I3_SOCKET_PATH atoms if socket path was not specified 2011-03-19 21:23:55 +01:00
Michael Stapelberg d9dd245bcc Bugfix: Use strdup() for the initial value of socket_path (Thanks mseed) 2011-01-22 17:00:27 +01:00
Axel Wagner 4caf85aa0b Use I3SOCK-environment-variable 2011-01-12 10:15:48 +01:00
Michael Stapelberg cd2ee61ee8 fix some memory leaks when user passes command line arguments twice (Thanks Tiago) 2011-01-12 10:12:24 +01:00
Michael Stapelberg 0f083f6f78 i3-msg: s/tree/get_tree for consistency, add new types to error message 2010-11-21 21:39:09 +01:00
Fernando Tarlá Cardoso Lemos c0cd756b0f Support get_workspaces and get_outputs in i3-msg. 2010-11-21 21:36:25 +01:00
Michael Stapelberg c145f7e529 first step of the big refactoring ("tree" branch).
From here on, we can track changes. It made no sense to put the
development up to this point into git.
2010-04-13 13:17:39 +02:00
Michael Stapelberg f7a1a9fb20 ipc: correctly shutdown IPC sockets when exiting/restarting 2010-03-16 02:44:47 +01:00
Michael Stapelberg 95666d007e i3-msg: Initialize message_type (Thanks badboy) 2010-03-12 15:45:36 +01:00
Michael Stapelberg 77fe1f29b0 i3-msg: read replies, implement get_workspaces command 2010-03-12 15:30:09 +01:00
Michael Stapelberg 13c481c9f5 i3-msg: Fix compilation warning (Thanks mxf) 2009-08-05 14:38:55 +02:00
Michael Stapelberg c56dc0f966 i3-msg: more error handling, more comments 2009-07-28 21:29:23 +02:00
Michael Stapelberg ec9b58ada9 Add i3-msg, a sample implementation and hopefully useful utility 2009-07-28 21:26:36 +02:00