c0f685e7bc
If I restart i3 4.10.2 twice, e.g. with $ i3-msg restart; sleep 3; i3-msg restart the second time I get the following two errors: 05/22/15 10:46:03 - ERROR: mkdir(/tmp/i3-theo.toAK7N) failed: File exists 05/22/15 10:46:03 - ERROR: Could not create "/tmp/i3-theo.toAK7N" for storing the restart layout, layout will be lost. The first one is from mkdirp() in src/ipc.c and the second one is from store_restart_layout() in src/util.c. Notice that I do _not_ get the ``open()'' or ``Could not write restart layout to ...'' error messages, so the layout writing code after line 260 in store_restart_layout() succeeded and the layout isn't actually lost. Thus, these error messages are a bit misleading, especially the second one (which is triggered by the failure of mkdirp()). POSIX says about `mkdir -p': ``Each dir operand that names an existing directory shall be ignored without error.'' Therefore, I suggest the following simple patch that makes mkdirp() succeed if the named file exists and actually is a directory. This silences the second error as well. |
||
|---|---|---|
| .. | ||
| Makefile | ||
| README | ||
| dpi.c | ||
| fake_configure_notify.c | ||
| font.c | ||
| get_colorpixel.c | ||
| get_exe_path.c | ||
| get_mod_mask.c | ||
| get_process_filename.c | ||
| get_visualtype.c | ||
| ipc_connect.c | ||
| ipc_recv_message.c | ||
| ipc_send_message.c | ||
| is_debug_build.c | ||
| libi3.mk | ||
| mkdirp.c | ||
| root_atom_contents.c | ||
| safewrappers.c | ||
| string.c | ||
| strndup.c | ||
| ucs2_conversion.c | ||
README
Introduction ============ libi3 is an *INTERNAL* library which contains functions that i3 and related tools (i3-msg, i3-input, i3-nagbar, i3-config-wizard, i3bar) use. It is NOT to be used by other programs. Structure ========= Every function gets its own .c file, which in turn gets compiled into an .o object file. Afterwards, all .o files are archived into one static library (libi3.a). This library will be linked into all i3 binaries. The linker is able to eliminate unused .o files when linking, so only the functions which you actually use will be included in the corresponding binary.