gnu: node: Do not use bundled dependencies.

The Node build system was previously building its own copies of
OpenSSL (yikes!), libuv, and zlib.

* gnu/packages/node.scm (node)[inputs]: Add openssl, libuv, and zlib.
  [arguments]: Add configure flags for using system libraries.  Use
  'modify-phases' syntax.
This commit is contained in:
David Thompson 2015-12-07 16:59:34 -05:00
parent 437d728632
commit 1eca745b44
1 changed files with 44 additions and 36 deletions

View File

@ -1,6 +1,7 @@
;;; GNU Guix --- Functional package management for GNU ;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2014 Cyrill Schenkel <cyrill.schenkel@gmail.com> ;;; Copyright © 2014 Cyrill Schenkel <cyrill.schenkel@gmail.com>
;;; Copyright © 2015 Andreas Enge <andreas@enge.fr> ;;; Copyright © 2015 Andreas Enge <andreas@enge.fr>
;;; Copyright © 2015 David Thompson <davet@gnu.org>
;;; ;;;
;;; This file is part of GNU Guix. ;;; This file is part of GNU Guix.
;;; ;;;
@ -18,18 +19,19 @@
;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>. ;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
(define-module (gnu packages node) (define-module (gnu packages node)
#:use-module ((guix licenses) #:use-module ((guix licenses) #:select (expat))
#:select (expat))
#:use-module (gnu packages)
#:use-module (gnu packages perl)
#:use-module (gnu packages python)
#:use-module (gnu packages gcc)
#:use-module (gnu packages linux)
#:use-module (gnu packages base)
#:use-module (guix packages) #:use-module (guix packages)
#:use-module (guix derivations) #:use-module (guix derivations)
#:use-module (guix download) #:use-module (guix download)
#:use-module (guix build-system gnu)) #:use-module (guix build-system gnu)
#:use-module (gnu packages base)
#:use-module (gnu packages compression)
#:use-module (gnu packages gcc)
#:use-module (gnu packages libevent)
#:use-module (gnu packages linux)
#:use-module (gnu packages perl)
#:use-module (gnu packages python)
#:use-module (gnu packages tls))
(define-public node (define-public node
(package (package
@ -42,23 +44,20 @@
(sha256 (sha256
(base32 (base32
"17gk29zbw58l0sjjfw86acp39pkiblnq0gsq1jdrd70w0pgn8gdj")))) "17gk29zbw58l0sjjfw86acp39pkiblnq0gsq1jdrd70w0pgn8gdj"))))
(native-inputs `(("python" ,python-2)
("perl" ,perl)
("gcc" ,gcc-4.9)
("util-linux" ,util-linux)
("which" ,which)))
(build-system gnu-build-system) (build-system gnu-build-system)
(arguments (arguments
`(#:phases ;; TODO: Package http_parser and add --shared-http-parser.
(alist-replace '(#:configure-flags '("--shared-openssl" "--shared-zlib" "--shared-libuv")
'configure #:phases
(modify-phases %standard-phases
(replace 'configure
;; Node's configure script is actually a python script, so we can't ;; Node's configure script is actually a python script, so we can't
;; run it with bash. ;; run it with bash.
(lambda* (#:key outputs (configure-flags '()) inputs (lambda* (#:key outputs (configure-flags '()) inputs
#:allow-other-keys) #:allow-other-keys)
(let* ((prefix (assoc-ref outputs "out")) (let* ((prefix (assoc-ref outputs "out"))
(flags `(,(string-append "--prefix=" prefix) (flags (cons (string-append "--prefix=" prefix)
,@configure-flags))) configure-flags)))
(format #t "build directory: ~s~%" (getcwd)) (format #t "build directory: ~s~%" (getcwd))
(format #t "configure flags: ~s~%" flags) (format #t "configure flags: ~s~%" flags)
;; Node's configure script expects the CC environment variable to ;; Node's configure script expects the CC environment variable to
@ -67,13 +66,22 @@
(zero? (apply system* (zero? (apply system*
(string-append (assoc-ref inputs "python") (string-append (assoc-ref inputs "python")
"/bin/python") "/bin/python")
"./configure" flags)))) "./configure" flags))))))))
%standard-phases))) (native-inputs
`(("python" ,python-2)
("perl" ,perl)
("gcc" ,gcc-4.9)
("util-linux" ,util-linux)
("which" ,which)))
(inputs
`(("libuv" ,libuv)
("openssl" ,openssl)
("zlib" ,zlib)))
(synopsis "Evented I/O for V8 JavaScript") (synopsis "Evented I/O for V8 JavaScript")
(description "Node.js is a platform built on Chrome's JavaScript runtime (description "Node.js is a platform built on Chrome's JavaScript runtime
for easily building fast, scalable network applications. Node.js uses an for easily building fast, scalable network applications. Node.js uses an
event-driven, non-blocking I/O model that makes it lightweight and efficient, event-driven, non-blocking I/O model that makes it lightweight and efficient,
perfect for data-intensive real-time applications that run across distributed perfect for data-intensive real-time applications that run across distributed
devices.") devices.")
(license expat) (home-page "http://nodejs.org/")
(home-page "http://nodejs.org/"))) (license expat)))