nixo
/
guix-devel
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

build: Warn against long hash bang lines for tests. 

* m4/guix.m4 (GUIX_TEST_HASH_BANG_LENGTH): New macro.
(GUIX_CHECK_FILE_NAME_LIMITS): Use it.  Warn against long hash bang
lines in tests.
This commit is contained in:
Ludovic Courtès 2016-01-12 16:08:19 +01:00
parent d33fa0c714
commit 27ab3cee75
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
m4/guix.m4
View File

@ -1,5 +1,5 @@
dnl GNU Guix --- Functional package management for GNU dnl GNU Guix --- Functional package management for GNU
dnl Copyright © 2012, 2013, 2014, 2015 Ludovic Courtès <ludo@gnu.org> dnl Copyright © 2012, 2013, 2014, 2015, 2016 Ludovic Courtès <ludo@gnu.org>
dnl Copyright © 2014 Mark H Weaver <mhw@netris.org> dnl Copyright © 2014 Mark H Weaver <mhw@netris.org>
dnl dnl
dnl This file is part of GNU Guix. dnl This file is part of GNU Guix.
@ -204,6 +204,14 @@ AC_DEFUN([GUIX_HASH_BANG_LENGTH], [
[ac_cv_guix_hash_bang_length=`echo -n "$storedir/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-bootstrap-binaries-0/bin/bash" | wc -c`]) [ac_cv_guix_hash_bang_length=`echo -n "$storedir/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-bootstrap-binaries-0/bin/bash" | wc -c`])
]) ])
dnl GUIX_TEST_HASH_BANG_LENGTH
AC_DEFUN([GUIX_TEST_HASH_BANG_LENGTH], [
AC_REQUIRE([GUIX_TEST_ROOT_DIRECTORY])
AC_CACHE_CHECK([the length of a hash bang line used in tests],
[ac_cv_guix_test_hash_bang_length],
[ac_cv_guix_test_hash_bang_length=`echo -n "$ac_cv_guix_test_root/store/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-bootstrap-binaries-0/bin/bash" | wc -c`])
])
dnl GUIX_CHECK_FILE_NAME_LIMITS dnl GUIX_CHECK_FILE_NAME_LIMITS
dnl dnl
dnl GNU/Linux has a couple of silly limits that we can easily run into. dnl GNU/Linux has a couple of silly limits that we can easily run into.
@ -212,6 +220,7 @@ AC_DEFUN([GUIX_CHECK_FILE_NAME_LIMITS], [
AC_REQUIRE([GUIX_SOCKET_FILE_NAME_LENGTH]) AC_REQUIRE([GUIX_SOCKET_FILE_NAME_LENGTH])
AC_REQUIRE([GUIX_TEST_SOCKET_FILE_NAME_LENGTH]) AC_REQUIRE([GUIX_TEST_SOCKET_FILE_NAME_LENGTH])
AC_REQUIRE([GUIX_HASH_BANG_LENGTH]) AC_REQUIRE([GUIX_HASH_BANG_LENGTH])
AC_REQUIRE([GUIX_TEST_HASH_BANG_LENGTH])
if test "$ac_cv_guix_socket_file_name_length" -ge ]SOCKET_FILE_NAME_LIMIT[; then if test "$ac_cv_guix_socket_file_name_length" -ge ]SOCKET_FILE_NAME_LIMIT[; then
AC_MSG_ERROR([socket file name would exceed the maxium allowed length]) AC_MSG_ERROR([socket file name would exceed the maxium allowed length])
@ -222,6 +231,9 @@ AC_DEFUN([GUIX_CHECK_FILE_NAME_LIMITS], [
if test "$ac_cv_guix_hash_bang_length" -ge ]LINUX_HASH_BANG_LIMIT[; then if test "$ac_cv_guix_hash_bang_length" -ge ]LINUX_HASH_BANG_LIMIT[; then
AC_MSG_ERROR([store directory '$storedir' would lead to overly long hash-bang lines]) AC_MSG_ERROR([store directory '$storedir' would lead to overly long hash-bang lines])
fi fi
if test "$ac_cv_guix_test_hash_bang_length" -ge ]LINUX_HASH_BANG_LIMIT[; then
AC_MSG_WARN([test directory '$ac_cv_guix_test_root' may lead to overly long hash-bang lines])
fi
]) ])
dnl GUIX_CHECK_CXX11 dnl GUIX_CHECK_CXX11