nixo
/
guix-devel
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

accounts: Always honor the configured user account shell. 

Starting from commit 0ae735bcc8, Guix
System would preserve the user shell across reconfigure and reboot.
This was done so as to allow for the use of 'chsh'.

This proved to be a misguided decision.  This commit goes back to
considering user shells as config and not "state."

* gnu/build/accounts.scm (allocate-passwd): Do not use shell from
PREVIOUS.
This commit is contained in:
Ludovic Courtès 2019-04-26 10:19:56 +02:00
parent 9ca5ff882e
commit 504a0fc636
No known key found for this signature in database
GPG Key ID: 090B11993D9AEBB5
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gnu/build/accounts.scm
View File

@ -483,9 +483,12 @@ new UIDs."
(real-name (if previous (real-name (if previous
(password-entry-real-name previous) (password-entry-real-name previous)
real-name)) real-name))
(shell (if previous
(password-entry-shell previous) ;; Do not reuse the shell of PREVIOUS since (1)
shell))) ;; that could lead to confusion, and (2) the
;; shell might have been GC'd. See
;; <https://lists.gnu.org/archive/html/guix-devel/2019-04/msg00478.html>.
(shell shell))
result) result)
allocation)))) allocation))))
'() '()