nixo
/
guix-devel
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

guix lint: Make sure synopses are not too long. 

* guix/scripts/lint.scm (check-synopsis-length): New procedure.
* tests/lint.scm ("synopsis: too long"): New test.
This commit is contained in:
Cyril Roelandt 2014-09-27 21:39:19 +02:00
parent 90d104ba82
commit 5622953de1
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
guix/scripts/lint.scm
View File

@ -140,11 +140,18 @@ Run a set of checkers on the specified package; if none is specified, run the ch
"no article allowed at the beginning of the synopsis"
'synopsis)))
(define (check-synopsis-length synopsis)
(if (>= (string-length synopsis) 80)
(emit-warning package
"synopsis should be less than 80 characters long"
'synopsis)))
(let ((synopsis (package-synopsis package)))
(if (string? synopsis)
(begin
(check-final-period synopsis)
(check-start-article synopsis)))))
(check-start-article synopsis)
(check-synopsis-length synopsis)))))
(define (check-patches package)
;; Emit a warning if the patches requires by PACKAGE are badly named.

9
tests/lint.scm
View File

@ -79,6 +79,15 @@
(check-synopsis-style pkg))))
"no article allowed at the beginning of the synopsis")))
(test-assert "synopsis: too long"
(->bool
(string-contains (call-with-warnings
(lambda ()
(let ((pkg (dummy-package "x"
(synopsis (make-string 80 #\x)))))
(check-synopsis-style pkg))))
"synopsis should be less than 80 characters long")))
(test-assert "inputs: pkg-config is probably a native input"
(->bool
(string-contains