From 5c0f1845364fe8a5657a9e5a33090ea0ba781ea9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= Date: Wed, 11 Dec 2013 00:19:27 +0100 Subject: [PATCH] store: Optimize 'store-path-package-name' and 'store-path-hash-part'. * guix/store.scm (store-regexp*): New procedure. (store-path-package-name, store-path-hash-part): Use it. --- guix/store.scm | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/guix/store.scm b/guix/store.scm index 2821cacdcc..08b0671b29 100644 --- a/guix/store.scm +++ b/guix/store.scm @@ -653,21 +653,25 @@ valid inputs." "Return #t if PATH is a derivation path." (and (store-path? path) (string-suffix? ".drv" path))) +(define store-regexp* + ;; The substituter makes repeated calls to 'store-path-hash-part', hence + ;; this optimization. + (memoize + (lambda (store) + "Return a regexp matching a file in STORE." + (make-regexp (string-append "^" (regexp-quote store) + "/([0-9a-df-np-sv-z]{32})-([^/]+)$"))))) + (define (store-path-package-name path) "Return the package name part of PATH, a file name in the store." - (define store-path-rx - (make-regexp (string-append "^.*" (regexp-quote (%store-prefix)) - "/[^-]+-(.+)$"))) - - (and=> (regexp-exec store-path-rx path) - (cut match:substring <> 1))) + (let ((path-rx (store-regexp* (%store-prefix)))) + (and=> (regexp-exec path-rx path) + (cut match:substring <> 2)))) (define (store-path-hash-part path) "Return the hash part of PATH as a base32 string, or #f if PATH is not a syntactically valid store path." - (let ((path-rx (make-regexp - (string-append"^" (regexp-quote (%store-prefix)) - "/([0-9a-df-np-sv-z]{32})-[^/]+$")))) + (let ((path-rx (store-regexp* (%store-prefix)))) (and=> (regexp-exec path-rx path) (cut match:substring <> 1))))