store: Add 'GUIX_PROFILING' support for the object cache.

* guix/store.scm (profiled?): New procedure.
(record-operation): Use it.
(record-cache-lookup!): New procedure.
(lookup-cached-object): Use it.
This commit is contained in:
Ludovic Courtès 2017-06-28 10:13:45 +02:00
parent 207a79b2fe
commit 73b0ebdd5e
No known key found for this signature in database
GPG Key ID: 090B11993D9AEBB5
1 changed files with 51 additions and 12 deletions

View File

@ -846,6 +846,14 @@ bytevector) as its internal buffer, and a thunk to flush this output port."
write #f #f flush) write #f #f flush)
flush)) flush))
(define profiled?
(let ((profiled
(or (and=> (getenv "GUIX_PROFILING") string-tokenize)
'())))
(lambda (component)
"Return true if COMPONENT profiling is active."
(member component profiled))))
(define %rpc-calls (define %rpc-calls
;; Mapping from RPC names (symbols) to invocation counts. ;; Mapping from RPC names (symbols) to invocation counts.
(make-hash-table)) (make-hash-table))
@ -1504,15 +1512,45 @@ and RESULT is typically its derivation."
(object-cache (vhash-consq object (cons result keys) (object-cache (vhash-consq object (cons result keys)
(nix-server-object-cache store))))))) (nix-server-object-cache store)))))))
(define record-cache-lookup!
(if (profiled? "object-cache")
(let ((fresh 0)
(lookups 0)
(hits 0))
(register-profiling-hook!
"object-cache"
(lambda ()
(format (current-error-port) "Store object cache:
fresh caches: ~5@a
lookups: ~5@a
hits: ~5@a (~,1f%)~%"
fresh lookups hits
(if (zero? lookups)
100.
(* 100. (/ hits lookups))))))
(lambda (hit? cache)
(set! fresh
(if (eq? cache vlist-null)
(+ 1 fresh)
fresh))
(set! lookups (+ 1 lookups))
(set! hits (if hit? (+ hits 1) hits))))
(lambda (x y)
#t)))
(define* (lookup-cached-object object #:optional (keys '())) (define* (lookup-cached-object object #:optional (keys '()))
"Return the cached object in the store connection corresponding to OBJECT "Return the cached object in the store connection corresponding to OBJECT
and KEYS. KEYS is a list of additional keys to match against, and which are and KEYS. KEYS is a list of additional keys to match against, and which are
compared with 'equal?'. Return #f on failure and the cached result compared with 'equal?'. Return #f on failure and the cached result
otherwise." otherwise."
(lambda (store) (lambda (store)
;; Escape as soon as we find the result. This avoids traversing the whole (let* ((cache (nix-server-object-cache store))
;; vlist chain and significantly reduces the number of 'hashq' calls.
(values (let/ec return ;; Escape as soon as we find the result. This avoids traversing
;; the whole vlist chain and significantly reduces the number of
;; 'hashq' calls.
(value (let/ec return
(vhash-foldq* (lambda (item result) (vhash-foldq* (lambda (item result)
(match item (match item
((value . keys*) ((value . keys*)
@ -1520,8 +1558,9 @@ otherwise."
(return value) (return value)
result)))) result))))
#f object #f object
(nix-server-object-cache store))) cache))))
store))) (record-cache-lookup! value cache)
(values value store))))
(define* (%mcached mthunk object #:optional (keys '())) (define* (%mcached mthunk object #:optional (keys '()))
"Bind the monadic value returned by MTHUNK, which supposedly corresponds to "Bind the monadic value returned by MTHUNK, which supposedly corresponds to