nixo
/
guix-devel
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gnu: groff-minimal: Disable relocatability. 

* gnu/packages/groff.scm (groff-minimal)[arguments]<#:phases>
[disable-relocatability]: New phase.
This commit is contained in:
Danny Milosavljevic 2019-01-16 15:00:04 +01:00
parent 6c4a951a6e
commit 73b2ce8795
No known key found for this signature in database
GPG Key ID: E71A35542C30BAA5
1 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
gnu/packages/groff.scm
View File

@ -96,6 +96,36 @@ is usually the formatter of \"man\" documentation pages.")
,@(substitute-keyword-arguments (package-arguments groff) ,@(substitute-keyword-arguments (package-arguments groff)
((#:phases phases) ((#:phases phases)
`(modify-phases ,phases `(modify-phases ,phases
(add-after 'unpack 'disable-relocatability
(lambda _
;; Groff contains a Rube Goldberg-esque relocator for the
;; file "charset.alias".
;; It tries to find the current executable using realpath,
;; a do-it-yourself search in $PATH and so on.
;; Furthermore, the routine that does the search is buggy
;; in that it doesn't handle error cases when they arise.
;; This causes preconv to segfault when trying to look up
;; the file "charset.alias" in the NULL location.
;; The "charset.alias" parser is a copy of gnulib's, and a
;; non-broken version of gnulib's "charset.alias" parser
;; is part of glibc's libcharset.
;; However, groff unconditionally uses their own
;; "charset.alias" parser, but then DOES NOT INSTALL the
;; file "charset.alias" when glibc is too new.
;; In Guix, our file "charset.alias" only contains an
;; obscure alias for ASCII and nothing else.
;; So just disable relocation and make the entire
;; "charset.alias" lookup fail.
;; See <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30785>
;; for details.
(substitute* "src/libs/libgroff/Makefile.sub"
(("-DENABLE_RELOCATABLE=1") ""))
;; That file contains a crash bug--so make sure that
;; its contents are not there.
(call-with-output-file "src/libs/libgroff/relocate.cpp"
(lambda (port)
#t))
#t))
(add-after 'install 'remove-non-essential-programs (add-after 'install 'remove-non-essential-programs
(lambda* (#:key outputs #:allow-other-keys) (lambda* (#:key outputs #:allow-other-keys)
;; Keep only the programs that man-db needs at run time, ;; Keep only the programs that man-db needs at run time,