inferior: Add 'inferior-eval-with-store'.
* guix/inferior.scm (inferior-eval-with-store): New procedure, with code formerly in 'inferior-package-derivation'. (inferior-package-derivation): Rewrite in terms of 'inferior-eval-with-store'. * tests/inferior.scm ("inferior-eval-with-store"): New test.
This commit is contained in:
parent
d4aa147eec
commit
94c0e61fe7
|
@ -56,6 +56,7 @@
|
||||||
open-inferior
|
open-inferior
|
||||||
close-inferior
|
close-inferior
|
||||||
inferior-eval
|
inferior-eval
|
||||||
|
inferior-eval-with-store
|
||||||
inferior-object?
|
inferior-object?
|
||||||
|
|
||||||
inferior-packages
|
inferior-packages
|
||||||
|
@ -402,6 +403,48 @@ input/output ports.)"
|
||||||
(unless (port-closed? client)
|
(unless (port-closed? client)
|
||||||
(loop))))))
|
(loop))))))
|
||||||
|
|
||||||
|
(define (inferior-eval-with-store inferior store code)
|
||||||
|
"Evaluate CODE in INFERIOR, passing it STORE as its argument. CODE must
|
||||||
|
thus be the code of a one-argument procedure that accepts a store."
|
||||||
|
;; Create a named socket in /tmp and let INFERIOR connect to it and use it
|
||||||
|
;; as its store. This ensures the inferior uses the same store, with the
|
||||||
|
;; same options, the same per-session GC roots, etc.
|
||||||
|
(call-with-temporary-directory
|
||||||
|
(lambda (directory)
|
||||||
|
(chmod directory #o700)
|
||||||
|
(let* ((name (string-append directory "/inferior"))
|
||||||
|
(socket (socket AF_UNIX SOCK_STREAM 0))
|
||||||
|
(major (nix-server-major-version store))
|
||||||
|
(minor (nix-server-minor-version store))
|
||||||
|
(proto (logior major minor)))
|
||||||
|
(bind socket AF_UNIX name)
|
||||||
|
(listen socket 1024)
|
||||||
|
(send-inferior-request
|
||||||
|
`(let ((proc ,code)
|
||||||
|
(socket (socket AF_UNIX SOCK_STREAM 0)))
|
||||||
|
(connect socket AF_UNIX ,name)
|
||||||
|
|
||||||
|
;; 'port->connection' appeared in June 2018 and we can hardly
|
||||||
|
;; emulate it on older versions. Thus fall back to
|
||||||
|
;; 'open-connection', at the risk of talking to the wrong daemon or
|
||||||
|
;; having our build result reclaimed (XXX).
|
||||||
|
(let ((store (if (defined? 'port->connection)
|
||||||
|
(port->connection socket #:version ,proto)
|
||||||
|
(open-connection))))
|
||||||
|
(dynamic-wind
|
||||||
|
(const #t)
|
||||||
|
(lambda ()
|
||||||
|
(proc store))
|
||||||
|
(lambda ()
|
||||||
|
(close-connection store)
|
||||||
|
(close-port socket)))))
|
||||||
|
inferior)
|
||||||
|
(match (accept socket)
|
||||||
|
((client . address)
|
||||||
|
(proxy client (nix-server-socket store))))
|
||||||
|
(close-port socket)
|
||||||
|
(read-inferior-response inferior)))))
|
||||||
|
|
||||||
(define* (inferior-package-derivation store package
|
(define* (inferior-package-derivation store package
|
||||||
#:optional
|
#:optional
|
||||||
(system (%current-system))
|
(system (%current-system))
|
||||||
|
@ -409,48 +452,21 @@ input/output ports.)"
|
||||||
"Return the derivation for PACKAGE, an inferior package, built for SYSTEM
|
"Return the derivation for PACKAGE, an inferior package, built for SYSTEM
|
||||||
and cross-built for TARGET if TARGET is true. The inferior corresponding to
|
and cross-built for TARGET if TARGET is true. The inferior corresponding to
|
||||||
PACKAGE must be live."
|
PACKAGE must be live."
|
||||||
;; Create a named socket in /tmp and let the inferior of PACKAGE connect to
|
(define proc
|
||||||
;; it and use it as its store. This ensures the inferior uses the same
|
`(lambda (store)
|
||||||
;; store, with the same options, the same per-session GC roots, etc.
|
(let* ((package (hashv-ref %package-table
|
||||||
(call-with-temporary-directory
|
,(inferior-package-id package)))
|
||||||
(lambda (directory)
|
(drv ,(if target
|
||||||
(chmod directory #o700)
|
`(package-cross-derivation store package
|
||||||
(let* ((name (string-append directory "/inferior"))
|
,target
|
||||||
(socket (socket AF_UNIX SOCK_STREAM 0))
|
,system)
|
||||||
(inferior (inferior-package-inferior package))
|
`(package-derivation store package
|
||||||
(major (nix-server-major-version store))
|
,system))))
|
||||||
(minor (nix-server-minor-version store))
|
(derivation-file-name drv))))
|
||||||
(proto (logior major minor)))
|
|
||||||
(bind socket AF_UNIX name)
|
|
||||||
(listen socket 1024)
|
|
||||||
(send-inferior-request
|
|
||||||
`(let ((socket (socket AF_UNIX SOCK_STREAM 0)))
|
|
||||||
(connect socket AF_UNIX ,name)
|
|
||||||
|
|
||||||
;; 'port->connection' appeared in June 2018 and we can hardly
|
(and=> (inferior-eval-with-store (inferior-package-inferior package) store
|
||||||
;; emulate it on older versions. Thus fall back to
|
proc)
|
||||||
;; 'open-connection', at the risk of talking to the wrong daemon or
|
read-derivation-from-file))
|
||||||
;; having our build result reclaimed (XXX).
|
|
||||||
(let* ((store (if (defined? 'port->connection)
|
|
||||||
(port->connection socket #:version ,proto)
|
|
||||||
(open-connection)))
|
|
||||||
(package (hashv-ref %package-table
|
|
||||||
,(inferior-package-id package)))
|
|
||||||
(drv ,(if target
|
|
||||||
`(package-cross-derivation store package
|
|
||||||
,target
|
|
||||||
,system)
|
|
||||||
`(package-derivation store package
|
|
||||||
,system))))
|
|
||||||
(close-connection store)
|
|
||||||
(close-port socket)
|
|
||||||
(derivation-file-name drv)))
|
|
||||||
inferior)
|
|
||||||
(match (accept socket)
|
|
||||||
((client . address)
|
|
||||||
(proxy client (nix-server-socket store))))
|
|
||||||
(close-port socket)
|
|
||||||
(read-derivation-from-file (read-inferior-response inferior))))))
|
|
||||||
|
|
||||||
(define inferior-package->derivation
|
(define inferior-package->derivation
|
||||||
(store-lift inferior-package-derivation))
|
(store-lift inferior-package-derivation))
|
||||||
|
|
|
@ -157,6 +157,15 @@
|
||||||
(close-inferior inferior)
|
(close-inferior inferior)
|
||||||
result))
|
result))
|
||||||
|
|
||||||
|
(test-equal "inferior-eval-with-store"
|
||||||
|
(add-text-to-store %store "foo" "Hello, world!")
|
||||||
|
(let* ((inferior (open-inferior %top-builddir
|
||||||
|
#:command "scripts/guix")))
|
||||||
|
(inferior-eval-with-store inferior %store
|
||||||
|
'(lambda (store)
|
||||||
|
(add-text-to-store store "foo"
|
||||||
|
"Hello, world!")))))
|
||||||
|
|
||||||
(test-equal "inferior-package-derivation"
|
(test-equal "inferior-package-derivation"
|
||||||
(map derivation-file-name
|
(map derivation-file-name
|
||||||
(list (package-derivation %store %bootstrap-guile "x86_64-linux")
|
(list (package-derivation %store %bootstrap-guile "x86_64-linux")
|
||||||
|
|
Loading…
Reference in New Issue