guix lint: Make sure a synopsis cannot start with a lower-case article.
* guix/scripts/lint.scm (check-start-article): use "string-ci=?" instead of "string=?". * tests/lint.scm ("synopsis: starts with 'a'", "synopsis: starts with 'an'"): New tests.
This commit is contained in:
parent
8202a51313
commit
a00ffdaa17
|
@ -148,8 +148,8 @@ Run a set of checkers on the specified package; if none is specified, run the ch
|
||||||
'synopsis)))
|
'synopsis)))
|
||||||
|
|
||||||
(define (check-start-article synopsis)
|
(define (check-start-article synopsis)
|
||||||
(if (or (string=? (string-take synopsis 2) "A ")
|
(if (or (string-ci=? (string-take synopsis 2) "A ")
|
||||||
(string=? (string-take synopsis 3) "An "))
|
(string-ci=? (string-take synopsis 3) "An "))
|
||||||
(emit-warning package
|
(emit-warning package
|
||||||
"no article allowed at the beginning of the synopsis"
|
"no article allowed at the beginning of the synopsis"
|
||||||
'synopsis)))
|
'synopsis)))
|
||||||
|
|
|
@ -97,6 +97,24 @@
|
||||||
(check-synopsis-style pkg))))
|
(check-synopsis-style pkg))))
|
||||||
"no article allowed at the beginning of the synopsis")))
|
"no article allowed at the beginning of the synopsis")))
|
||||||
|
|
||||||
|
(test-assert "synopsis: starts with 'a'"
|
||||||
|
(->bool
|
||||||
|
(string-contains (call-with-warnings
|
||||||
|
(lambda ()
|
||||||
|
(let ((pkg (dummy-package "x"
|
||||||
|
(synopsis "a bad synopsis"))))
|
||||||
|
(check-synopsis-style pkg))))
|
||||||
|
"no article allowed at the beginning of the synopsis")))
|
||||||
|
|
||||||
|
(test-assert "synopsis: starts with 'an'"
|
||||||
|
(->bool
|
||||||
|
(string-contains (call-with-warnings
|
||||||
|
(lambda ()
|
||||||
|
(let ((pkg (dummy-package "x"
|
||||||
|
(synopsis "an awful synopsis"))))
|
||||||
|
(check-synopsis-style pkg))))
|
||||||
|
"no article allowed at the beginning of the synopsis")))
|
||||||
|
|
||||||
(test-assert "synopsis: too long"
|
(test-assert "synopsis: too long"
|
||||||
(->bool
|
(->bool
|
||||||
(string-contains (call-with-warnings
|
(string-contains (call-with-warnings
|
||||||
|
|
Loading…
Reference in New Issue