size: Add '--sort=KEY'.

* guix/scripts/size.scm (profile-closure<?, profile-self<?): New
procedures.
(display-profile): Add #:profile<? parameter and honor it.
(show-help, %options): Add '--sort'.
(%default-options): Add 'profile<?'.
(guix-size): Pass PROFILE<? to 'display-profile*'.
* doc/guix.texi (Invoking guix size): Document '--sort'.
This commit is contained in:
Ludovic Courtès 2017-07-12 15:41:49 +02:00
parent 1ac3a488ad
commit a6c1fe8240
No known key found for this signature in database
GPG Key ID: 090B11993D9AEBB5
2 changed files with 44 additions and 9 deletions

View File

@ -6338,6 +6338,16 @@ The available options are:
Use substitute information from @var{urls}. Use substitute information from @var{urls}.
@xref{client-substitute-urls, the same option for @code{guix build}}. @xref{client-substitute-urls, the same option for @code{guix build}}.
@item --sort=@var{key}
Sort lines according to @var{key}, one of the following options:
@table @code
@item closure
the total size of the item's closure (the default);
@item self
the size of each item.
@end table
@item --map-file=@var{file} @item --map-file=@var{file}
Write a graphical map of disk usage in PNG format to @var{file}. Write a graphical map of disk usage in PNG format to @var{file}.

View File

@ -77,8 +77,22 @@ if ITEM is not in the store."
(leave (G_ "no available substitute information for '~a'~%") (leave (G_ "no available substitute information for '~a'~%")
item))))))) item)))))))
(define* (display-profile profile #:optional (port (current-output-port))) (define profile-closure<?
"Display PROFILE, a list of PROFILE objects, to PORT." (match-lambda*
((($ <profile> name1 self1 total1)
($ <profile> name2 self2 total2))
(< total1 total2))))
(define profile-self<?
(match-lambda*
((($ <profile> name1 self1 total1)
($ <profile> name2 self2 total2))
(< self1 self2))))
(define* (display-profile profile #:optional (port (current-output-port))
#:key (profile<? profile-closure<?))
"Display PROFILE, a list of PROFILE objects, to PORT. Sort entries
according to PROFILE<?."
(define MiB (expt 2 20)) (define MiB (expt 2 20))
(format port "~64a ~8a ~a\n" (format port "~64a ~8a ~a\n"
@ -89,11 +103,7 @@ if ITEM is not in the store."
(format port "~64a ~6,1f ~6,1f ~5,1f%\n" (format port "~64a ~6,1f ~6,1f ~5,1f%\n"
name (/ total MiB) (/ self MiB) name (/ total MiB) (/ self MiB)
(* 100. (/ self whole 1.))))) (* 100. (/ self whole 1.)))))
(sort profile (sort profile (negate profile<?)))
(match-lambda*
((($ <profile> name1 self1 total1)
($ <profile> name2 self2 total2))
(> total1 total2)))))
(format port (G_ "total: ~,1f MiB~%") (/ whole MiB 1.)))) (format port (G_ "total: ~,1f MiB~%") (/ whole MiB 1.))))
(define display-profile* (define display-profile*
@ -224,6 +234,9 @@ Report the size of PACKAGE and its dependencies.\n"))
fetch substitute from URLS if they are authorized")) fetch substitute from URLS if they are authorized"))
(display (G_ " (display (G_ "
-s, --system=SYSTEM consider packages for SYSTEM--e.g., \"i686-linux\"")) -s, --system=SYSTEM consider packages for SYSTEM--e.g., \"i686-linux\""))
;; TRANSLATORS: "closure" and "self" must not be translated.
(display (G_ "
--sort=KEY sort according to KEY--\"closure\" or \"self\""))
(display (G_ " (display (G_ "
-m, --map-file=FILE write to FILE a graphical map of disk usage")) -m, --map-file=FILE write to FILE a graphical map of disk usage"))
(newline) (newline)
@ -247,6 +260,15 @@ Report the size of PACKAGE and its dependencies.\n"))
(string-tokenize arg) (string-tokenize arg)
(alist-delete 'substitute-urls result)) (alist-delete 'substitute-urls result))
rest))) rest)))
(option '("sort") #t #f
(lambda (opt name arg result . rest)
(match arg
("closure"
(alist-cons 'profile<? profile-closure<? result))
("self"
(alist-cons 'profile<? profile-self<? result))
(_
(leave (G_ "~a: invalid sorting key~%") arg)))))
(option '(#\m "map-file") #t #f (option '(#\m "map-file") #t #f
(lambda (opt name arg result) (lambda (opt name arg result)
(alist-cons 'map-file arg result))) (alist-cons 'map-file arg result)))
@ -259,7 +281,8 @@ Report the size of PACKAGE and its dependencies.\n"))
(show-version-and-exit "guix size"))))) (show-version-and-exit "guix size")))))
(define %default-options (define %default-options
`((system . ,(%current-system)))) `((system . ,(%current-system))
(profile<? . ,profile-closure<?)))
;;; ;;;
@ -273,6 +296,7 @@ Report the size of PACKAGE and its dependencies.\n"))
(('argument . file) file) (('argument . file) file)
(_ #f)) (_ #f))
opts)) opts))
(profile<? (assoc-ref opts 'profile<?))
(map-file (assoc-ref opts 'map-file)) (map-file (assoc-ref opts 'map-file))
(system (assoc-ref opts 'system)) (system (assoc-ref opts 'system))
(urls (assoc-ref opts 'substitute-urls))) (urls (assoc-ref opts 'substitute-urls)))
@ -298,5 +322,6 @@ Report the size of PACKAGE and its dependencies.\n"))
(begin (begin
(profile->page-map profile map-file) (profile->page-map profile map-file)
(return #t)) (return #t))
(display-profile* profile))) (display-profile* profile (current-output-port)
#:profile<? profile<?)))
#:system system))))))))) #:system system)))))))))