substitute: Warn upon store prefix mismatches.

Suggested by Hynek Urban <hynek.urban@gmail.com>.

* guix/scripts/substitute.scm (fetch-narinfos): Move body to...
[do-fetch]: ... here.  New procedure.
Emit a warning when CACHE-INFO's prefix does not match.
This commit is contained in:
Ludovic Courtès 2015-11-28 00:02:23 +01:00
parent 6629099a63
commit ae4427e3f3
1 changed files with 27 additions and 21 deletions

View File

@ -565,13 +565,7 @@ if file doesn't exist, and the narinfo otherwise."
(read-to-eof port)) (read-to-eof port))
result)))) result))))
(define cache-info (define (do-fetch uri)
(download-cache-info url))
(and cache-info
(string=? (cache-info-store-directory cache-info)
(%store-prefix))
(let ((uri (string->uri url)))
(case (and=> uri uri-scheme) (case (and=> uri uri-scheme)
((http) ((http)
(let ((requests (map (cut narinfo-request url <>) paths))) (let ((requests (map (cut narinfo-request url <>) paths)))
@ -589,7 +583,19 @@ if file doesn't exist, and the narinfo otherwise."
(filter-map (cut narinfo-from-file <> url) files))) (filter-map (cut narinfo-from-file <> url) files)))
(else (else
(leave (_ "~s: unsupported server URI scheme~%") (leave (_ "~s: unsupported server URI scheme~%")
(if uri (uri-scheme uri) url))))))) (if uri (uri-scheme uri) url)))))
(define cache-info
(download-cache-info url))
(and cache-info
(if (string=? (cache-info-store-directory cache-info)
(%store-prefix))
(do-fetch (string->uri url))
(begin
(warning (_ "'~a' uses different store '~a'; ignoring it~%")
url (cache-info-store-directory cache-info))
#f))))
(define (lookup-narinfos cache paths) (define (lookup-narinfos cache paths)
"Return the narinfos for PATHS, invoking the server at CACHE when no "Return the narinfos for PATHS, invoking the server at CACHE when no