nixo
/
guix-devel
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gnu: libvirt: Enable the test suite. 

* gnu/packages/virtualization.scm (libvirt)[arguments]: Fix posix_spawn
tests, specifically disable the remaining failing tests, and enable the
rest of the test suite.
This commit is contained in:
Tobias Geerinckx-Rice 2019-06-25 11:54:26 +02:00
parent 1e623974b1
commit bd9eb3840a
No known key found for this signature in database
GPG Key ID: 0DB0FF884F556D79
1 changed files with 13 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
gnu/packages/virtualization.scm
View File

@ -409,28 +409,27 @@ manage system or application containers.")
"0ywf8m9yz2hxnic7fylzlmgy4m353r4vv5zsvp89zq5yh4h81yhw")))) "0ywf8m9yz2hxnic7fylzlmgy4m353r4vv5zsvp89zq5yh4h81yhw"))))
(build-system gnu-build-system) (build-system gnu-build-system)
(arguments (arguments
`(;; FAIL: virshtest `(#:configure-flags
;; FAIL: virfirewalltest
;; FAIL: virkmodtest
;; FAIL: virnetsockettest
;; FAIL: networkxml2firewalltest
;; FAIL: nwfilterebiptablestest
;; FAIL: nwfilterxml2firewalltest
;; Time-out while running commandtest.
#:tests? #f
#:configure-flags
(list "--with-polkit" (list "--with-polkit"
"--sysconfdir=/etc" "--sysconfdir=/etc"
"--localstatedir=/var") "--localstatedir=/var")
#:phases #:phases
(modify-phases %standard-phases (modify-phases %standard-phases
(add-after 'unpack 'fix-tests (add-before 'configure 'fix-BOURNE_SHELL-definition
;; BOURNE_SHELL is hard-#defined to ‘/bin/sh’, causing test failures.
(lambda _ (lambda _
(substitute* '("tests/commandtest.c" (substitute* "config.h.in"
"gnulib/tests/test-posix_spawn1.c"
"gnulib/tests/test-posix_spawn2.c")
(("/bin/sh") (which "sh"))) (("/bin/sh") (which "sh")))
#t)) #t))
(add-before 'configure 'disable-broken-tests
(lambda _
(let ((tests (list "commandtest" ; hangs idly
"virnetsockettest" ; tries to network
"virshtest"))) ; fails
(substitute* "tests/Makefile.in"
(((format #f "(~a)\\$\\(EXEEXT\\)" (string-join tests "|")))
""))
#t)))
(replace 'install (replace 'install
;; Since the sysconfdir and localstatedir should be /etc and /var ;; Since the sysconfdir and localstatedir should be /etc and /var
;; at runtime, we must prevent writing to them at installation ;; at runtime, we must prevent writing to them at installation