services: gdm: Remove 'allow-root?' option.

This option results in allowing all login attempts without asking for
credentials.  The name is confusing, but rather than rename it, we will
remove it, since it seems like a feature that no one would want.

* gnu/services/xorg.scm (<gdm-configuration>): Remove 'allow-root?'.
(gdm-pam-service): Do not use 'gdm-configuration-allow-root?'.

Signed-off-by: Danny Milosavljevic <dannym@scratchpost.org>
This commit is contained in:
Timothy Sample 2018-12-29 21:42:03 -05:00 committed by Danny Milosavljevic
parent 89c8656200
commit de409e8226
No known key found for this signature in database
GPG Key ID: E71A35542C30BAA5
1 changed files with 4 additions and 5 deletions

View File

@ -2,6 +2,7 @@
;;; Copyright © 2017 Andy Wingo <wingo@igalia.com> ;;; Copyright © 2017 Andy Wingo <wingo@igalia.com>
;;; Copyright © 2013, 2014, 2015, 2016, 2017 Ludovic Courtès <ludo@gnu.org> ;;; Copyright © 2013, 2014, 2015, 2016, 2017 Ludovic Courtès <ludo@gnu.org>
;;; Copyright © 2015 Sou Bunnbu <iyzsong@gmail.com> ;;; Copyright © 2015 Sou Bunnbu <iyzsong@gmail.com>
;;; Copyright © 2018 Timothy Sample <samplet@ngyro.com>
;;; ;;;
;;; This file is part of GNU Guix. ;;; This file is part of GNU Guix.
;;; ;;;
@ -625,7 +626,6 @@ makes the good ol' XlockMore usable."
gdm-configuration? gdm-configuration?
(gdm gdm-configuration-gdm (default gdm)) (gdm gdm-configuration-gdm (default gdm))
(allow-empty-passwords? gdm-configuration-allow-empty-passwords? (default #t)) (allow-empty-passwords? gdm-configuration-allow-empty-passwords? (default #t))
(allow-root? gdm-configuration-allow-root? (default #t))
(auto-login? gdm-configuration-auto-login? (default #f)) (auto-login? gdm-configuration-auto-login? (default #f))
(default-user gdm-configuration-default-user (default #f)) (default-user gdm-configuration-default-user (default #f))
(x-server gdm-configuration-x-server)) (x-server gdm-configuration-x-server))
@ -680,10 +680,9 @@ makes the good ol' XlockMore usable."
(auth (list (pam-entry (auth (list (pam-entry
(control "required") (control "required")
(module "pam_permit.so"))))) (module "pam_permit.so")))))
(unix-pam-service (unix-pam-service "gdm-password"
"gdm-password" #:allow-empty-passwords?
#:allow-empty-passwords? (gdm-configuration-allow-empty-passwords? config) (gdm-configuration-allow-empty-passwords? config))))
#:allow-root? (gdm-configuration-allow-root? config))))
(define (gdm-shepherd-service config) (define (gdm-shepherd-service config)
(list (shepherd-service (list (shepherd-service