052e96d323
Use lround instead of (long)round
2018-10-13 21:10:10 +03:00
e4d2b38552
Make comment style more consistent
2018-10-13 21:10:10 +03:00
a65914f338
Fix missing prototypes
...
i3 will now compile with no warnings when -Wmissing-prototypes is used.
2018-10-13 21:10:10 +03:00
2a9522dda4
Enforce strict prototypes
...
i3 will now compile with no warnings when -Wstrict-prototypes is used.
2018-10-13 21:10:09 +03:00
a15fff2370
Use path_exists
2018-10-13 21:10:09 +03:00
50880db2c5
Reduce some code around frees
2018-10-13 21:10:09 +03:00
565d38c5af
Merge pull request #3454 from alanbarr/cppcheck_fixes_2
...
Cppcheck Fixes
2018-10-13 21:07:17 +03:00
7c0994dafc
Fixes for undefined behaviour on signed shift ( #3453 )
...
Fixes for undefined behaviour on signed shift
Change literal 1 to unsigned to allow safe bitshift of 31.
Caught by cppcheck.
Make 0xFF unsigned to prevent a left shift into signed bit.
Spotted by @orestisf1993
2018-10-13 21:04:40 +03:00
687238b79b
Typecast void* before doing pointer arithmetic
...
Caught by cppcheck
2018-10-13 17:41:50 +01:00
88c378154a
Remove redundant NULL check
...
copy has been used before this point - so it is too late to be concerned
about a NULL pointer now.
This is OK as sstrdup() calls err() on NULL return from the underlying
strdup() call.
Raised by cppcheck.
2018-10-13 17:41:50 +01:00
dfe89cc4f1
i3-nagbar: add option for button that runs commands without a terminal ( #3258 )
...
Fixes #2199 .
2018-10-07 22:43:24 +02:00
c583f81c80
Merge pull request #3441 from stapelberg/template
...
add specific GitHub issue templates
2018-10-07 22:09:28 +03:00
f20467ac86
Merge pull request #3440 from stapelberg/disable
...
configure.ac: add conditionals for building docs/mans
2018-10-07 22:02:43 +03:00
824d691640
add specific GitHub issue templates
...
I learnt about this from the GitHub blog:
https://blog.github.com/2018-05-02-issue-template-improvements/
2018-10-07 20:41:42 +02:00
2be4975f18
resolve_tilde: strncpy + strlen is pointless ( #3436 )
...
strlen already assumes that the string is NULL-terminated.
Like in https://github.com/i3/i3status/pull/312 but for whatever reason
gcc didn't warn about this here.
2018-10-07 20:26:37 +02:00
18dbfe699a
userguide: Mention know issues for assign ( #3434 )
...
Fixes #3222
Fixes #3293
Related to #2060
2018-10-07 20:24:09 +02:00
acea46e16a
configure.ac: add conditionals for building docs/mans
...
fixes #3378
2018-10-07 20:09:35 +02:00
5720ba65ab
Merge pull request #3435 from vivien/i3-msg/subscribe
...
i3-msg/subscribe
2018-10-05 12:16:04 +03:00
cff4fadd72
i3-msg: add support for SUBSCRIBE message type
...
If i3-msg is invoked with -t subscribe, it will wait for the first event
matching the given payload, before exiting.
For instance, get the number of the next focused workspace with:
i3-msg -t subscribe '[ "workspace" ]' | jshon -e current -e num
Like inotifywait, the -m flag allows to wait indefinitely for events,
instead of exiting right after receiving the first one.
For example, continuously monitor the names of focused windows with:
i3-msg -t subscribe -m '[ "window" ]' | jq .container.name
2018-10-04 12:54:45 -04:00
d722d1b0e6
i3-msg: check reply in quiet mode
...
i3-msg currently exits right after sending the IPC message if the quiet
flag is set. This means that if an error occurred when issuing a
command, e.g. "i3-msg -q foobar", it gets silently ignored.
What we really want is to just skip printing but still check the reply.
At the same time, explicitly print the reply when we need to, instead of
using an exit label.
2018-10-03 10:43:09 -04:00
3b73edb511
Merge pull request #3430 from Synray/aspect_ratio
...
[RFC] Correctly calculate max_aspect
2018-10-02 03:04:21 +03:00
0ede8b9365
Correctly calculate max_aspect
2018-09-28 17:34:18 -07:00
b8b5a61a2d
Merge pull request #3415 from orestisf1993/g_utf8_make_valid
...
Check g_utf8_make_valid availability
2018-09-28 18:00:06 +02:00
ebf40889a1
Merge pull request #3424 from orestisf1993/con_num_windows
...
con_num_windows: Count floating windows
2018-09-28 09:27:58 +02:00
5e1d327e43
con_num_windows: Count floating windows
...
Fixes #3423 .
2018-09-26 20:04:17 +03:00
27afc572c1
Merge pull request #3421 from Streetwalrus/iconic-state
...
Reject requests for WM_STATE_ICONIC
2018-09-26 09:07:16 +02:00
6877205ac1
Reject requests for WM_STATE_ICONIC
...
For compatiblity reasons, Wine will request iconic state and cannot
ensure that the WM has agreed on it; immediately revert to normal to
avoid being stuck in a paused state.
2018-09-25 15:04:55 +03:00
daf5ca111f
Provide g_utf8_make_valid if not available
...
See #3415 for licensing discussion.
Fixes Airblader/i3#236
2018-09-25 10:28:20 +03:00
aa8215194c
Fix typo: terminaison -> termination
2018-09-24 20:53:36 +03:00
bec227236b
Merge pull request #3420 from orestisf1993/sncontext==NULL-3419
...
i3-nagbar & i3-config-wizard: check sncontext != NULL
2018-09-23 20:12:16 +02:00
d080f58299
i3-nagbar & i3-config-wizard: check sncontext != NULL
...
From
07237ff25d/libsn/sn-common.c (L87-L171)Fixes #3419
2018-09-23 17:06:29 +03:00
ac88d06632
Merge pull request #3416 from orestisf1993/530-bug-2229.t
...
530-bug-229.t: Get rid of smartmatch
2018-09-20 18:52:33 +02:00
bf9da466db
530-bug-229.t: Get rid of smartmatch
2018-09-20 19:37:50 +03:00
7c21b5995d
Merge pull request #3400 from Synray/next
...
Respect max size from WM_NORMAL_HINTS
2018-09-20 11:36:22 +03:00
690e6d1f0e
Respect max size in WM_NORMAL_HINTS
2018-09-20 11:31:19 +03:00
bde4f40b67
Merge pull request #3408 from orestisf1993/__focused__-crash
...
match_matches_window: Check if focused->window exists
2018-09-19 14:42:28 +02:00
ea559966b5
Merge pull request #3410 from orestisf1993/min_width
...
docs/i3bar-protocol: Mention skipping blocks with empty full_text
2018-09-17 16:06:27 +02:00
2b898f4c90
Merge pull request #3386 from orestisf1993/click-event
...
Fix "relative_x" and "width" of click events
2018-09-16 15:48:36 +02:00
9b06f1ab05
docs/i3bar-protocol: Mention skipping blocks with empty full_text
...
Closes #3405 .
2018-09-16 15:04:20 +03:00
fed059a2b7
Fix "relative_x" and "width" of click events
...
Now clicks begin at the start of the "actual" block, offsets and
separators don't trigger click events. The width property is now just
the width of the block, including border.
Fixes #3380 .
2018-09-16 14:58:20 +03:00
515dd45f59
match_matches_window: Check if focused->window exists
...
Fixes #3406 .
2018-09-16 14:55:27 +03:00
633583de4a
Merge pull request #3409 from orestisf1993/sb_hoff_px
...
i3bar: Include sb_hoff_px only when needed
2018-09-16 11:11:47 +02:00
9936d049cf
i3bar: Include sb_hoff_px only when needed
...
Fixes #3404 .
2018-09-15 13:27:18 +03:00
18f705a978
Merge pull request #3403 from orestisf1993/issue-3402
...
_con_move_to_con: Move upwards only on CT_FLOATING_CON
2018-09-14 15:17:13 +02:00
d407393d0d
_con_move_to_con: Move upwards only on CT_FLOATING_CON
...
If target is inside a floating container but not its direct child, the
move can be completed as is.
Fixes #3402 .
2018-09-14 16:13:41 +03:00
c7132ec5b0
Merge pull request #3401 from orestisf1993/dump-asy-floating
...
dump-asy.pl: Include floating_nodes
2018-09-14 13:29:07 +02:00
702e83c95e
dump-asy.pl: Include floating_nodes
2018-09-14 14:05:51 +03:00
ede954128a
Merge pull request #3342 from orestisf1993/tree_close_internal
...
Simplify tree_close_internal
2018-09-14 12:24:54 +02:00
badcb152f9
Merge pull request #3399 from orestisf1993/156-fullscreen-focus
...
Make t/156-fullscreen-focus.t easier to work with
2018-09-14 08:19:00 +02:00
9c2ff947e1
Merge pull request #3398 from orestisf1993/i3-save-tree
...
i3-save-tree: Exclude unsupported "transient_for" property
2018-09-14 08:18:32 +02:00
Orestis Floros