nixo
/
gri3-wm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
6,918 Commits 1 Branch 0 Tags 14 MiB
Commit Graph

6918 Commits

Author SHA1 Message Date
Orestis Floros 2954125324
nagbar: Remove i3-nagbar.h 2020-04-20 04:25:45 +02:00
Orestis Floros 0b62129224
Remove unused headers 
With help from
https://github.com/include-what-you-use/include-what-you-use/
 2020-04-20 04:25:06 +02:00
Orestis Floros 3c522d9f2f
Sort includes in *.c files 
Not enabling in .clang-format because it breaks headers files.

Used:
    IncludeCategories:
      - Regex:           '^<config'
        Priority:        0
      - Regex:           '^".*"'
        Priority:        1
      - Regex:           '^<(xcb|xkb|yajl|X11)'
        Priority:        3
      - Regex:           '.*'
        Priority:        2
 2020-04-19 09:58:25 +02:00
Ingo Bürk 0bce0d86bf
Merge pull request #4018 from orestisfl/reorder-docks 
Sort dock clients by class and instance
 2020-04-15 08:36:10 +02:00
Orestis Floros 7df88f18eb
Sort dock clients by class and instance 
This is similar to #3820 but does not use qsort but an insertion sort in
con_attach.

Since each bar block automatically gets its own incremental bar id,
bards end up being sorted according to their definition order in the
config file.

For i3bar, the WM_CLASS is modified to include an instance name which
depends on the bar_id. This could be useful for other reason, e.g. users
targeting a specific bar instance.

Fixes #3491
 2020-04-14 20:47:51 +02:00
Orestis Floros 4212fb6488
i3bar: Set WM_CLASS instance to bar_id 2020-04-14 20:46:49 +02:00
Orestis Floros 831a52de9a
Move content for non-existing output containers (#3767) 
Probably fixes various related issues:
Closes #2276
Closes #2459
Closes #2936
Closes #3766

Tested using
bindsym $mod+Shift+i exec xrandr --output DVI-D-0 --mode 1920x1080 --pos 0x0 --rotate normal --output DVI-I-1 --off, restart

The core issue here is that the JSON read during a restart might contain
invalid outputs when the new process is done reading it.
 2020-04-12 13:52:05 +02:00
Orestis Floros ae757c6848
Extend tiling/floating criteria with optional auto/user values (#4006) 
The default `tiling` and `floating` behavior is preserved and matches
both cases.

Adds a new handler to `remanage_window` on A_I3_FLOATING_WINDOW change.

Mainly in order to `run_assignments`, this makes `for_window [floating]`
directives to work for windows which where initially opened as tiling.
Now, when floating is enabled, `for_window` will trigger correctly. Same
applies to `for_window [tiling]`.

The obvious solution of `run_assignments` after
`floating_{enable,disable}` doesn't work because `run_assignments`
modifies the parser state in src/assignments.c:51.

Fixes #3588

Co-Authored-By: Michael Stapelberg <michael@stapelberg.de>
 2020-04-12 13:49:08 +02:00
Michael Stapelberg e7191af8b3
pod2html: render without stylesheet by default (#4016) 
fixes #3956
 2020-04-12 11:07:43 +02:00
Ingo Bürk 46e940efba
Merge pull request #4013 from orestisfl/i3-dmenu-desktop-symlinks 
i3-dmenu-desktop: Support symlinks
 2020-04-12 09:15:40 +02:00
Ingo Bürk adbef0c7e7
Merge pull request #4015 from orestisfl/layout-restore-crash-floating 
Fix load_layout crash when floating node doesn't have CT_FLOATING_CON parent
 2020-04-12 09:12:16 +02:00
Orestis Floros a87e8c8d5b
Fix load_layout crash when floating node doesn't have CT_FLOATING_CON parent 
Fixes #3901
 2020-04-12 00:48:01 +02:00
Orestis Floros 3a672bc930
i3-dmenu-desktop: Support symlinks 
follow_fast is passed to find() in order to support this. Since we check
ourselves for duplicates, the fast option can be used.

Fixes #3973
 2020-04-11 22:57:29 +02:00
Ingo Bürk 62279aba45
Merge pull request #4005 from orestisfl/route_click_clutter 
route_click readability improvements
 2020-04-11 19:51:00 +02:00
Ingo Bürk f4b1da7f23
Merge pull request #4011 from orestisfl/floating_reposition-needs_tree_render 
Call tree_render if floating move changes workspace
 2020-04-11 19:50:14 +02:00
Ingo Bürk 93bb2022bb
Merge pull request #4012 from orestisfl/floating_maybe_reassign_ws_focus 
floating_maybe_reassign_ws: only re-focus if previously focused
 2020-04-11 19:49:53 +02:00
Ingo Bürk e47d5f6a3e
Merge pull request #4008 from orestisfl/limit-run_command-LOG 
Limit log length with IPC commands
 2020-04-11 19:49:24 +02:00
Ingo Bürk 1e9fbd7186
Merge pull request #4010 from orestisfl/trailing-whitespace-log 
Fix trailing whitespace in a DLOG
 2020-04-11 19:49:05 +02:00
Orestis Floros 5eab604a10
floating_maybe_reassign_ws: only re-focus if previously focused 
Fixes #3979
 2020-04-11 11:10:51 +02:00
Orestis Floros 755d306df3
Revert "floating_reposition: avoid extra tree_render" 
This reverts commit 204eefc679.

workspace_show does not call tree_render
 2020-04-11 11:08:55 +02:00
Orestis Floros bb8f2927ae
Call tree_render if floating move changes workspace 
This fixes a bug where moving a floating container with
cmd_move_direction displays a "broken" state if the container crosses
workspace boundaries.
 2020-04-11 10:52:35 +02:00
Orestis Floros e4cfb80a05
Fix trailing whitespace in a DLOG 2020-04-11 10:10:44 +02:00
Orestis Floros 964456b628
Limit log length with IPC commands 
Fixes #3525
 2020-04-10 16:59:46 +02:00
Orestis Floros 57a37f8af4
run_command: Update outdated docstring 2020-04-10 16:41:36 +02:00
Heman Gandhi b247896a75
Move parent nodes in scratchpad correctly (#3793) 
* Move parent nodes in scratchpad across workspaces

Co-Authored-By: Orestis <orestisflo@gmail.com>
 2020-04-10 16:27:40 +02:00
Ingo Bürk e2b2a28625
Merge pull request #4004 from orestisfl/i3bar-segfault 
Fix SEGFAULT when i3bar receives invalid input
 2020-04-10 14:00:51 +02:00
Ingo Bürk 312d3dfbd3
Merge pull request #4003 from orestisfl/update_desktop_properties_on_move 
Update EWMH properties on workspace move
 2020-04-10 14:00:26 +02:00
Ingo Bürk 1e6b510497
Merge pull request #4002 from orestisfl/DLOG_CHILD 
i3bar: Add a macro to log child info
 2020-04-10 13:59:55 +02:00
Michael Stapelberg 960df0dbfc
Makefile: add bear target for using clangd/ccls language servers (#3953) 
After installing clangd and/or ccls (Emacs eglot defaults to ccls),
run e.g. make bear -j32 and restart your editor (or just its language server).
 2020-04-10 12:26:03 +02:00
Orestis Floros 58d383b1a0
route_click: Remove condition that is always true 
For reference:
typedef enum { CLICK_BORDER = 0,
               CLICK_DECORATION = 1,
               CLICK_INSIDE = 2 } click_destination_t;
 2020-04-10 12:24:18 +02:00
Orestis Floros 07c7384272
route_click: Add some const bools for readability 2020-04-10 12:22:24 +02:00
Orestis Floros b401cc994b
Merge pull request #3954 from xzfc/floating-tiling-resize 
Make floating-tiling resize code consistent with plain tiling resize
 2020-04-10 12:17:26 +02:00
Orestis Floros 59108ec299
Merge pull request #3816 from sandsmark/martin/empty-matches 
Match empty window properties (e. g. no title set) #3308
 2020-04-10 11:44:46 +02:00
Orestis Floros 91ec14f2bc
Fix SEGFAULT when i3bar receives invalid input 
Fixes #3844
 2020-04-10 11:38:19 +02:00
Orestis Floros ed67eaca2c
Update EWMH properties on workspace move 
Closes #3965
Fixes #4001
 2020-04-10 04:40:11 +02:00
Orestis Floros c46fdc8363
Merge pull request #3995 from xzfc/refactor-property-handlers 
Refactor property handlers
 2020-04-10 03:58:12 +02:00
Orestis Floros 40697a233c
i3bar: Add a macro to log child info 
Mentioned in #3242
 2020-04-10 03:22:34 +02:00
Ingo Bürk c611b9e0e0
Merge pull request #4000 from orestisfl/revert-3983-resize-behind-fullscreen 
Correctly handle mouse resize in fullscreen containers
 2020-04-09 16:41:43 +02:00
Orestis Floros 6fa2cd32a0
handle_button_press and route_click do not need to return int 2020-04-09 16:16:30 +02:00
Orestis Floros 93e96f4e6b
Do not propagate $mod+right click to clients 2020-04-09 16:08:41 +02:00
Orestis Floros b590ca076c
Avoid resizing fullscreen container with non-fullscreen 
Another option is to modify resize_find_tiling_participants but this
would also affect resizing of tiling containers in scripts, so I chose
to make this change specific to resizing with the mouse.

Follow-up after #3983
Fixes #3980
 2020-04-09 15:49:09 +02:00
Orestis Floros 4922b245c1
Revert "Avoid resizing fullscreen container" 
This reverts commit 1a2882d740.

As mentioned in
https://github.com/i3/i3/issues/3980#issuecomment-611515497, this
disables resizing children of fullscreen containers.
 2020-04-09 15:11:46 +02:00
Ingo Bürk 26cbca3d27
Merge pull request #3999 from orestisfl/cmd_focus_sibling_workspace_crash 
cmd_focus_sibling: Fix crash on workspace level
 2020-04-09 11:47:32 +02:00
Orestis Floros 4b4f1f604f
cmd_focus_sibling: Fix crash on workspace level 
Fixes #3997
 2020-04-09 11:29:14 +02:00
Orestis Floros 016d4a3f45
Call cont_child() more liberally (#3996) 
Following the reproduction instructions from
https://github.com/i3/i3/issues/3242#issuecomment-436175346

For me, #3242 happened when the following sequence executed:
1. Fullscreening window correctly calls `stop_child()` in
6e24e2ad6f/i3bar/src/xcb.c (L685)
2. Xrandr change, `reconfig_windows()` is called and `output->visible` is
set to `true` in this line:
6e24e2ad6f/i3bar/src/xcb.c (L1791)
3. When the window's fullscreen is disabled,
`handle_visibility_notify()` returns in this line:
6e24e2ad6f/i3bar/src/xcb.c (L677)
because previously `output->visible` was set to `true`

To fix this, I call `cont_child()` more leniently since it is a no-op
when the child is not stopped.

Fixes #3242
Closes #3761
 2020-04-09 10:43:48 +02:00
Albert Safin d9d366a656 handlers.c: cb_property_handler_t: take Con instead of xcb_window_t 
Since every handler calls con_by_window_id() and checks for NULL, it is
better to move this call into property_notify().
 2020-04-08 08:37:40 +00:00
Albert Safin e03fdef3e5 handlers.c: property_notify(): DLOG and return in case of an error 2020-04-08 08:37:40 +00:00
Albert Safin 5716ff541f handlers.c: remove redundant property fetching 
Some property handlers trying to fetch property again if `prop == NULL`.
This is redundant since these properties are either fetched by
property_notify() just before or deleted.
 2020-04-08 08:37:40 +00:00
Albert Safin 148ff54f18 handlers.c: remove unused arguments from cb_property_handler_t 
Also, use `conn` global variable instead of passing it as an argument.
 2020-04-08 08:02:17 +00:00
Orestis Floros 6e24e2ad6f
Merge pull request #3985 from orestisfl/userguide-button6-7 
userguide: Add button{6,7}
 2020-04-07 20:20:00 +02:00